From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD9B5C83F27 for ; Sun, 20 Jul 2025 03:03:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 697806B009A; Sat, 19 Jul 2025 23:03:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6489C6B009B; Sat, 19 Jul 2025 23:03:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5378D6B009D; Sat, 19 Jul 2025 23:03:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3F0056B009A for ; Sat, 19 Jul 2025 23:03:51 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DF5D811094F for ; Sun, 20 Jul 2025 03:03:50 +0000 (UTC) X-FDA: 83683148220.15.3E94947 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by imf08.hostedemail.com (Postfix) with ESMTP id 1790116000A for ; Sun, 20 Jul 2025 03:03:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Nzk/W95a"; spf=pass (imf08.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.48 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752980629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zCjuC119tyiMw7gaePzpsOiGU0ul4JjOaj2XTy2l69A=; b=lee/C8lvDpqVYZohM6lgwr5SFtdFvbtW4GDVDlAxYdpVg5ZM7+cLrB95TPaNCpCLmoXX8z 2JUyER3U/5HlQ91I/o5XJ1xK2gQLTyRY8NimijtfXMuv6XKBwdaeDxnEWpghNiU2VZGKkj iggUj4G5DboUJlWRe6pOj1rdOGioVvM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Nzk/W95a"; spf=pass (imf08.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.48 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752980629; a=rsa-sha256; cv=none; b=5dJDhn6TNTzjeOJeJkNlkjaZeSGuJIpx6NR4Tqa4zNEIEL+x4tnn8JCnPvHXHRS+eLTvMc eHaXW6+Wm6bU8QAbxck2RCPyre8AZomyYUu1mgW3CcIM0u5Xc4MBf7V5TtXU9Jhs1AHqFN 53JadyUpLfxevQuCGJRrw2zoc+XLLVg= Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6faf66905baso41344096d6.2 for ; Sat, 19 Jul 2025 20:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752980628; x=1753585428; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zCjuC119tyiMw7gaePzpsOiGU0ul4JjOaj2XTy2l69A=; b=Nzk/W95alJ/O2jlpS65mpVnltu7GW3hiKCxCPI417CwyQ15MFluZ9NR0MTXwCR2BEh kAXs7f7zqLni/RbjI9zUjQruzKEX+kgQ010ga3qGvv2eECsIME46+iu/8/RBZYNa0RYy s0TjcwCGsgNpmxOUPJRItsqoTRUqQN9xPICNFvCZGmGCGzjxdFXFvtiVfpGUVzBeqDoO lTWTDcklwt/OhLi/RLAE9gk5KKqhk8Yaz6dJBrGwgaCOjNsSlZCTq05Ua6Fh8nhc2tl+ Xn9hTM8hCBvvzuPFQ4fOM72dSGAkxJ5yCOPfU30MJNczHqWFai0BUekwE1yJwJIADECq AOZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752980628; x=1753585428; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zCjuC119tyiMw7gaePzpsOiGU0ul4JjOaj2XTy2l69A=; b=lJ0K8lE0rT4bJwcjVoyhmEjY13jm75S2zeDlZ9VSbjoqL+ypVcP4R0WLmbJ/sEl95i 6bu/PgtznewBNuPSXVtxtsTUxRySAfI3YcIsNsfQLrAfl6NlIdShP8bD+A0Q8bcj0SIr +L+bWn6bhUA8Trd3AzZBTD9pB6yyRl2mdjzwF93XTyv5LHtqPXkfL6Sz9UAwtydcWTvu G0PLY+VG7nEIyN278g/skbgHySBRqCe+lPZw8cJQFkh63W/LvKPB243bQEmsYI2hkoS4 L5NQf6i+wlLFPXTzvE1KP9JbjUQoGMWlFiiWj/Eqm/ppVA3EmayhQXD40afuS9SHt9Il c6GQ== X-Forwarded-Encrypted: i=1; AJvYcCVZKMUd+p+cfa0GoeS0DDovIOInFkqIT9anZxTTa5/XW1jxT+v0czEaQUgRh5D7ipaTyhZ1RWtDsw==@kvack.org X-Gm-Message-State: AOJu0YyEqkvGDN0rytgpSM4UYyiZA5z10ErIPehITBEz9cswURNBTuxt saZV2OxdhOEtDOGT4S6UCm0nJWbKLUXarjFTTyrkZjtT599rRZUdrjWhDbPj8tbQN48FEkjolo+ nuK1gPZYe3G5eOW7JRzZ0DNbiY1UXNaw= X-Gm-Gg: ASbGnctk+ZF3AHSvBIGXu/VtnVwzUeGnIeIRtVxommZYhZpSGNn/adDkhVctNJ1ACUl m3E5d/5b6GvFLY1mFxOP6gAVa6aiq/kiwHOY0pZrtdy2Q68qCi+S6hagcmPdlPDacRkNekHMdqW gfmLqyEw3Nk7/TgNsyhnyufTHib+7i9Wb/8TR7c/G5FM2JECZZVY6WH5SOEern5/QzyEHOhjcD8 z1b02XawgBrlQamn5Q= X-Google-Smtp-Source: AGHT+IFhOPYOf/lckF/l/0RcodINTrGCuCkeA4w9OuSdtZDV82b9jV+CxWQUwA5sEfoCOGGbPl3M/yeg8nq9/Fl1lSo= X-Received: by 2002:a05:6214:5d0f:b0:702:d822:9381 with SMTP id 6a1803df08f44-704f6a6ba4fmr278869956d6.19.1752980628228; Sat, 19 Jul 2025 20:03:48 -0700 (PDT) MIME-Version: 1.0 References: <20250608073516.22415-1-laoar.shao@gmail.com> <20250608073516.22415-4-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Sun, 20 Jul 2025 11:03:12 +0800 X-Gm-Features: Ac12FXwhvamZBGFJ_Yw_P0mAAohn5C7tPLVHgwv3BzaZced3l3dpggPaVLhZxs0 Message-ID: Subject: Re: [RFC PATCH v3 3/5] mm, thp: add bpf thp hook to determine thp reclaimer To: Usama Arif Cc: akpm@linux-foundation.org, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, hannes@cmpxchg.org, gutierrez.asier@huawei-partners.com, willy@infradead.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 9yhjqnu4k7gw9mh9k3xjjkgbznndz46i X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1790116000A X-Rspam-User: X-HE-Tag: 1752980628-621206 X-HE-Meta: U2FsdGVkX18kquuzqVeTtCpDyn63yOVRCTlr4W2Lmwx3NX4fYmxXOcX9b//f6z5JjmstJ1EtnjPwv9nTtV/FRDUwTvD1MMD/TFggVtVCh3rcRcKlM6CLc6+N6CxOruYeLm/GBVPcBPtdCQl3dPIyPYjlZWRdmuh6cFA2dUdtw6Ykr9hy4cKZBPMAgCpoDSa8KSECwunv+duND1aozyQcP3IlKJw4p47rsBHyX3EA48U26lg98Yedu8I64VnkwTmbSjMsVePX6oy9q6NcHnYt8G1rl0Yv9V0j5RtD2G5ythDDr5xhP9omYBB/0/wgTx+weli+Gu1jjMXb9A2Ojf3Bl+9luqsQbPrl6SVIj/iMv5QGAtbtIPvF1/vygt62EUgMnHWHCT+OxT7qRDLJr7V8LlayQGtkpkWBfjg5bR/we9fzCjUI2G0VQbNPsEW8zVCeaeWzGrmWAvcZ0g8Thl4/Wbxm++faxPD1omZxOlpzIg3OxsRMYZNEvn0UO2DS6JxUvs2+FSjskQ7d2LgC1ITXA0JSTAn1lQ/owIIUWyik6UXLvs4TvmTrmlHo1mCvTMy9AA/eSO3avfzlh1IemKcIZ4JZOX31ragUrJ1OTc4uPqkdm2OP3impFH/Bp3DOxZFxJfztOK/Ly0bwahvqAH0i5WXVhMZbRE7glLfPeOQ6vIWucGWdSp+PhsDWps/OrJyYSnxDajreJE8EVKcZQtnePK3KPQZtkWiMEIR1P2yVz0R8PsaBEjGP6CNqMcZtCk2BWgf9/0UvNLZZo8ZsGW0uQQtOPF54E37PMexhkzZX5WGLGpgNss2WqVy0OQI2DnCs48GXV2jbCyj+u3KpS6MfctWc7z2BzOfjiS7pVHjP9wKWPX5TgsnD8rvAGnRvFh/EwTcxR9T+Kya494aROoS6UMXBOlbvCyvp/UX5njejQ2mSJ4+XrNF603UeXOkZ+74EmeKcPFPLaKoBmlgJBPR tf3Tidca qfgqOZduGopqIypUtVR04bFbO8oig9ZO1bq5eFwhemlErUHXZHSH27BC85sQOmRzOoP4iO2yIu49gm3lL/jSNK38mrjEerSIZecVXZFLP8gKwX7FVQ7AMKNamdUa3q0T//p5tCGXGLSwVUpnT+KYPrYEKw6BN5NtbMvV10aNJBtABtd3N0LdMB8uj4LpN3SLV4deMVWai2r34cQOaJfsQm7ix8DKADRkvFiVojZszWrat7QRZn+zoepRuwubvHlvS66KrY8o5LV6LuZnjM5sFsNYw0LGdW5krDBzUdfPcNk07UHYSGz1Zb5d+Bdzzb5PCO2yEpxcCW/pbxc6Pa4j9Y9KRkaRSrYpm73H6yOCm5WAdYLfXaPVX8y6ReWdlUvSPenoqTl3FCjbbsIC6fXeebVP1lRb0aDNB3ha1neRL58xcpQFl3UG3NFS2jWgTIFtp9+bj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 18, 2025 at 12:06=E2=80=AFAM Usama Arif wrote: > > > > On 08/06/2025 08:35, Yafang Shao wrote: > > A new hook, bpf_thp_gfp_mask(), is introduced to determine whether memo= ry > > reclamation is being performed by the current task or by kswapd. > > > > Signed-off-by: Yafang Shao > > --- > > include/linux/huge_mm.h | 5 +++++ > > mm/huge_memory.c | 5 +++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > > index db2eadd3f65b..6a40ebf25f5c 100644 > > --- a/include/linux/huge_mm.h > > +++ b/include/linux/huge_mm.h > > @@ -198,6 +198,11 @@ static inline int bpf_thp_allocator(unsigned long = vm_flags, > > return THP_ALLOC_KHUGEPAGED | THP_ALLOC_CURRENT; > > } > > > > +static inline gfp_t bpf_thp_gfp_mask(bool vma_madvised) > > +{ > > + return 0; > > +} > > + > > static inline int highest_order(unsigned long orders) > > { > > return fls_long(orders) - 1; > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index d3e66136e41a..81c1711d13fa 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -1280,6 +1280,11 @@ static vm_fault_t __do_huge_pmd_anonymous_page(s= truct vm_fault *vmf) > > gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma) > > { > > const bool vma_madvised =3D vma && (vma->vm_flags & VM_HUGEPAGE); > > + gfp_t gfp_mask; > > + > > + gfp_mask =3D bpf_thp_gfp_mask(vma_madvised); > > > I am guessing bpf_thp_gfp_mask returns 0, as its something yet to be impl= emented, > but I really dont understand what this patch is supposed to do. This change only introduces a placeholder for the BPF program. It might be cleaner to squash it into patch #4. --=20 Regards Yafang