From: Yafang Shao <laoar.shao@gmail.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: akpm@linux-foundation.org, paul@paul-moore.com,
jmorris@namei.org, omosnace@redhat.com, mhocko@suse.com,
ying.huang@intel.com, linux-mm@kvack.org,
linux-security-module@vger.kernel.org, bpf@vger.kernel.org,
ligang.bdlg@bytedance.com
Subject: Re: [PATCH v3 3/7] mm, security: Fix missed security_task_movememory()
Date: Sun, 3 Dec 2023 10:57:47 +0800 [thread overview]
Message-ID: <CALOAHbDYg=Oi9BEiAiGaG+Qj3WQ27Ef4=Ox8i6vHwucGFpmARw@mail.gmail.com> (raw)
In-Reply-To: <20231201205039.GB109168@mail.hallyn.com>
On Sat, Dec 2, 2023 at 4:50 AM Serge E. Hallyn <serge@hallyn.com> wrote:
>
> On Fri, Dec 01, 2023 at 09:46:32AM +0000, Yafang Shao wrote:
> > Considering that MPOL_F_NUMA_BALANCING or mbind(2) using either
> > MPOL_MF_MOVE or MPOL_MF_MOVE_ALL are capable of memory movement, it's
> > essential to include security_task_movememory() to cover this
> > functionality as well. It was identified during a code review.
>
> Hm - this doesn't have any bad side effects for you when using selinux?
> The selinux_task_movememory() hook checks for PROCESS__SETSCHED privs.
> The two existing security_task_movememory() calls are in cases where we
> expect the caller to be affecting another task identified by pid, so
> that makes sense. Is an MPOL_MV_MOVE to move your own pages actually
> analogous to that?
>
> Much like the concern you mentioned in your intro about requiring
> CAP_SYS_NICE and thereby expanding its use, it seems that here you
> will be regressing some mbind users unless the granting of PROCESS__SETSCHED
> is widened.
Ah, it appears that this change might lead to regression. I overlooked
its association with the PROCESS__SETSCHED privilege. I'll exclude
this patch from the upcoming version.
Thanks for your review.
--
Regards
Yafang
next prev parent reply other threads:[~2023-12-03 2:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 9:46 [PATCH v3 0/7] mm, security, bpf: Fine-grained control over memory policy adjustments with lsm bpf Yafang Shao
2023-12-01 9:46 ` [PATCH v3 1/7] mm, doc: Add doc for MPOL_F_NUMA_BALANCING Yafang Shao
2023-12-01 9:46 ` [PATCH v3 2/7] mm: mempolicy: Revise comment regarding mempolicy mode flags Yafang Shao
2023-12-01 9:46 ` [PATCH v3 3/7] mm, security: Fix missed security_task_movememory() Yafang Shao
2023-12-01 20:50 ` Serge E. Hallyn
2023-12-03 2:57 ` Yafang Shao [this message]
2023-12-01 9:46 ` [PATCH v3 4/7] mm, security: Add lsm hook for memory policy adjustment Yafang Shao
2023-12-01 9:46 ` [PATCH v3 5/7] security: selinux: Implement set_mempolicy hook Yafang Shao
2023-12-01 9:46 ` [PATCH v3 6/7] selftests/bpf: Add selftests for set_mempolicy with a lsm prog Yafang Shao
2023-12-01 9:46 ` [PATCH v3 7/7] NOT kernel/man2/mbind.2: Add mode flag MPOL_F_NUMA_BALANCING Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbDYg=Oi9BEiAiGaG+Qj3WQ27Ef4=Ox8i6vHwucGFpmARw@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bpf@vger.kernel.org \
--cc=jmorris@namei.org \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox