From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE98C433E1 for ; Sat, 11 Jul 2020 01:55:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A2BA220725 for ; Sat, 11 Jul 2020 01:55:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M7P0dNpc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2BA220725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2916D8D0006; Fri, 10 Jul 2020 21:55:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 241968D0001; Fri, 10 Jul 2020 21:55:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 131B88D0006; Fri, 10 Jul 2020 21:55:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id ED9318D0001 for ; Fri, 10 Jul 2020 21:55:05 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6FE66180AD81A for ; Sat, 11 Jul 2020 01:55:05 +0000 (UTC) X-FDA: 77024126970.14.seed58_21018de26ed3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 497CE18229818 for ; Sat, 11 Jul 2020 01:55:05 +0000 (UTC) X-HE-Tag: seed58_21018de26ed3 X-Filterd-Recvd-Size: 4158 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jul 2020 01:55:04 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id y2so8000611ioy.3 for ; Fri, 10 Jul 2020 18:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fHI4iXtmX01yNpRFDCOqzvlBSYR9wvdFvILVM3jzt4w=; b=M7P0dNpcggbgMq8M3ZUKrRzfuzHd/DzMtIcX7NdMEr00hAR/QZ8gt5RoDEUgT1yOxK px4ROFrpvTlpcSBMIMFpfZzmLQxIPjab+7WvXPLMWWZzjghjraS92SqCf6bTARF55h6F 6lUI+pieHU7pOZjluSZcZ0NCsGMSZ3qjzBpM/dfPFHQB6JBGG3pG9g57SsnS+xx017up OVdNzDD6+oFnkmXyclJYkItOLkzZlfybaEfvA7vnpYcFQ3AJalyhdgL0F2aDpZGwDrwM NQIU+H9g9Y5ufClFM/5bwUhV9ABYhzjWAOJwqtxpZx46WosAw1d6pqlhBRkAkmsGYCXB 27LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fHI4iXtmX01yNpRFDCOqzvlBSYR9wvdFvILVM3jzt4w=; b=Y7b+nYVC3jovc42VTCPsDiRIAf90Kvp6OuNkTGlUA2kWdE1JbNMP8Ogp67/HJwQsGJ OtWB+vtXUTiuBtNtxzVUCowQliaA8jUE6aU/wIIB0lIIKQMKIvo/KQfMCS5wiBURpbVr 9gtvnGTCgWO4Oj03t25/JC1NSbC68WWBPgAxMIlm9czaivwJ9zIx9nX3MtwxQtPhw+Bb FsschcfN2HCtIN7olPYTUL3ycy42NQ384IpSEIQu34r4w34IdcSeqIo6EJ+hXRhqTGwx 13dqFC0kmH6jwKDfL5J8oxj0kcDhTrlZv6UtutaZRrtfozkLMgqDzbVA6cbEMkRD6iRX W9og== X-Gm-Message-State: AOAM532sYxRZXmMRJFKi0afyaF1VvUOGhy/rxzxhmKrPvbQzGc12z8mU g9iOKScScM5o/GJxgx74zMks4Z1kN31d35uWEgo= X-Google-Smtp-Source: ABdhPJz6XuX2EPyiuy7Eq7m/T1DuQ4iZ2Gio4juwxIYfQIGYc6DsjbM7fcsqWQUrfO4N3DLRieTnx6j+OPbH0z0oIk4= X-Received: by 2002:a5d:9752:: with SMTP id c18mr26549080ioo.10.1594432504271; Fri, 10 Jul 2020 18:55:04 -0700 (PDT) MIME-Version: 1.0 References: <20200711011459.1159929-1-shakeelb@google.com> In-Reply-To: <20200711011459.1159929-1-shakeelb@google.com> From: Yafang Shao Date: Sat, 11 Jul 2020 09:54:28 +0800 Message-ID: Subject: Re: [PATCH] mm: vmscan: consistent update to pgrefill To: Shakeel Butt Cc: Johannes Weiner , Roman Gushchin , Michal Hocko , Chris Down , Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 497CE18229818 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.065731, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 11, 2020 at 9:15 AM Shakeel Butt wrote: > > The vmstat pgrefill is useful together with pgscan and pgsteal stats to > measure the reclaim efficiency. However vmstat's pgrefill is not updated > consistently at system level. It gets updated for both global and memcg > reclaim however pgscan and pgsteal are updated for only global reclaim. > So, update pgrefill only for global reclaim. If someone is interested in > the stats representing both system level as well as memcg level reclaim, > then consult the root memcg's memory.stat instead of /proc/vmstat. > > Signed-off-by: Shakeel Butt Acked-by: Yafang Shao > --- > mm/vmscan.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 5215840ee217..4167b0cc1784 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2030,7 +2030,8 @@ static void shrink_active_list(unsigned long nr_to_scan, > > __mod_node_page_state(pgdat, NR_ISOLATED_ANON + file, nr_taken); > > - __count_vm_events(PGREFILL, nr_scanned); > + if (!cgroup_reclaim(sc)) > + __count_vm_events(PGREFILL, nr_scanned); > __count_memcg_events(lruvec_memcg(lruvec), PGREFILL, nr_scanned); > > spin_unlock_irq(&pgdat->lru_lock); > -- > 2.27.0.383.g050319c2ae-goog > -- Thanks Yafang