From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3610CC636D7 for ; Thu, 9 Feb 2023 11:28:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A8456B0071; Thu, 9 Feb 2023 06:27:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 830526B0072; Thu, 9 Feb 2023 06:27:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D28E6B0074; Thu, 9 Feb 2023 06:27:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5BB4C6B0071 for ; Thu, 9 Feb 2023 06:27:59 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 13C1EA0225 for ; Thu, 9 Feb 2023 11:27:59 +0000 (UTC) X-FDA: 80447529078.07.FD14394 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf17.hostedemail.com (Postfix) with ESMTP id 6241C40011 for ; Thu, 9 Feb 2023 11:27:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=X4K+h7SD; spf=pass (imf17.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675942076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nV+ybsSlH6fK2G24aANd2g+1dPs+ZMjcUBV127jT5iM=; b=gV6w095UYJMEcZUccPYu3qHgx9Bxo80JF+ox0Me6CLDHy8nWIN4c/+HuoEpWIihWEIUBIV QCNQ/iawD5kP3yLz/5WxEOoDmG3TGiyWaVNX/DKkAKH5ZXshDbS4HUR1m1dM4PVwc1wccc Joi5WHJUe/tm2F5ztgdOh2fCjJaaqmM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=X4K+h7SD; spf=pass (imf17.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675942076; a=rsa-sha256; cv=none; b=pNqokUAMObc4VH9iMbc+IcnJvjnMft6VVrPUUr6+Lbkx/EOYcNKgwk/OaThObANRwkCuLe YmMt4lgZVdZm5tKInyM0NRFmUjH9TkKG8u+qNKk0ghpa7DKozyaOnV8JRDoriev2lKmhj0 Cd1oEfY3dUAa8ITDmHu+fo4lLQ0+jV8= Received: by mail-qk1-f173.google.com with SMTP id p16so676545qki.9 for ; Thu, 09 Feb 2023 03:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nV+ybsSlH6fK2G24aANd2g+1dPs+ZMjcUBV127jT5iM=; b=X4K+h7SDmsgXeHm6SaOqKeAx/ak9ol/Gl36DDVrtd9v5mfV9VkvblhU8nQ43XAXExl 0Zt1F2nx9zBjVlXcB9TLAnC4pptj6RhMdfPfaW4zmacNVeI+g/po+g/eMkChVxAP/2Ax CNaLrdvnBvR1x//Vr2yOVxi6ZZEf/35FNvK9RLIsbuDGGL6TZD3ypxsOg3oYdWA11JSX yrmzxUfCSoBErji/R5CkNVV5s1KtCukigZsgcVZWCc6iRl2caL7yZR0Vz5WN4B25B3Fp jNQachOCoE6xeArss8RVs5hTwBaK6XEl43IezJq0vEZXHe1+l8IlpFNDe7I+gyGTcW9S rR+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nV+ybsSlH6fK2G24aANd2g+1dPs+ZMjcUBV127jT5iM=; b=01BItB/qEMpEFUSq3zyZUN6KVgzF8+mwiuZZ3+pZnR8ccdAZembV1D47wIlHM8hW3I ZLkxTNGOlyH4ey8UOHOCke/FXHaxnL4p04cvEhNomUpFrQtZiUey6e5v32fK8pOZwzz3 QH6m2tZe09LNuhhPkROsLZO2Z916d0/FwUp9UJv/0bf3eU9ZRTWjaTE8aNynNZQj5mZx +TS7tATCvsFb6En3c4DLGnkV/2wq/Oth0zNqI11KVgC5cUn6eq/eMNc5deJdXu3w0bln 6wuhl5RuiK3IL3jA658llBonmubiQVEVI1pOuM1m3FFKGOx5Biy1UtKC0q4TUvdGw0w1 8lOw== X-Gm-Message-State: AO0yUKWLDvO8jpG2hqS+H9YkjMtORX0viIA6OuBa1QXTeiAOJ3ug2k9e ICLwcv2a/5cDv6eY4J2QLd38wSq71F0/VHLJeSE= X-Google-Smtp-Source: AK7set/aIuykduscL5dzsclscusdVySBk+Rd/puuz7bsZmF73NHfo4uN7Spu0LUCITVs/SjLa3b05rTr5/LxNbAB9mY= X-Received: by 2002:a37:42d5:0:b0:738:dd4d:986e with SMTP id p204-20020a3742d5000000b00738dd4d986emr421433qka.409.1675942075520; Thu, 09 Feb 2023 03:27:55 -0800 (PST) MIME-Version: 1.0 References: <20230205065805.19598-1-laoar.shao@gmail.com> <20230205065805.19598-3-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Thu, 9 Feb 2023 19:27:19 +0800 Message-ID: Subject: Re: [PATCH bpf-next 2/5] bpf: use bpf_map_kvcalloc in bpf_local_storage To: Johannes Weiner Cc: tj@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: hztk8s6ib99jjb5f3noiiuayi73gg4az X-Rspam-User: X-Rspamd-Queue-Id: 6241C40011 X-Rspamd-Server: rspam06 X-HE-Tag: 1675942076-209599 X-HE-Meta: U2FsdGVkX1/39kxykxPptLeGlz5ZvaPoPR6JA5NSyJouuK24hsoVf6K1qk0kkKRmmkMmgz/7Aa1++2A6q67tdMu4EzGpiXJltP4RWVBhiTLE274OJDchP2t/lGVSfgYEofhMAao2M/SnuKvw6mx25QhE0cHYIh0RpF9mIx4sKyoLI2czST9/alJQjjZHC/EipFXcuCSjU2pT+qlUUHOgauAcggEtVwvIh0A5/m+ltKa55mJoPddsaycZ7pOTsC0PqLloKiDTlZLymRrjucU1cpK/DrkkT7nu5usIFXbnirsMAIN7696YKozheo57Np0LUdTBJkIDqUigZBdzLiUFMtsWua5ys9SIFRXLzWjdJlFtsVVL+UuxwpPzGAd5CeTVk2whLuBkEkz3DPbMs8O44xeZ1TZSl8NKx+aqJ2Hv8nwa6vE8rUNLeoxbyjELFnQsZ38UN7nWnDixISPNJ0Y4nm86bJoiBLtME5jNcuwB6T3wzweVmv4Nrf+zf2nlmfFTUWKyI0cYXMGSp89cUwZEzVBH7LKddqW1V4DfzZ3IcbzDMWWnu7h0whs9Xze6yec/u+3OYa6v7StwjGqAQkae5XGGIZBDR8wk7gNH4xAJiNV0tDHQ0GkwKRiRk0vE+RwdMVSq5TyqKxgSq417lEnSbwpZMK5Yo+sXf70LpHF7IWPuxv1Jr/TjWlUHBaipOelbBlnkcBrtTPzqpX8jxjst0A3N5DesrEiNmfF1jfOg4UZ2I7TzurTjPEgnxyfPt4Dar+JH1f/q395CW5K4Te1MmHLdZ/BQuKvLfYouYrPSUqYiG/JXcQmqbg3s2p2uIrzpKz/FScBuG1kDvO1Ck45NvNpebKGu3rc2EqPVfG0pEcbWBLvdWi7M1F0TyRZDw3+L7T5PeJp+Hn6/vhWv1lD7ih2dwRxQGGhMjQJgzlGk6LfgAfUWKSNwBtZAItUYwSB3n6omyKoxRzEaWnYpwQU c3e36CPm G7ho/qew+GPQl0wwp65vOr6biPMeahVP1dLefTsrSq48zPFrNLbPLGcL6GIy++UgzAirW/H81/0uAxh+AyskhyG4hh6YjhW6Fv/3IK9DenwIbk/YIB4Wv2VwiKFqltsNKzw27sW/tRM/DX83mJlerDlNxDXLHBvqjaYrFTLt/Hm9p1p6BxU/mPhrN+S23JXHSzuMCnrvtKBo6rxxw5WxcioMciW9A1E967WbbApUFTeNk3aWoPo64237rhWmz6xVzt6RvTKkUA3ELRFDSy2KrwbOWVL4TKcwoGCnPL9v7MtfqB+zDwgr3z1VAQHy8psd7NAFrxRZNmpGqnNPYB2MKCrAQOCKiBxgudd7pOHq4wo1J0N9hgrUqWB3ybAMGECzU9kiIztBlWutvHURi50mFeOa/NGLppgc7n4c5NXtu2tc9O4+h2U8XzQsVOjvycFCuBKqzchBqrJFURgc/F1i6el4zQYUHofWAMHPpisjsojZaQCXC9+fkh+VwbNHY0sfMCOAR4IoETuiNmoVScz8yK2HVLw2BHtUkGGMbV7On5+K8U5gQIVhJRLuMjktdd1LdSLVUDSxjH6XcNpyJF+ZgtXX7S299dTQyx7sC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 9, 2023 at 3:25 AM Johannes Weiner wrote: > > On Sun, Feb 05, 2023 at 06:58:02AM +0000, Yafang Shao wrote: > > Introduce new helper bpf_map_kvcalloc() for this memory allocation. Then > > bpf_local_storage will be the same with other map's creation. > > > > Signed-off-by: Yafang Shao > > This looks good to me, but it could be helpful to explain the > user-visible part of the bug somewhat, i.e. who is being charged right > now for the allocation if it's not the map owner. Sure. Will improve the commit log. -- Regards Yafang