From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F5FC433EF for ; Thu, 7 Jul 2022 10:30:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68F116B0072; Thu, 7 Jul 2022 06:30:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63DBF6B0073; Thu, 7 Jul 2022 06:30:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 555406B0074; Thu, 7 Jul 2022 06:30:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 46B3B6B0072 for ; Thu, 7 Jul 2022 06:30:26 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 1D0E68015C for ; Thu, 7 Jul 2022 10:30:26 +0000 (UTC) X-FDA: 79659934452.14.3BBBDE3 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) by imf23.hostedemail.com (Postfix) with ESMTP id C9D53140025 for ; Thu, 7 Jul 2022 10:30:25 +0000 (UTC) Received: by mail-vk1-f177.google.com with SMTP id a15so8638868vkl.10 for ; Thu, 07 Jul 2022 03:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iNt1u7R+eN/x3tIuhIyGJhKuokTR5Zn4HsNjpIKWO9w=; b=ifzYQYeHcS9UTCVMztgbre4Kl7knMGfpYmbp/qAVuj6OQX1IqUuFWPehUhfuukSBPV mpihsshtAqM6NAb5JYC/dt+CjlMfgHhVzYvUsDQUevmOT1lJlHQgk9uipA1h+6QZhyDd LVddxYN+JKJuThHxLXt6dQQwoo/zqKrLbJ9QuPS8uLDhrg5CC9yBK2mEnvdom42WhVdy 6qrUcv7adCR7/I3wFc36+qObmk3ZFmPEPDWZxssq3CAOTDiz5P9lPIHehPpLKNqMkkyI VPp0JbSMUZDb+UtnR3ZviWd75SvvSN9tN4XaMdaRoMTyPcjLjJUUF/o9U53WucclBXdF QQWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iNt1u7R+eN/x3tIuhIyGJhKuokTR5Zn4HsNjpIKWO9w=; b=YGA37ybh97N6Iopl3bssiuzTBBL5aUnSPZFMQiswhEP78XN6MxAvfIlZlb9ywcjUVn f9jcrtowaTzvQMlrep3XjLpRQfDEPmBa6HEs1p3HxzRE/eWcl5dsOLXcpTU9x1EeNPhw k9kZFrwIMOwY8HFrsbCixgv67WSRFUn/wegMtCCuZfJnKl2xZenOc7b7MoNYHuOyZSlK v8UKaoEKbz4saRzBjzyTdraSs9nmmxT8FgznpXcq6VBZpCZOAYCbfmkDVRrr5S9XC4fq JkxKP9KDVcRvcqfLTh3jZ2q2eJT2Pj08Jwfmbnikz0J2bQ18PKjDgpYExdrMqxEQY8xj /rfg== X-Gm-Message-State: AJIora8UlR/7gks2Ykm68LGnNtBNuZtFh+fXuJLVlq9acsh3oeaNb+Wy Qcw44jF3SzzoHT1j2kpNKjJ2FEm87DFkVe9mL2o= X-Google-Smtp-Source: AGRyM1utikq+PryJRTKyb6gB5KS4/sYQLvYxZ+RUZtw19TF8lZbhuB9N0gvKFcZfh2VV6s75CjgfprzgFIdIIWpny1Y= X-Received: by 2002:ac5:cc4c:0:b0:374:502d:85f4 with SMTP id l12-20020ac5cc4c000000b00374502d85f4mr1414185vkm.8.1657189825110; Thu, 07 Jul 2022 03:30:25 -0700 (PDT) MIME-Version: 1.0 References: <20220706155848.4939-1-laoar.shao@gmail.com> <20220706155848.4939-3-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Thu, 7 Jul 2022 18:29:48 +0800 Message-ID: Subject: Re: [PATCH bpf-next v2 2/2] bpf: Warn on non-preallocated case for missed trace types To: Alexei Starovoitov Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Quentin Monnet , Roman Gushchin , Hao Luo , bpf , linux-mm Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657189825; a=rsa-sha256; cv=none; b=p6i5nYKXSxIvBizn+4WhvoP0XllindVQ2EVX/UGxpD1Zv4ZPxFpNn2W/XZcFJk9FmxCKRk hCLSnyFsKdnikOmqB4njfsGgzVX/ViMHVTKfr1cdOk0MbgLgTrXAKbGUwecsVDhNpEKOba 6GhdeehjYBYjb15zHK3WM2Ml/H2EJ+U= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ifzYQYeH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.221.177 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657189825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iNt1u7R+eN/x3tIuhIyGJhKuokTR5Zn4HsNjpIKWO9w=; b=yPagxLxKe93QUTUs6XZ1rYClvIPd94A0W2IUjzterFOQ2Dif98KfTVpnnDkz0WIiRAOy5W 1nImecZSbhN6Xz97667vnC6+1/nmOF9Zbkzb2zmI08EpeXPZQXeklJ9DPAgFaxBaY8+5kE cUY623V3KuiradlSvhyEIZGGFvKi8Zs= X-Stat-Signature: chfi7jxh3w8h8at7nkeygnxuuo6pz1nh X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C9D53140025 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ifzYQYeH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.221.177 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com X-HE-Tag: 1657189825-893206 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 7, 2022 at 12:50 AM Alexei Starovoitov wrote: > > On Wed, Jul 6, 2022 at 8:59 AM Yafang Shao wrote: > > > > BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE and BPF_PROG_TYPE_TRACING are > > trace type as well, which may also cause unexpected memory allocation if > > we set BPF_F_NO_PREALLOC. > > Let's also warn on both of them. > > > > Signed-off-by: Yafang Shao > > --- > > kernel/bpf/verifier.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > > index df3ec6b05f05..f9c0f4889a3a 100644 > > --- a/kernel/bpf/verifier.c > > +++ b/kernel/bpf/verifier.c > > @@ -12570,6 +12570,8 @@ static bool is_tracing_prog_type(enum bpf_prog_type type) > > case BPF_PROG_TYPE_TRACEPOINT: > > case BPF_PROG_TYPE_PERF_EVENT: > > case BPF_PROG_TYPE_RAW_TRACEPOINT: > > + case BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE: > > + case BPF_PROG_TYPE_TRACING: > > BPF_TRACE_ITER should probably be excluded. Right, I have verified that BPF_TRACE_ITER can be excluded. Will change it. -- Regards Yafang