From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2DCAC61DA4 for ; Thu, 2 Feb 2023 14:12:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 274A96B0073; Thu, 2 Feb 2023 09:12:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 224F76B0074; Thu, 2 Feb 2023 09:12:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ECE96B0075; Thu, 2 Feb 2023 09:12:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F18046B0073 for ; Thu, 2 Feb 2023 09:12:14 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A5A60C0EA7 for ; Thu, 2 Feb 2023 14:12:14 +0000 (UTC) X-FDA: 80422541388.16.024CD44 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf20.hostedemail.com (Postfix) with ESMTP id E68831C0005 for ; Thu, 2 Feb 2023 14:12:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="fN/lac7S"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675347132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8lKwPpkPDxwm1VBqDHuuHVHYFGb1CHGpldcsBIhtkdM=; b=c8YfyexduLl1cyttactiFJiDYXBygWXX0E8EDci9wy8ZCFRmFPx0Xyc5J+8OSUh24FUN/f ykscIpOKJ6tSEWYyvejZNKRd/LquxSHfdewi8p1MbMM7KBghIGfHdnLfvRAo9JqNKQ28Sz 8/dODI8H6+6Z9RI4W4hIyVwTm0KwOTo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="fN/lac7S"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675347132; a=rsa-sha256; cv=none; b=YliemjLj+peJ0wTZxqrffHURa3NYrLBhmsKPeIIAxcSQ831/01wu2ZH7ATtCtCQXJFSdkI C5nGx0dfEo65odxVXWZsOUG1jKn7aUX5RpPskaSis7lK7WevuVTre2Ktu82kY30382/7Pp pTslII6L1BQnvawmvoZZ1s7Pd+lBe0w= Received: by mail-qt1-f180.google.com with SMTP id h24so1959387qtr.0 for ; Thu, 02 Feb 2023 06:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8lKwPpkPDxwm1VBqDHuuHVHYFGb1CHGpldcsBIhtkdM=; b=fN/lac7S0hEha5x8ywniY7iRYMzhonZYyA0EvuvEBq5QbCZHEPgZsn7N4hiR5LgeaO Jh1fkkK4eKeZKgNa2tMvfn6N0q4W+SCCRrKMyDuJpUUIVYH+luyi/t+uEtsaoQ6RidvS beRW6DCDMqRhXeoLebx7wyoBwmlzf/++Rcl1TcoypuidOIior69I1RwPavAz1vBRIXLS y2jK89CaBkav/OtELC5vP2FOEgvZvhV4asMXSwWK5UNyYghmj2vBPaGB6gvBXYtfl5l7 78ctZVTOxPjqXUT9T0nMxcfk97joBOH5rjcet4q9urTUosSkzmy+bs3WZs+6xHIYkT1r ej+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8lKwPpkPDxwm1VBqDHuuHVHYFGb1CHGpldcsBIhtkdM=; b=yvg25Ej+tUbweOBJliaJiqjdg1CIwVkT8DTLzAt5wqePFZ1U6N95GB9bZ9MbcNtF7Q /irtjbq37SwFuarjYqKbGbc/sFAsvy4WDaEJ5kCLw3oukCs2qM9jV/1i+WsHOZ0rGSS+ Kye/kYE91qjrqFjV6gy5QycDgDOm9ES4QyfdNak89CHCWJEd3eE2/WCj/aXcwdgs1QWH ZFaPJOLxWl+V0R550k95Gyzl/Q3I0dLNyKBRB+6eFDDhvDRHdwNHAnfeZCpXEPaHhG/f HqNkUDFu49AbAIRFngqPWeIGtxwHAoqcOWi1sQEHKDhtQHrWZriz77H96ExZpaBTZEP4 6jpA== X-Gm-Message-State: AO0yUKU55aurpXJqkkc8NWoOOUkye09C/K7DecpG4ciimobPOBA5nF1c CSjLtHb5D7MlbFAY6abUn934AuNZfahLhb2NuVU= X-Google-Smtp-Source: AK7set9k5XCQtHVBDhmS2cTjynxpRw3/UekFOEHwWW/291ryl6hyF+HTz1I4NTG83hwQ78BYzyTyhDxsbXw/IdAbDg8= X-Received: by 2002:a05:622a:1ba9:b0:3b4:6444:546b with SMTP id bp41-20020a05622a1ba900b003b46444546bmr581897qtb.295.1675347132004; Thu, 02 Feb 2023 06:12:12 -0800 (PST) MIME-Version: 1.0 References: <20230202014158.19616-7-laoar.shao@gmail.com> <202302021258.By6JZK71-lkp@intel.com> In-Reply-To: <202302021258.By6JZK71-lkp@intel.com> From: Yafang Shao Date: Thu, 2 Feb 2023 22:11:36 +0800 Message-ID: Subject: Re: [PATCH bpf-next 6/7] bpf: introduce bpf_mem_alloc_size() To: kernel test robot Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, tj@kernel.org, dennis@kernel.org, cl@linux.com, akpm@linux-foundation.org, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, vbabka@suse.cz, urezki@gmail.com, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E68831C0005 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: zescejfpj48q439aoy561q5dfimzynr9 X-HE-Tag: 1675347132-443664 X-HE-Meta: U2FsdGVkX198TDy4pzCpdvG9itpfRTZlgLpiW432FFdtfyGTFAUOwf9cBUGQaKDWLttxZqDzUg2WE9VNQULD8qE8lBw7/WHncLe+gdWtOox7sHNUW5zqybXf4HbtvLtuwM08jIACxAqXEHs28JxM1mWuukcd9n1lnv4P6DQS+M5+1tp1Tx2FDSNmEBpW+iejr2Up6LKZXve0sp1n+OouK07TkD34v4bLW3MhYn3LX5hC2EceaA6LUSAt/Hr8qFd0VPCcQzpyDAafc9avRiCpnM3m1sGMHSh/YqoWrdrHWJqp3ViTKgEPChXLVrfUats5OgXoy70g+U6sAHfRZSX6IWMxQDOKL0lIuwZZJHDxOzJkDitg242WVkjtD7pJkl3ru3CvwV9tZm+eGtvtkefan45mMbFEZWdzyFdvpiyx58aZvA9i8GiEVo1vM82Hsgy/KlHSGKBCJ/uSRFb84+gHQ1puBzSrWZKXUun1BqfAKeUwiIKtPd5WuDVB26k+x487bbCO2NHXbTiLXgPt4NOdsl7gtaZqL0rFOngJxPT6Vnfst1Mwf1qPfGyxKEMxyR7a+U43gGMMhmsgxDngrOw63wytG/Z/EvC1CI0+1BaAR0OFMCBsgTCsdteIOHn/jYgi5GCnNy0uaNFtGDYdi4c0lqzL76Prm4xUZdkuspdW8BIyhW0RDIfwPW0sGE2AmDxFxCQnt6F+PT9clClEiEjMfYEpFeZ0z7jyZRm69h0Wq57exRgkzDDgAsEuHWRBMxDiDuxd/SYbgfFQBrtrXQdeYbb5sR3tpxw/m9/1FXcZxjBvQxtZkNkzNHncU7bPEstNVK+EhE7rzvieBrLPvvp0btq4qf8NqQ8xZRJtECqE0R2BSzf9Iw1AqJzw9i9IbxOslPFUHluSB2Dg96viTLPG0RjlWQ5E/V0+25/kSGAem/vlAcyY/MKscndq+QgDyTn61f2VL9sHiEXq4xux1nh kE8O9Ory 9NtRVdL0c6gvSm689OaStkXpefpYe741P/zVkaafaWibJvcG8L34t96tCQMqaLVszSOMmX1U9sWa8hCqtuW4ezZcjnXvFbcGjjDWvbbEs25mckPulXLb31IOOIKLZAoWt8ZWnj7ywUCK8dkrCrc5UU2xgoE/7kCYzxnpTRsYv+Emn3QKDImD7dW6EZbObAepaYPdWGSZvHuNKEQRsOk/1QbUk+M6DopC70aKbTrmtaGbhpKDCxfFiM64Flf7TsA1MdCzswFgzOqAjjO83d00t1QeIhaK8ZgqwoJ7kmyNZzhM0Ql8P+MG72EWWUX9lyNsD2gIHZ15AZeXHNxKBvouYpw7k0mHyv2aVjuvPqUA//nSlTuTmJmDzwnjJjl/U2eASSAFTdJ5Au+h7uiyovZhrJekXr+1vZfQZfcZ/4BfZ+Yu0mBLOvRmIbmoC78KButtH3UHX37LfSdYPpO1nQdUuEPMnsrnAi8VwWRuJJRUXmm3mWf4llFm2c7hhshtMrN4GrVh3X5SkwAFPjayQhCJ9Muys+buWVHipG5q7LrYcjFwm0V31UUfsakdpg6YAyFEefpEGFvXsT9tEOe64o1JTfGCLTinzYwO3UpXFpj4o1xVNEKxLLz9e6W3RkjWabNkGjbVGeApPzGHOeqU2+JG6BFK1jMSBnC+xFzGleBsCq87QZ3x0D6RZ4WlLyubo+9BIuRNwDMQ0WmNc4WDyXD8d8aCJuqiZpDg9fZ81 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 2, 2023 at 12:54 PM kernel test robot wrote: > > Hi Yafang, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Yafang-Shao/mm-percpu-fix-incorrect-size-in-pcpu_obj_full_size/20230202-094352 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > patch link: https://lore.kernel.org/r/20230202014158.19616-7-laoar.shao%40gmail.com > patch subject: [PATCH bpf-next 6/7] bpf: introduce bpf_mem_alloc_size() > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230202/202302021258.By6JZK71-lkp@intel.com/config) > compiler: m68k-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/996f3e2ac4dca054396d0f37ffe8ddb97fc4212f > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Yafang-Shao/mm-percpu-fix-incorrect-size-in-pcpu_obj_full_size/20230202-094352 > git checkout 996f3e2ac4dca054396d0f37ffe8ddb97fc4212f > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash kernel/bpf/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > >> kernel/bpf/memalloc.c:227:15: warning: no previous prototype for 'bpf_mem_cache_size' [-Wmissing-prototypes] > 227 | unsigned long bpf_mem_cache_size(struct bpf_mem_cache *c, void *obj) > | ^~~~~~~~~~~~~~~~~~ Should be defined with 'static'. Thanks for the report. Will update it in the next version. > > > vim +/bpf_mem_cache_size +227 kernel/bpf/memalloc.c > > 226 > > 227 unsigned long bpf_mem_cache_size(struct bpf_mem_cache *c, void *obj) > 228 { > 229 unsigned long size; > 230 > 231 if (!obj) > 232 return 0; > 233 > 234 if (c->percpu_size) { > 235 size = percpu_size(((void **)obj)[1]); > 236 size += ksize(obj); > 237 return size; > 238 } > 239 > 240 return ksize(obj); > 241 } > 242 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests -- Regards Yafang