From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B0C4C433E1 for ; Tue, 16 Jun 2020 09:40:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 58C4F2074D for ; Tue, 16 Jun 2020 09:40:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JISzqb5W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58C4F2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C5A176B0022; Tue, 16 Jun 2020 05:40:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE42B6B007D; Tue, 16 Jun 2020 05:40:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAA9E6B007E; Tue, 16 Jun 2020 05:40:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 905306B0022 for ; Tue, 16 Jun 2020 05:40:12 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E4351AF6E for ; Tue, 16 Jun 2020 09:40:11 +0000 (UTC) X-FDA: 76934579022.25.boot96_3b182fb26dfe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id ADDCA1804E3A0 for ; Tue, 16 Jun 2020 09:40:11 +0000 (UTC) X-HE-Tag: boot96_3b182fb26dfe X-Filterd-Recvd-Size: 8060 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 16 Jun 2020 09:40:11 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id c75so18143834ila.8 for ; Tue, 16 Jun 2020 02:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pGe/Er9Jr0dwQjVHm8wrk0xJ2zUDxd0eHdfdATrGabM=; b=JISzqb5WUuaHpslnpQGA69Ht1wtm24SXXEG/Ko55uNC2/rGts8slc13Rj6V/ENrHTC OORKZIbiKBwCZvckFdVYJ56sRIc0q3Yni8HM0EsX67D0uAvQdEcxmRhjVmGLdu1NoMTn QAAoTa8U27C6zIJMjRyFq4Ydf1Tpljne0ggnp8IgutwDFUuHiD07Fa4NAyEp17rsozI4 XDGSV4Us1k/Bf02MT7RCW+pwgqFbT65Ft8eXSsXqf3GR1c614NYKLEHp5pN5Clf4RN1g KQPjUhNDRlEu+ExH8mqdP3V/yF28u5jIKmRIbq3Z/3zGksgG+2xpBGE6zLSsmHoMJNJj GEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pGe/Er9Jr0dwQjVHm8wrk0xJ2zUDxd0eHdfdATrGabM=; b=ANhEwGETIR2m50WKlN3g5Dfs//m0AK6FzUBOsc5V/iii3mhqtVO3gylSDmcC7MvL8Z Qz5mMTlVmuE5+ATrjC3WO39HmX+0lLyZ+MucMCiuvrs51PwJX8Vezlss3tjykl4Hj1xo kVhGOhaKuhm2zf1RmRm1agDORc6Jeym0F4C+Fxy6/2AdWd8wUyi2btQW4BdhbJujDENb YHgxl87wbt1K3F7Kb56cvCOYKmi2IpGsql6BhkHEooNseb7rhYxZxB54DU1IgB8kYqpw QNihR1VBCiqTlCpCm6IhoXryNOI3Yq2TJMKr8E2pe/xQKL0f3KJ/rGMYGrGl86X6hJPl FZcA== X-Gm-Message-State: AOAM533hLjYZIjHVPMpavVGaJa5c59Lem7AIYgyPTuuprSI2GeEuCrpY AZHJuf2udpp4nA3phF7mqp6/feOfdpfu+/laIm0= X-Google-Smtp-Source: ABdhPJyVDkDwxznobiB46ixzMp1V5r88m+gVTCdIlEi5zYtRD1GqD593akdkWKsh1iCTpEKXRAvIYuDSAtxdG4pab98= X-Received: by 2002:a92:4899:: with SMTP id j25mr2349071ilg.168.1592300410577; Tue, 16 Jun 2020 02:40:10 -0700 (PDT) MIME-Version: 1.0 References: <1592222181-9832-1-git-send-email-laoar.shao@gmail.com> <20200616081628.GC9499@dhcp22.suse.cz> <20200616092727.GD9499@dhcp22.suse.cz> In-Reply-To: <20200616092727.GD9499@dhcp22.suse.cz> From: Yafang Shao Date: Tue, 16 Jun 2020 17:39:33 +0800 Message-ID: Subject: Re: [PATCH v3] xfs: avoid deadlock when trigger memory reclaim in ->writepages To: Michal Hocko Cc: Christoph Hellwig , Dave Chinner , "Darrick J. Wong" , Andrew Morton , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: ADDCA1804E3A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 16, 2020 at 5:27 PM Michal Hocko wrote: > > On Tue 16-06-20 17:05:25, Yafang Shao wrote: > > On Tue, Jun 16, 2020 at 4:16 PM Michal Hocko wrote: > > > > > > On Mon 15-06-20 07:56:21, Yafang Shao wrote: > > > > Recently there is a XFS deadlock on our server with an old kernel. > > > > This deadlock is caused by allocating memory in xfs_map_blocks() while > > > > doing writeback on behalf of memroy reclaim. Although this deadlock happens > > > > on an old kernel, I think it could happen on the upstream as well. This > > > > issue only happens once and can't be reproduced, so I haven't tried to > > > > reproduce it on upsteam kernel. > > > > > > > > Bellow is the call trace of this deadlock. > > > > [480594.790087] INFO: task redis-server:16212 blocked for more than 120 seconds. > > > > [480594.790087] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > > > > [480594.790088] redis-server D ffffffff8168bd60 0 16212 14347 0x00000004 > > > > [480594.790090] ffff880da128f070 0000000000000082 ffff880f94a2eeb0 ffff880da128ffd8 > > > > [480594.790092] ffff880da128ffd8 ffff880da128ffd8 ffff880f94a2eeb0 ffff88103f9d6c40 > > > > [480594.790094] 0000000000000000 7fffffffffffffff ffff88207ffc0ee8 ffffffff8168bd60 > > > > [480594.790096] Call Trace: > > > > [480594.790101] [] schedule+0x29/0x70 > > > > [480594.790103] [] schedule_timeout+0x239/0x2c0 > > > > [480594.790111] [] io_schedule_timeout+0xae/0x130 > > > > [480594.790114] [] io_schedule+0x18/0x20 > > > > [480594.790116] [] bit_wait_io+0x11/0x50 > > > > [480594.790118] [] __wait_on_bit+0x65/0x90 > > > > [480594.790121] [] wait_on_page_bit+0x81/0xa0 > > > > [480594.790125] [] shrink_page_list+0x6d2/0xaf0 > > > > [480594.790130] [] shrink_inactive_list+0x223/0x710 > > > > [480594.790135] [] shrink_lruvec+0x3b5/0x810 > > > > [480594.790139] [] shrink_zone+0xba/0x1e0 > > > > [480594.790141] [] do_try_to_free_pages+0x100/0x510 > > > > [480594.790143] [] try_to_free_mem_cgroup_pages+0xdd/0x170 > > > > [480594.790145] [] mem_cgroup_reclaim+0x4e/0x120 > > > > [480594.790147] [] __mem_cgroup_try_charge+0x41c/0x670 > > > > [480594.790153] [] __memcg_kmem_newpage_charge+0xf6/0x180 > > > > [480594.790157] [] __alloc_pages_nodemask+0x22d/0x420 > > > > [480594.790162] [] alloc_pages_current+0xaa/0x170 > > > > [480594.790165] [] new_slab+0x30c/0x320 > > > > [480594.790168] [] ___slab_alloc+0x3ac/0x4f0 > > > > [480594.790204] [] __slab_alloc+0x40/0x5c > > > > [480594.790206] [] kmem_cache_alloc+0x193/0x1e0 > > > > [480594.790233] [] kmem_zone_alloc+0x97/0x130 [xfs] > > > > [480594.790247] [] _xfs_trans_alloc+0x3a/0xa0 [xfs] > > > > [480594.790261] [] xfs_trans_alloc+0x3c/0x50 [xfs] > > > > > > Now with a more explanation from Dave I have got back to the original > > > backtrace. Not sure which kernel version you are using but this path > > > should have passed xfs_trans_reserve which sets PF_MEMALLOC_NOFS and > > > this in turn should have made __alloc_pages_nodemask to use __GFP_NOFS > > > and the memcg reclaim shouldn't ever wait_on_page_writeback (pressumably > > > this is what the io_schedule is coming from). > > > > Hi Michal, > > > > The page is allocated before calling xfs_trans_reserve, so the > > PF_MEMALLOC_NOFS hasn't been set yet. > > See bellow, > > > > xfs_trans_alloc > > kmem_zone_zalloc() <<< GPF_NOFS hasn't been set yet, but it may > > trigger memory reclaim > > xfs_trans_reserve() <<<< GPF_NOFS is set here (for the kernel > > prior to commit 9070733b4efac, it is PF_FSTRANS) > > You are right, I have misread the actual allocation side. 8683edb7755b8 > has added KM_NOFS and 73d30d48749f8 has removed it. I cannot really > judge the correctness here. > The history is complicated, but it doesn't matter. Let's turn back to the upstream kernel now. As I explained in the commit log, xfs_vm_writepages -> iomap_writepages. -> write_cache_pages -> lock_page <<<< This page is locked. -> writepages ( which is iomap_do_writepage) -> xfs_map_blocks -> xfs_convert_blocks -> xfs_bmapi_convert_delalloc -> xfs_trans_alloc -> kmem_zone_zalloc //It should alloc page with GFP_NOFS If GFP_NOFS isn't set in xfs_trans_alloc(), the kmem_zone_zalloc() may trigger the memory reclaim then it may wait on the page locked in write_cache_pages() ... That means the ->writepages should be set with GFP_NOFS to avoid this recursive filesystem reclaim. -- Thanks Yafang