From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258FDEEE27F for ; Fri, 13 Sep 2024 02:20:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 904096B00C5; Thu, 12 Sep 2024 22:20:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B3A06B00C6; Thu, 12 Sep 2024 22:20:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7560C6B00C7; Thu, 12 Sep 2024 22:20:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 516B16B00C5 for ; Thu, 12 Sep 2024 22:20:56 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CC8B2813B4 for ; Fri, 13 Sep 2024 02:20:55 +0000 (UTC) X-FDA: 82558112070.11.D691DD4 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf30.hostedemail.com (Postfix) with ESMTP id 1BFEE8000C for ; Fri, 13 Sep 2024 02:20:53 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KNcDZ3NW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726194048; a=rsa-sha256; cv=none; b=HxVBK3FHFEfKc2xvyMaITms7o0kF82h8yCTj0G8cp1cD2jZsh9CZlYAbt5IrYXRfHS81Iz eK+XuhkcTcp4007CclcyMhKaYHbah42PZId/RXTJaE3UuK+u7XHsiHJ3ydBSMCItVVfTcz 9/IO2tvFBForjxwal2lRCTnF1unMAjk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KNcDZ3NW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726194048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/YuGlKzxhtY5rBL2eIZIp8+LMnunU1KOYKGMKR0vy8Y=; b=qcZJ/Xkt169ovBN7oPGgg+7SEM6TaXydmUQa5UxseW8p/4tJ9yycQxAxw2aO3GPx+MyTfc Cl3AxDlxD70E2Xs2DLG0O8EnKA+L+q+GET70qpRRlF4zTezERq33In2NQolirsJiakae68 nlVywdqi3n4JQoVYNF1732NecVJOU3Y= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6c352bcb569so8673516d6.0 for ; Thu, 12 Sep 2024 19:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726194053; x=1726798853; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/YuGlKzxhtY5rBL2eIZIp8+LMnunU1KOYKGMKR0vy8Y=; b=KNcDZ3NWcrCkr49EdlDu1LbJOHVbztqVNIu03/q2ahrTzNXZ8hviRoEb/nr2ceBnPK jeQ1Pc8BpozvM5/PBEXhc6ilueNIxPP7scjJZJOG1VONsjMTQh9TRqmCyK6+6GKSbNoi +oJKTSNEguUSNOSMOqdBp+xcYLJtlL1gAj6ujDwCHPfGFDdAx+Lb8P3aadeUSxCxFLHo /2XSVhnBpeWzPIVIzDOuV33V1sVi/ka40+cKJ7Rc0R8BqqRiMBKL+Ms3M/9aS075xETT xTbflgiCWXlAWzc/HBxchRY1Pz5cz2GwC6Hi9yRm+IOPC0hgNW4/wTImPJK6LSJJJ/TO q/Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726194053; x=1726798853; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/YuGlKzxhtY5rBL2eIZIp8+LMnunU1KOYKGMKR0vy8Y=; b=HdgnPQs0hsEFBKAx7zx73epMxGNJHP6EyBa5b13eWG9Y9jjCis/3zRLx2xKjIt1Dai 4eRyN0KbQ1nc5/LF03zJnbIb9er3TNCPsA6mcyyqcUBYpnGIUL9w+a98VJWe9ORAr5Lm drgMdyei5MpkudOqffzbZayubWhlo0Cz5G0VaVGPh1ZxM/Yu1X7BCwrz+yx0QGaGu1VN RqtJpqyIR1TE1o+XWzivs+pX16h4b3Z6L//D63AmwTXveRmcdmEvhTKOdhZ0gxku5JqH NCMcNk6Lo988aU0gbaRBzuQI9vks7eltEZMlcIEkDmGvWWEWB9XRVg6raptySmY/BWOe 7V+A== X-Forwarded-Encrypted: i=1; AJvYcCWWahH8RkeQex1KOVFMktl/QJ1E4ivOe0QLisHgHvyJTXdpXXPKgcCEblpORidpqjLJdDnujVgO/Q==@kvack.org X-Gm-Message-State: AOJu0YyU+YqUQWUav/X0YHz+znIVZ/LzQn3ghHnwujU+zawgc8J2urTR uN2CLFKjxjqT6aDyDa+RqsgQmd0Fu4RF0Nw5R6NDaYRI4iqp29jpUxVgVIlEnj+6w3Hbi2L5WIE /4NrU6SpYb22aP13PUmWywyEP0sw= X-Google-Smtp-Source: AGHT+IEALOyw7njQRSkttfTBxiECARy2DIo72UCyaA7S1zsv/zTsiW7a3znz7/TXgkua05e1Jrm3oxglJjkOnal6MfM= X-Received: by 2002:a05:6214:4886:b0:6c5:30c9:c055 with SMTP id 6a1803df08f44-6c57355ac2dmr79834256d6.14.1726194053000; Thu, 12 Sep 2024 19:20:53 -0700 (PDT) MIME-Version: 1.0 References: <20240828030321.20688-1-laoar.shao@gmail.com> <20240828030321.20688-5-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Fri, 13 Sep 2024 10:20:16 +0800 Message-ID: Subject: Re: [PATCH v8 4/8] bpftool: Ensure task comm is always NUL-terminated To: Justin Stitt Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, alx@kernel.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Quentin Monnet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: nci5ad66p8gpbphn8xhra5op857773y6 X-Rspamd-Queue-Id: 1BFEE8000C X-Rspamd-Server: rspam02 X-HE-Tag: 1726194053-107777 X-HE-Meta: U2FsdGVkX1/tXSJnC3B0IMALC8s7i16XAXa3VXHYxa6ZDCz1hUB2CMOskq4WU8ntpykOAfKb30ApEfcjU+/72jwvadDftLhsBqaKjchTM7mNwjyO3DW9jnCe8eKNvz3UEXN/tb5QeIRNpvUCmrJ6GZYVsUCU3z22MpiE1/GSzgbak1IlmJz6ofFoHjMAccGDXdORbb37dT3/WjLAMAVR4u/LoGg7Zr2F4hLuh0uhDKvr54+U/v7Bw6V9RdkNlp+G3MQXmCoelOb1wIox3uSpsTBWtbom483tS2Upg5sziQLwqPlz/RJ7OfhgWALaFTGcm/ntrdWOGAGJPu7DlCbGuIeVHhmZARuJ5H3GNauD5UN/52QnK9wngZq1oemFOVylQbzmEgCztwEUr5KjS6oTyudhZKKdj+aX/cpQgLkhubRkmb+ppnWlUh1P/LVZ+cpe6p9pusLrmrHPNoWTfV/U+Mq/DA76867VsWafNKTHDYBfyJdqyJ2gQdCchYXza2My4dwJrXP4aceEr/qUTmDaFdqq1s4DEWGcyyGeNWj0BxT+9PJvN/VpUmpPdioENzdGy75IgaThcuUnrPFcwCcQAAd53fZz7UDpYfoy3dAiE8eZXHXB6k2jdYwGw8WAv+EQkpTZJVsReFvuAFd802OTWR/53IA+Acvi1db2nzuIywMedm+cmMXXKeIafvSJsdFuervDXOwHO4bk25RtS2gbcKfUBWk9agBkWFps/XukmOLQAymvCjVd7qE0Z139EehbtNBzTLGQ71dp/qq9tP88JPocQbZ96Gh+xjv2dMSTjpzJG4ljuBzVOVjTCnG3p95IooNcM6hyaz4Q/aCJdX3mhHzCU9Y3b85FwfH90/7Bg711pWdwfc7c5kEe3KHvM212piRDsWCasaAtNIHZUiABy/08Lu05Snx/vkzApk5Ne1porcKKPKhwNZdoFbaB1A4LzS1/4GuKjzyWVTwMpAZ 7RKJqkMB JEQmWGMKMfbVj80YW2CIGvPRijJ2HxSBT6nHMrSKEtOCeJXdJHVbPGAs0IvNW1M+D8Z0qIuzb06Jf6i3E74fWvkb0cbnvQXPm1SdlMb85C5szTbLhexxHOdvc62Z4K4nNY0vqvn02HwJsWnYYZdxbSMjVKVrbB6upER6pBPHDH3VHUybFsuef3IZjL9Z/NPIiBe+OBsl+VYKI6o2IUGMYIN2xxQndPwd0lwMFtoZ+05Z6EvGZNE2oFrb7Lj2ZB4uTG78aX0ueFiR5gxNtlEtcyoueYPuSVbSWP/MnK/zYyvt0xo8ZXGHtl+pHVRgBg8uaUNiSpVrakqLGR5hmDybUah+wRxUmjXFehrNvLkKVJo9Q6tUfOQyhFrnRLCIMEHxcASPisjTbF1CksGTTNaYB0fCQAn8YUeUte8rNjSfHWWkM3Gvu+Kt3vAwBHX3kN/IeMZDc0r7Y5phZejGLy+Q6ZLPxqimzkDjwJ0ilOBl/2JYw/ZP+EJHQSU8LUaIZq0cAmf26 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 13, 2024 at 5:14=E2=80=AFAM Justin Stitt wrote: > > Hi, > > On Wed, Aug 28, 2024 at 11:03:17AM GMT, Yafang Shao wrote: > > Let's explicitly ensure the destination string is NUL-terminated. This = way, > > it won't be affected by changes to the source string. > > > > Signed-off-by: Yafang Shao > > Reviewed-by: Quentin Monnet > > --- > > tools/bpf/bpftool/pids.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/bpf/bpftool/pids.c b/tools/bpf/bpftool/pids.c > > index 9b898571b49e..23f488cf1740 100644 > > --- a/tools/bpf/bpftool/pids.c > > +++ b/tools/bpf/bpftool/pids.c > > @@ -54,6 +54,7 @@ static void add_ref(struct hashmap *map, struct pid_i= ter_entry *e) > > ref =3D &refs->refs[refs->ref_cnt]; > > ref->pid =3D e->pid; > > memcpy(ref->comm, e->comm, sizeof(ref->comm)); > > + ref->comm[sizeof(ref->comm) - 1] =3D '\0'; > > ... > > > refs->ref_cnt++; > > > > return; > > @@ -77,6 +78,7 @@ static void add_ref(struct hashmap *map, struct pid_i= ter_entry *e) > > ref =3D &refs->refs[0]; > > ref->pid =3D e->pid; > > memcpy(ref->comm, e->comm, sizeof(ref->comm)); > > + ref->comm[sizeof(ref->comm) - 1] =3D '\0'; > > Excuse my ignorance, do we not have a strscpy() equivalent usable in bpf > code? To my knowledge, there is no direct equivalent of the standard strcpy() function available in bpftool or libbpf code. --=20 Regards Yafang