From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 842E3C636CC for ; Tue, 14 Feb 2023 01:58:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B1E06B0073; Mon, 13 Feb 2023 20:58:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03AC1280002; Mon, 13 Feb 2023 20:58:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1F9D280001; Mon, 13 Feb 2023 20:58:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CC4696B0073 for ; Mon, 13 Feb 2023 20:58:02 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A6C21C03D8 for ; Tue, 14 Feb 2023 01:58:02 +0000 (UTC) X-FDA: 80464236804.28.A9F6C09 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf20.hostedemail.com (Postfix) with ESMTP id D8B411C0004 for ; Tue, 14 Feb 2023 01:58:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kzndCDZ0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676339880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u7mr4pVEPv/iRb2+7qLp6kEdGoJNU2xS8jmL8p89Rdo=; b=pfeFM6DuMxze26lpYoFY1YwSU9CyeueKjO6lMvuBmqMHsN75zGiWEoewT4PYyA9bXhWdWq TMZkThqLVQrOkznyWQcZdkuCluLMGmr+m6zz0K6NB+VP/wSIsElhFmg43X9H91fHlQFrVU eQBvYQmvR6YsX95cLdUwArn8jnzMv4g= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kzndCDZ0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676339880; a=rsa-sha256; cv=none; b=Ryd5UDMXG657gdHEXIOr5Ef19Zvax+z8Lg0iaMzTLzra9NLDDd/OPmqX9NH79Mi6N2sXIL 8TM4YQyZsve/kUUocSi5EAtVwhHLcBgodZfUGQ4zdr2AgWvsoTa8Lr1O0Wg72YKGDwKXSQ i4kcJ4WU9xrndn0uHU/PcSWMkv5TwNc= Received: by mail-qv1-f51.google.com with SMTP id mg2so2388003qvb.9 for ; Mon, 13 Feb 2023 17:58:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1676339880; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=u7mr4pVEPv/iRb2+7qLp6kEdGoJNU2xS8jmL8p89Rdo=; b=kzndCDZ0JEpAml17oggo6OtOknEYXk1chdUzoJnvh+6PANcWNbIEzOj3z/Rnfd+6LU FNEYjuzEhB/oidXZ4aWdDy242COtsz2b5+9r9celqj00qEk4c9uQPN89YiQ36gq92FLM Fh4GKYbJdHN4yDk3qYTAn1ZFXWT1leMnYB4Z2JikqcruHWlaD8fM+2ko5Nse4WScW443 +JLYYh61gOdgTIAd3shVXtpehQome3abc557y1YUCCv15MRLL6KYaNUwCTRXbgSQf0HA YCJjleCIAEdRfWW7qfr+Y3MyZaY/eBRCU+dkf+pmpXiA321IZiSygkVm53CLWmiKUCx/ kT1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676339880; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u7mr4pVEPv/iRb2+7qLp6kEdGoJNU2xS8jmL8p89Rdo=; b=cyHL7teQz7diruIXqErXGaTM8BnCzqWd2Et5jTS6uyRwXs1Fhi+AYkUVn8vuQWolta PjtI8yljNpk2YcV9JRLYd0Io2MT5mRGiLiYIqgH6UVVtwv653E+WDEzIy3wYpRxBmOv4 gMW++CtlhaUYkF034D2vgffaaOJ/EC+BGqiDTwgpZYWOVC2dslDqoe4UXdZ71vO3qyvV tGyt0xu6lZljjLRn5XvQuTDsf+8JVW0b6S3OSd4VEfsn+xQ6w5TBFlBuCe72pBxxwQJb VjuDoJie2jJ1rBpHNnISLlRLTAGupaQR1ZZR02j//TPZRq1Jg8ZmoljiN5l8t0MfDEiX BNwA== X-Gm-Message-State: AO0yUKWxW5+5vn+MAl8wRF2GpzJxiIN59Gkx5Lwjoqor5qTqiX5ci4uN 1DEsQNC7rAdBEnJo+ZCgNGdNoEgTpYmFnn6xbk8= X-Google-Smtp-Source: AK7set8zbOOvjPNykp1iZFnkAw9NrmNQQ1YErj5KrV84n5s8ZntTpWrpqp5XZgayPqN6A1ufSc8Jxl6nfIOg/ob66/I= X-Received: by 2002:a0c:df8e:0:b0:53c:a723:f1b8 with SMTP id w14-20020a0cdf8e000000b0053ca723f1b8mr75947qvl.20.1676339880049; Mon, 13 Feb 2023 17:58:00 -0800 (PST) MIME-Version: 1.0 References: <20230210154947.4460-1-laoar.shao@gmail.com> <20230210140508.cfafb571dd44cf4fe776750b@linux-foundation.org> <20230213105049.a5354a4e20fdc4cdbec55b05@linux-foundation.org> In-Reply-To: <20230213105049.a5354a4e20fdc4cdbec55b05@linux-foundation.org> From: Yafang Shao Date: Tue, 14 Feb 2023 09:57:23 +0800 Message-ID: Subject: Re: [PATCH -mm] mm: percpu: fix incorrect size in pcpu_obj_full_size() To: Andrew Morton Cc: linux-mm@kvack.org, Dennis Zhou , Tejun Heo , Christoph Lameter , Roman Gushchin , Vasily Averin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D8B411C0004 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: chejji9gassaas3fx8zr15koiek4ezyr X-HE-Tag: 1676339880-927764 X-HE-Meta: U2FsdGVkX186GThk2wAw8de3xfUllpK/3aODxYRdNk5I0oe4eS/HO7AijRDqJDdG5MPUEptGvhhpMKk+HsQGfht/lTAVAHE6E41VAoSx5G7tGF2iXFWeMxHmX99tSNcgug8Cd+sUC6kgxQcdB5xrlWeFcBPKA5m4zooY+jKnUq/zMnfFu2GXDd5+peTeaOSkSEmjPVV1JVOKgD1CjHOHI2vsS4VFQFvo1VDvKCKpHgq/WKTHMfJrzx1q5CdL4/dtHqJZaRCkpdHgJhSDqbYsNWQBEGCpysdVDy0DUZcbaD+1YZ1PdiJtJNp5szPbehAvPblydVnz+PQHNlMWAKz5R7xXMlduLK2s52n4C+ZD7QPxiUgpXIumrDiH1YGxhYsgqB2qdudRzfgg5qIkqOgxzjFs8XSZCMp1Mcvsp4In9zZN2pO7We1nUZ3dGhUNhGmprOP9Lri7btsQcoHeHJbApgxwFhV3UJfes1JBdDz2S2yjI8y9f5+cICeb1EVYX3JW+/mi9odicTh5/QIfHO+d7vW1p2tdrkj9DGP0Zi4TD1tqEOEXk+xNWfqER/26X3j5TIcucVSMYwiMBpML9WU0StL3E2mcIv0nOuYJdoFpVSxi2PvaHq3m3TdMXlQ5WIYDIOgO6JYac4po7tpiFNbPjwlmfVMDQhb/2zQqWVuO75VeUnOs0xkQAdHbvLknRJs8AwLtD1Q+S8wr7IhMtnq7xq1dnCvcPpvIyjUBWI1B4tVV7aSCV6qlCire1tmbLBAUKMc4BRBX5SXYbgpaeE6RejZXxtu4bTKWg5uBbik5umEiM5vCBbI9W9e5KmuWbAOvcP3BLRW4NGEPjTY0NfJnKo+UYq+1PJv08tdOyS+L+L4F6kcMctB9i0I/F6quRnFKR11H9U6D9njOES8IV7JAESyZCbk5r4X6iBVt5YIl3z33IfH6dGh72UioUgTXpmYx1jj9KIVv4gpdPhSypiE nqJk/pM2 LWRgTV2Xt41NI2aig4dguTvTcTUPBZ5K1dzIsRkOXNFdd/BmMt9HuDFmzr/Ahrd5Yd1QjuaXvayZMWzSs4W2iEJSUG1yXymR1S2LF+KN05jfjxoyl0CqsbjREwt8Cg8FciGpMLqYwTry0PaeOegKbxril0hyU0HQoZYYN85pVe+97bPyX/3XSR08VHZ+jEJx+akMU31Yz81lKVPZOij3y8tz/xHbqI3lXf6TJ/IVoczC9ZxGI+dF1VpKYT2R1zYJq9g6wmtFskttftvVWnDx7ZqUowV8XG6zshOixM23dfzrncsglls7c/08fqV9ZGtRZTC5/+EaO0WHYTE3MxymuyVUhhUmFTMa7JoYxMQwAhesBukoqlR+mTykMfynL/vUnUq9PGazKAg6GQ5Bi9ZRZP1IGS7nWuw46xc5FYTbfMwLxn3fo5GiacSsxh0s1LrYVZwEyXzlvmXPmLeeCwKTcg0WcS4AMM/FyRhm4+a7slh+1FrpeNR53GXLJvewUoKpGHPS4BCc8/ffC5Cu6J5QynRmELg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 14, 2023 at 2:50 AM Andrew Morton wrote: > > On Sun, 12 Feb 2023 22:05:42 +0800 Yafang Shao wrote: > > > On Sat, Feb 11, 2023 at 6:05 AM Andrew Morton wrote: > > > > > > On Fri, 10 Feb 2023 15:49:47 +0000 Yafang Shao wrote: > > > > > > > The extra space which is used to store the obj_cgroup membership is only > > > > valid when kmemcg is enabled. The kmemcg can be disabled via the kernel > > > > parameter "cgroup.memory=nokmem" at runtime. > > > > ... > > > > > > > > What happens if we do a bunch of allocations with kmemcg enabled, then > > > disable kmemcg then free those allocations, or some such thing. Does > > > the accounting end up wrong? > > > > > > > That won't happen, because we can only enable and disable kmemcg at boot time. > > Ah, I misread the changelog. I suggest that "disabled via the kernel > parameter ... at runtime" be "... at boot time". > Thanks for the suggestion. I will change it. -- Regards Yafang