From: Yafang Shao <laoar.shao@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Dennis Zhou <dennis@kernel.org>,
Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Vasily Averin <vvs@openvz.org>
Subject: Re: [PATCH -mm] mm: percpu: fix incorrect size in pcpu_obj_full_size()
Date: Tue, 14 Feb 2023 09:57:23 +0800 [thread overview]
Message-ID: <CALOAHbCyn5uBSDWtAqNp_0H8zy-derAy4nQXCZ482nj==46qQw@mail.gmail.com> (raw)
In-Reply-To: <20230213105049.a5354a4e20fdc4cdbec55b05@linux-foundation.org>
On Tue, Feb 14, 2023 at 2:50 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Sun, 12 Feb 2023 22:05:42 +0800 Yafang Shao <laoar.shao@gmail.com> wrote:
>
> > On Sat, Feb 11, 2023 at 6:05 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> > >
> > > On Fri, 10 Feb 2023 15:49:47 +0000 Yafang Shao <laoar.shao@gmail.com> wrote:
> > >
> > > > The extra space which is used to store the obj_cgroup membership is only
> > > > valid when kmemcg is enabled. The kmemcg can be disabled via the kernel
> > > > parameter "cgroup.memory=nokmem" at runtime.
> >
> > ...
> >
> > >
> > > What happens if we do a bunch of allocations with kmemcg enabled, then
> > > disable kmemcg then free those allocations, or some such thing. Does
> > > the accounting end up wrong?
> > >
> >
> > That won't happen, because we can only enable and disable kmemcg at boot time.
>
> Ah, I misread the changelog. I suggest that "disabled via the kernel
> parameter ... at runtime" be "... at boot time".
>
Thanks for the suggestion. I will change it.
--
Regards
Yafang
next prev parent reply other threads:[~2023-02-14 1:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:49 Yafang Shao
2023-02-10 22:05 ` Andrew Morton
2023-02-10 22:39 ` Dennis Zhou
2023-02-12 14:12 ` Yafang Shao
2023-02-13 20:12 ` Dennis Zhou
2023-02-12 14:05 ` Yafang Shao
2023-02-13 18:50 ` Andrew Morton
2023-02-14 1:57 ` Yafang Shao [this message]
2023-02-10 22:41 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbCyn5uBSDWtAqNp_0H8zy-derAy4nQXCZ482nj==46qQw@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=linux-mm@kvack.org \
--cc=roman.gushchin@linux.dev \
--cc=tj@kernel.org \
--cc=vvs@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox