From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B507C433EF for ; Sun, 5 Dec 2021 02:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55FF66B007D; Sat, 4 Dec 2021 21:46:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 50EB66B0080; Sat, 4 Dec 2021 21:46:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AFB26B0081; Sat, 4 Dec 2021 21:46:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 28E316B007D for ; Sat, 4 Dec 2021 21:46:42 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D5CAC18339478 for ; Sun, 5 Dec 2021 02:46:31 +0000 (UTC) X-FDA: 78882202182.25.305F071 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf15.hostedemail.com (Postfix) with ESMTP id 70B89D00009D for ; Sun, 5 Dec 2021 02:45:31 +0000 (UTC) Received: by mail-qt1-f172.google.com with SMTP id t11so7502537qtw.3 for ; Sat, 04 Dec 2021 18:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RsJA41B8r6uTnf+Wrmk3w3cuCRFsGJe2oeQmzY1WbO8=; b=dMAXUdZapHoGzFL3EcCl167DdKJlPoUlK/xEH7Q5M++yIdHjKwRUSqbHZNuAOJ4dxS Ab3ejUlOhAvlFWaaYhlO+DR79ztWZ9D2h+p69USGvr08ixZzLyUu6PBmBWGiMW4aR/zI Ru5N/adCCAv8akny+8xgBCv+T2kR0vCg7mSHzwCHO1HU2SdYXt2k9tPA8aqAdlDe2QMN yqXaeb4MWHEtczUMmFIZTffAMDRGMAEyxI05lrY0QBc6UrEbu54b5ukKN+zC5Z66iv8L 0OPxSHAQXKqz9Di6hMONMuK0T8Iz0ZR1+3PxtMEe05zH4K7ujye5omQbF8ULMbC3I+S1 sg2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RsJA41B8r6uTnf+Wrmk3w3cuCRFsGJe2oeQmzY1WbO8=; b=VPWqdtqZ7nvVPYoFVWGINtuFczWUsxBfgjVSLD2UtxQKTEsK5PLt3sVnxb4qi7CmSs 3UThzfC/ku0WAAPHPPpTuf3/D+Td9ZGwyk3zdn45i3ng5qTzmpwPE94GVstRgBJK7IPp AjF5U1Ph0M4vPCNnnEpZhlEZ+mSf3TV/w3Se/CZzpbVPEpY4Y7qIXqAeD3zz9SduaE6q 5yT5olP0aqbOmriL69iEXw/1M1Jq5zBhyXrwMS3X9avKvTd7EDVGSWVnEM9fGRukIw8V esNS5YVkE6kgM0e0o1cZq+XzDZeOCASyBvoqogM6+VyId1m80ledgYbzbupKUZ84DuW9 Q9Bg== X-Gm-Message-State: AOAM530xzNGyhW40WECRRtlG21WKVJ1XSwkMTm2R6dLkMz6TKXA68zeN MZCE/WBaH13gFqrdB0xU3s71xymuebSyecuPmys= X-Google-Smtp-Source: ABdhPJydV6WypXFvd9Ut3xKW5BOxUaSHg0tiLKXKlD0Kkgr2/7QYR43Fvjyep00bHReym6MQcAx8yiE8ysa46C1ngAQ= X-Received: by 2002:a05:622a:1744:: with SMTP id l4mr30592707qtk.418.1638672330785; Sat, 04 Dec 2021 18:45:30 -0800 (PST) MIME-Version: 1.0 References: <20211204095256.78042-1-laoar.shao@gmail.com> <20211204095256.78042-6-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Sun, 5 Dec 2021 10:44:54 +0800 Message-ID: Subject: Re: [PATCH -mm 5/5] bpf/progs: replace hard-coded 16 with TASK_COMM_LEN To: Alexei Starovoitov Cc: Andrew Morton , Steven Rostedt , Kees Cook , Petr Mladek , David Hildenbrand , Arnaldo Carvalho de Melo , Andrii Nakryiko , linux-mm , bpf , "linux-perf-use." , Linux-Fsdevel , LKML , Mathieu Desnoyers , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dMAXUdZa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 70B89D00009D X-Stat-Signature: acf3jhiagruuj7dozwfxrw7fxg5ftyhj X-HE-Tag: 1638672331-128493 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 5, 2021 at 12:44 AM Alexei Starovoitov wrote: > > On Sat, Dec 4, 2021 at 1:53 AM Yafang Shao wrote: > > > > static int process_sample(void *ctx, void *data, size_t len) > > { > > - struct sample *s = data; > > + struct sample_ringbuf *s = data; > > This is becoming pointless churn. > Nack. > > > index 145028b52ad8..7b1bb73c3501 100644 > > --- a/tools/testing/selftests/bpf/progs/test_core_reloc_kernel.c > > +++ b/tools/testing/selftests/bpf/progs/test_core_reloc_kernel.c > > @@ -1,8 +1,7 @@ > > // SPDX-License-Identifier: GPL-2.0 > > // Copyright (c) 2019 Facebook > > > > -#include > > -#include > > +#include > > #include > > #include > > #include > > @@ -23,11 +22,11 @@ struct core_reloc_kernel_output { > > int comm_len; > > }; > > > > -struct task_struct { > > +struct task_struct_reloc { > > Churn that is not even compile tested. It is strange that I have successfully compiled it.... Below is the compile log, $ cat make.log | grep test_core_reloc_kernel CLNG-BPF [test_maps] test_core_reloc_kernel.o GEN-SKEL [test_progs] test_core_reloc_kernel.skel.h CLNG-BPF [test_maps] test_core_reloc_kernel.o GEN-SKEL [test_progs-no_alu32] test_core_reloc_kernel.skel.h Also there's no error in the compile log. -- Thanks Yafang