From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3271AC3DA4A for ; Wed, 14 Aug 2024 07:34:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B96BE6B0085; Wed, 14 Aug 2024 03:34:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B46546B0088; Wed, 14 Aug 2024 03:34:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A340A6B0089; Wed, 14 Aug 2024 03:34:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 82BE66B0085 for ; Wed, 14 Aug 2024 03:34:34 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DEC411A0C82 for ; Wed, 14 Aug 2024 07:34:33 +0000 (UTC) X-FDA: 82450038426.28.122BEE8 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf12.hostedemail.com (Postfix) with ESMTP id 1C88040003 for ; Wed, 14 Aug 2024 07:34:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Fdk26zmu; spf=pass (imf12.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723620815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2bjOX4mGEHFmIEz1jEs1hiEAiKrVOpPuuW0ccR1x8HQ=; b=o4crtf2sVWWAlQ/5URAmNkTAbxVY7JEiiikVDtIqNXATEUotl+gn/9UFZTpKvtXHJmP3Ri 6mIiX2P7T+D7tZtc37NanImRhVcv/GQLiKPHUq6UOPLPWWbexojdfTjmU3RksDlwehxsjF zRJmZaOcjJ4cRN8wJpELRU3EWLlm0OA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Fdk26zmu; spf=pass (imf12.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723620815; a=rsa-sha256; cv=none; b=bjvpp0+64TWBvP9F7PDjqSepYdggH5L8CePZLrKMF4rkrDANs7TV0vA+VvabvxruX7pAgn jX17931u4nG9777Sod6FdKkKhvxNgN2HUpetFbE7eCffSeSq9lsXwn4UCviIwqpsgNLnYK S02ZjkPSdicAfmwg12zO0quYdIDnxjU= Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-70c9cda7f1cso449116a34.3 for ; Wed, 14 Aug 2024 00:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723620871; x=1724225671; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2bjOX4mGEHFmIEz1jEs1hiEAiKrVOpPuuW0ccR1x8HQ=; b=Fdk26zmuS7jE00kPEGqhiWpmd+wvBs+yD9GGJG524VNw1CMajE5Q2lA9lMuzqVi2D1 EXiB3agCCyWu155YzK28VrVyBhQLU3ManatftuwGs73/Qfj+UiSAFJa8pWbeKYD9t7+C 4Z+Y6IqF+HRiZpS9PK9VlE2fNnwHAj21tZEGR4PAm7VJ+e6Xpt45ZBFOTf8cZU+I9+w7 bj1ExS/h9sk6fK0InYi50eAs+vmq49tNWzIcz/tPd3M3cBq3/X2pFzJrNpCu8FQIhWFI MtFWIXcwC6NrGiFF5sbAWfq0P5eQtqIHM+xQHHbdwq/MK9abwF/XQlT0pQOmi7yIIID0 vorg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723620871; x=1724225671; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2bjOX4mGEHFmIEz1jEs1hiEAiKrVOpPuuW0ccR1x8HQ=; b=DPv5jRzk9xF1Iw19Gbm/xgGKSKi6hMHPSOpIXg7Mmw6rzBIFGU51vw1BnKJLOYQYyY DxAvJlI05BTXNXfiwyY3bL6OsmgEB0cUvItaivPAsOLs6lDgj3fhyn20kRF13x/RAdW4 XlB7fz1AOqhA/wkjT5P6bJz6QI3/TIP64kUD0HQErjLrWaytbkaa3DJglreTK/Dii0ts DjT0ACnLaUDqFYGEA5ZhzCmoW++UIb1tW7DcT1InFP3363lIUAln8IrPle2HDzJ6mg+/ CE2hWxyWLR02EIgKprAp+kyGsDA6K813QdntjCK41bbXE6O4hHlCQfNvDYizhtNOTYED DSng== X-Forwarded-Encrypted: i=1; AJvYcCVkjN9ikovL0aQe+ZY+Sa978gli2+LmdZoqr2IxJVuK2RuCCR7aCNl2PUnM+ROwIYZJGyAm9GP7yvaD0nZlEQ+yiHw= X-Gm-Message-State: AOJu0YyG+i1RuTKURzI4V5XCfaZupiEqejj1j6C3rb4cYlEykZww1DUM f8a+af4Sq9DWDzb5kQE8SWEuTXXRN5sZWQl+vp6OdnxiYxCPIyomm6STHgKU09zMNZKO9Guqmkm TfLMqlvEgowmjOAbvkZJuM5HuTps= X-Google-Smtp-Source: AGHT+IF6GAJD4WvBYEJSuyjTxL68+NQ9PLVJbHkuFvat0NeTGs2j4IjiCDp0nhPmFPHfkH39iGdjveseroBk+/S0xFk= X-Received: by 2002:a05:6358:d0e:b0:1ac:f7ac:d777 with SMTP id e5c5f4694b2df-1b1aab0baa8mr235217955d.2.1723620870886; Wed, 14 Aug 2024 00:34:30 -0700 (PDT) MIME-Version: 1.0 References: <20240812090525.80299-1-laoar.shao@gmail.com> <20240812090525.80299-2-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Wed, 14 Aug 2024 15:33:54 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore} To: Christoph Hellwig Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Kent Overstreet , Vlastimil Babka , Michal Hocko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: sm6hu7wbcfptix5poq6o66iyjggs6fcf X-Rspam-User: X-Rspamd-Queue-Id: 1C88040003 X-Rspamd-Server: rspam02 X-HE-Tag: 1723620871-273473 X-HE-Meta: U2FsdGVkX186EacT7KT7SQOokWbQaCGc2aXP0juwjHa91Gx20b+lvV9LIwyLluq8L+EJhiJWHX7sdlsBn06yfrDALz8bgD9GS4FKM8kqbjNluIsLGmzbOuo3Bv0oCKorxoKGOk80YK8bVsAUltvuxBPFhKpzBntrqzETkh1vH28P2j1ohHSUHshRrIUMTscQgB53UTF9fHbgytc40QyTIdqqmmkvEU7O2bJLF/jLOq1JBCNX+icd5KgkwGiE1/DzbvztyqKxxN2YGtaAOgLx+66z4Tt4OWYhxRb2LoKm8aNMeA3gO0t0TseMkbNWk1PEXTypyVbAkPyriSsZMolRMhr8wr/NkwouxuAdGd3VZMW5cSrlyAvMOqcCi5534EOaD/huzJVuD9b0dt9qC2yLkNC2x+oxwzI6Mx7tPyc5GFzKuA04yW5moYsF/hNsNgXaRjw1CpjqmRbLX27+zAiKjs/FsuJNn9PwygwDfcHZZYDO7LYh2iqvCs/BW/jDveHWQASBS76JVMyFEfEfoiS0TPux/XWBP2TjIFl9vbZXYrlJiKsrJlY4qMy53irupHQqpesDZn4g5R3ayHwN+pvHlqqDIvP3OSknwl778D3wwJGi2aKcxqQq3b88mgtQPkkHWhpuWnB9BsBePX09FjXTdc+Pew26fZh06/o5lK5tGr7VmFm78NHxukZaYw2yibIjVy1qyrW/BB0805N3nMI9nG3uWbMhXvaQRaRaHa6tkDTgoO5Ug7+yJMR49+KVH48+Xnj8M6jmMYBzIYyPC0nCnjAinIobyDhrdxeXct8DOPHiXv2hMQaLnIHhJQbPrNaS4vgf77SaBerl7f4VxmSjQw8DT06AXDXmyYRG1lKzENIu0dzm6y94O39hFrUFWl0iSQShspfFwaa0UP+al10WUMUxWXlb5YI6ISdIDznXiz8+DzNPON1hacqDoE+/f3jzJYuU0Fwi6DlK+K7R/Sw KI21PlKW v36+PVErDQpzXg2x7bCwjXiR9avKuVpoEwI+fPAIsUkeNCCCiygdO4tYXVDJhvcc9bb7NffK1ROhRR13wAd/xTuOOVQJy6nxhYh/VFhsjtzBdHuH2pblLyk18rtwYbN88pv1lVkpsu09VAh71Th5NQGEEnPON2oOBY+6VdLX0t4EyxF4KZIrTOEyLSW7sN9GJ62J9NEuJ8gbf2eMFjeA89CtqJa5qNCqAWdWaT04zbkIF28SMamblgpdL5ulEjAbA88cUv5BGzE9ydBE4rM91RBDMzmSbG3Rj3Xgv44VGGyER1FDrJBQYe4IlWjVg9hDchinNtlbbSQT4aXkuwjZ4lGTRXs2TZQ/GepNZXINBfZtxf7era1EHaxpxL76L+oX2GdZD9BaeZ7GNoufoeqqvh46+G+ZPqrOpfvvm+f9GkVEkTVdtOFEnvyEdqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.041759, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 1:27=E2=80=AFPM Christoph Hellwig wrote: > > > There are already memalloc_noreclaim_{save,restore} which imply __GFP_M= EMALLOC: > > > > memalloc_noreclaim_save - Marks implicit __GFP_MEMALLOC scope. > > .. and those are horrible misnamed :( What about renaming it to memalloc_memalloc_save ? > > If we can't even keep our APIs consistently name, who is supposed > to understand all this? > --=20 Regards Yafang