linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yafang Shao <laoar.shao@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Huang, Ying" <ying.huang@intel.com>,
	Yang Shi <yang.shi@linux.alibaba.com>,
	 Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.com>,
	mgorman@techsingularity.net,  kirill.shutemov@linux.intel.com,
	Hugh Dickins <hughd@google.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Linux MM <linux-mm@kvack.org>,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: vmscan: correct nr_reclaimed for THP
Date: Sat, 11 May 2019 12:09:57 +0800	[thread overview]
Message-ID: <CALOAHbCs62ynCEeTqAr7wx2TerFmK1ZBp_9r5jh-oP36tGMXDg@mail.gmail.com> (raw)
In-Reply-To: <20190510163612.GA23417@bombadil.infradead.org>

On Sat, May 11, 2019 at 12:36 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Fri, May 10, 2019 at 10:12:40AM +0800, Huang, Ying wrote:
> > > +           nr_reclaimed += (1 << compound_order(page));
> >
> > How about to change this to
> >
> >
> >         nr_reclaimed += hpage_nr_pages(page);
>
> Please don't.  That embeds the knowledge that we can only swap out either
> normal pages or THP sized pages.

Agreed.
compound_order() is more general than hpage_nr_pages().
It seems to me that hpage_nr_pages() is a little  abuse in lots of places.

Thanks
Yafang


  parent reply	other threads:[~2019-05-11  4:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10  0:16 Yang Shi
2019-05-10  0:39 ` Shakeel Butt
2019-05-10  2:12 ` Huang, Ying
2019-05-10  2:25   ` Yang Shi
2019-05-10  3:03     ` Huang, Ying
2019-05-10  4:33       ` William Kucharski
2019-05-10 15:48         ` Yang Shi
2019-05-10 15:41       ` Yang Shi
2019-05-10 16:36   ` Matthew Wilcox
2019-05-10 16:50     ` Yang Shi
2019-05-10 16:52       ` Matthew Wilcox
2019-05-10 16:54         ` Yang Shi
2019-05-10 22:54     ` Ira Weiny
2019-05-10 23:06       ` Matthew Wilcox
2019-05-11  4:09     ` Yafang Shao [this message]
2019-05-11 22:33     ` William Kucharski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALOAHbCs62ynCEeTqAr7wx2TerFmK1ZBp_9r5jh-oP36tGMXDg@mail.gmail.com \
    --to=laoar.shao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=willy@infradead.org \
    --cc=yang.shi@linux.alibaba.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox