From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C011BC369D9 for ; Wed, 30 Apr 2025 14:44:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 902336B00C4; Wed, 30 Apr 2025 10:44:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B4A56B00C5; Wed, 30 Apr 2025 10:44:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72A5F6B00C6; Wed, 30 Apr 2025 10:44:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4D9236B00C4 for ; Wed, 30 Apr 2025 10:44:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4A6F8140123 for ; Wed, 30 Apr 2025 14:44:15 +0000 (UTC) X-FDA: 83390980470.23.8F938F8 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf21.hostedemail.com (Postfix) with ESMTP id 6ADFD1C0010 for ; Wed, 30 Apr 2025 14:44:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OtvbvsBu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746024253; a=rsa-sha256; cv=none; b=BNJKietuFJS8NtKp1fftiuh2k8p5NJKgfBgjk4Lbw2QunQKUZD9YIGUOyephWJvWUXbivF lci9kWUFIUNpCsjIxG2fvIEtfs1ik6bf/cs/KSed4E5cysoV+lg3+B7kJ7XRPrYLx5697q fgSxoEHs4O7lqpDEjnYwfcyKVFVW4Q0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OtvbvsBu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746024253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jfbf3gnL71W5WlXIVx61pFX3nJsTcCfMH9twz8ykwpM=; b=Dd/tJizLeyF49kwp7RqUzUgqoz/9TDrKbDESk37fhK/Nt0kt5dk3sMGv/WeeKLbpAsWN7V mH6N356TaCNTEqyy44HDLm6SiLxFwJD4GyeNYeCQPj36KwBc+WFiae5cN6Dk+lNWA+WDEF jhPMiQWYoFugxiz1BomU8XvDVgz4pH0= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4769aef457bso106251581cf.2 for ; Wed, 30 Apr 2025 07:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746024252; x=1746629052; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Jfbf3gnL71W5WlXIVx61pFX3nJsTcCfMH9twz8ykwpM=; b=OtvbvsBuHNmtDK+OmmquFrTdy4hmDp7v3eZDgMtT82VEiVoqYD+Gz7xZhT8W6mvp+W mZz8uShucHAZmxXsV9qC3L52967yNQVKDt4u5QS7xJtxsPDwauWCi8uWgl9wBY3W4r6H ywWJ1MvRaO3oHLXze+knJ1pEHC85ym5J4H/hBlLMCoNw6kKfipHCkprwrFkvNSt1aMB1 dwHkjDzq0Vyd5SAzODN54XD6bXz+gTOVvCGEwwmAOwzSL/3Fe6HnPgXEiXXOrI5FSOnz VqorqVlNxzw6jydd3PAMxDzIyzX4UUrto6/2ayKB+UxZD8lU6TuAgAVWxKKpMq+T+AjV PFWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746024252; x=1746629052; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jfbf3gnL71W5WlXIVx61pFX3nJsTcCfMH9twz8ykwpM=; b=CCrCudocu9pU4QWV+ibFdotNNuApg6gt9TfXWdc4yZFsYpNBbEnTzDgKYdha6mLbzl vZWTT1NuXCgwwCF2G3W3RFGCGQoR0hOU0+OEKMAyzP9QjLux6Nx+AmrQz7XGB0EfHgQo hNgNLeBey1muxOe4qyUpKWhTa6PBbPYwzQ9zm7SRttlc+nLYjfUqHVNUlJcXqXplYsf7 Dw67qWJQgh96qVGXVXnwwuNQ88jHv1xnjYdGGPqSWX3UEDbf4rTu61JNuuKritmztEE6 7uudL4MB0KYPqxp0ex99PAmkPsx30F93O6ZWMvaHKwMb+K28E8C0c7gyGMrQ4I1+U8zd RyEA== X-Forwarded-Encrypted: i=1; AJvYcCWym7jDb9JXYFzGNXMU6X9WdUO5rRN8NKlJKtsdPhaVgUrxVfdPUelzggz8VY6dAYm2SxYVkWTCtA==@kvack.org X-Gm-Message-State: AOJu0YzCz+ZOn4y7wUHYfPe34l4mDA5X0EGsSpiN5EjA1trqbFZXGLtw 1k5URl0lVsPMCzD4CYocrDRJQwW0ynN4XDPFRnPBN2IkuINhXUiHjWEPWAhoxOMHDEV7ZM4Mbr7 t/DAe+1Ohkz6udN4WibSQlUr6B0E= X-Gm-Gg: ASbGncv8BoAE018VWlTmOlTKzzCBOWhKMtBpAHTlQM4OWG6eYq+S0AQBNiiqk477IdM SQ1oumOlLrivvram1q2/VwxwsnVW91DcJpNjsTpargIMHGrBMzu06bR0mE9orz5iZzAPXQXiNnv aWV26lR4VyWxMGUiCNdWp/UWk= X-Google-Smtp-Source: AGHT+IHMBG+e+8gfs6zmS5oVXtWgORoJUNe+eqgfIm0EY+F7PgAw/2uFHb4W2gTJdcaLfS2aX0CrcIKt/QTa6i1J5HA= X-Received: by 2002:a05:6214:2a4a:b0:6f4:f621:bc with SMTP id 6a1803df08f44-6f4fcf90929mr60632856d6.33.1746024252600; Wed, 30 Apr 2025 07:44:12 -0700 (PDT) MIME-Version: 1.0 References: <20250429024139.34365-1-laoar.shao@gmail.com> <20250429024139.34365-2-laoar.shao@gmail.com> <23D129C3-0E55-4056-A0C7-5713D71FA42B@nvidia.com> In-Reply-To: <23D129C3-0E55-4056-A0C7-5713D71FA42B@nvidia.com> From: Yafang Shao Date: Wed, 30 Apr 2025 22:43:36 +0800 X-Gm-Features: ATxdqUE79DbpT9dtlZVenyBNjlAGP7Ph3zreGWYL6pZcUBaM3XEwD41E5-6xmW0 Message-ID: Subject: Re: [RFC PATCH 1/4] mm: move hugepage_global_{enabled,always}() to internal.h To: Zi Yan Cc: akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6ADFD1C0010 X-Stat-Signature: h3iu831fdb5ktxowm3da1rkho6j7at3z X-Rspam-User: X-HE-Tag: 1746024253-655314 X-HE-Meta: U2FsdGVkX1+I4+i5Wzwrvsw5gO20QwIyRVBdvTeybROifDQ7ULTTVSI/LNZ9exRjxfmTObFlorSp/kuN29rlK3WrMoEO9ZTENEPx7JES9H1+sE8RRN/0I0Pqjq0OuKxp/ZGXtIhk0Q2iFqUiYHQKh/+bhyYtEBtBgC0EqYfzXgG8MDxj8AclLqKYtAEOITZoRSl0Yv9zmwa/fvvvlgFH0kdxVrgdZJ+MyaFFAQtY+g5/YciRMGdRT2cwtnbu8qc9KBYJEmJqq4YtPw1lbAplyU88EFaNX0Ba0Dc+fcc8Cj6NglPMKw/EvkvfD1aX++bRpKs/6BQaX7NbG5P9Yncj/0aqB2qbt/xuhUv43MIef0cv5+tNHtQJvfngOjTBzKF1kJdLVrN5M653cFxvGUDyyeFZGOgdtJ+HdM/jU50y48lhpHlTZsBfOQ/jAhRZawAvoWtuHR8APBdRRwiI6nniHjWYC0fSBSaAS7xu+PxQ6lSoSt3lo2MFsx+AHgxEPsF8w5e3p2FAhRfdQ36t3FewitnYD7eXXBhsfSdRz2lLez2iCaUCBcI+4OmG09SgPcsxlmRFWFp37yI3Yi7NaIsdR6rcjyNYrKlEqew8tNFG33MHzKvL9CGYMK03bzyM5V+CxikXICH4pj5h0gVNsuCjcvnPDYt4l6ikakNDvgVTjbw0f/5iLNWENLef8WdZWAyaq25l+kV6c1rJAp8Rzq2/b3KLJe+taohuQb79g+qS0dTFlwhCT8YjJ6W4wzllix/JSEe1AVcM7V586drDrxKy++rrod0bMPzgIxAzu60Jjz8CM4QZFE2eqQoVEGUJFk97sK6zNofcGtauk6alB1kxGFhHwCPnFxnvRxSyD/2JRYi6dCbrgNyxIIg63fSBgaEQxvhm+za6pqxv2UNIfwwdUdc9rgxHjePPVrFvBy1HyljCGdexYLGWwq9AwFauPcej9+2iL5vOn/O6g0NeRF5 S7lRqFvr KxpWejjO3K4J6BNcLoedh91Dev/dDGYTIi9/8PhnspqvAXBw9OoVSFiLvmmOb60ncpYJs0AVljlVmzRdtz2io/Tv/AyJxLxZjWcixhUD9m901x9D+LYpVUgGJHqiOE79jxFwwkdl3iRPuq7LHeFdqrkvso85eVSIGKv7OYeQAo0g1QKQvzG6Li4ibxhIS/Wbwr5YHVT+5h7R0WakrB5EXla/5WxglHDJPk6MpJw8oBmKkJv//2j0VXVeYmxBfx67JdzufuaZM823r9KgRUu6ejnUfr8iR3qF8usgI5rvS21AiGyZrYTrg7pekE86uQzd9A03rB8c1n+l5nQoPG9nL3zoGPXTyUDSv7QNx3UxIB3x5J996TbhX6DcNy7+p+w/HQ4UPprVWMJOn2+GWGrzwJp53bO09bP8c3J5n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 30, 2025 at 8:11=E2=80=AFPM Zi Yan wrote: > > On 29 Apr 2025, at 22:40, Yafang Shao wrote: > > > On Tue, Apr 29, 2025 at 11:13=E2=80=AFPM Zi Yan wrote: > >> > >> On Mon Apr 28, 2025 at 10:41 PM EDT, Yafang Shao wrote: > >>> The functions hugepage_global_{enabled,always}() are currently only u= sed in > >>> mm/huge_memory.c, so we can move them to mm/internal.h. They will als= o be > >>> exposed for BPF hooking in a future change. > >> > >> Why cannot BPF include huge_mm.h instead? > > > > To maintain better code organization, it would be better to separate > > the BPF-related logic into dedicated files. It will prevent overlap > > with other components and improve long-term maintainability. > > But at the cost of mm code maintainability? It sets a precedent that one > could grow mm/internal.h very large by moving code to it. I do not think > it is the right way to go. I believe the helpers used exclusively by mm/ should be moved to mm/internal.h. If the size of mm/internal.h is a concern, we could consider introducing a separate mm/huge_internal.h. That said, I won=E2=80=99t proceed with moving them to mm/internal.h if you strongly believe it=E2=80=99s not appropriate=E2=80=94though personally, I = don't think avoiding it is the right direction. --=20 Regards Yafang