From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EEFC2BA19 for ; Mon, 6 Apr 2020 14:17:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 836A823B44 for ; Mon, 6 Apr 2020 14:17:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gJcyT/eb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 836A823B44 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1724E8E002E; Mon, 6 Apr 2020 10:17:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 124738E000D; Mon, 6 Apr 2020 10:17:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 038668E002E; Mon, 6 Apr 2020 10:17:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id DD7138E000D for ; Mon, 6 Apr 2020 10:17:33 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9EA9B4DB2 for ; Mon, 6 Apr 2020 14:17:33 +0000 (UTC) X-FDA: 76677633186.23.gun70_5f1408a6a7316 X-HE-Tag: gun70_5f1408a6a7316 X-Filterd-Recvd-Size: 3835 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 14:17:33 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id j69so14765344ila.11 for ; Mon, 06 Apr 2020 07:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S6Z/5wNPIyh5+KuwJ+nWYMjwdRrtYIDNI5a0zIC5R78=; b=gJcyT/ebCHlN06o/6kaF2MmlYCUhwtTAV3sdU4j70N8budRkSQ/RXAga8eKU2Cx9Gm rjt9eFf1rD5pHzJn1+z53Bzp6I375sawJYtZZ3B9YZsq5KR+06RxJRaMP+0z4aSBAbsm XLP7ilsNdqFamTJfe6kupppi+YnT0V6q+LMf6KfI3dPsdtfBQ3ShH6Omwvv4fmyfvT9S W9VRKPh3NP2nQNc3YT6mvHF0SDoXVFlk/rupKYN0hhv4ZPKiM5pgXswIezyloinqDNUF B8olAVM0vdGLzZTafMDD7sgCWYw7hGmtYCCYYAhfLHrQq9Tda81l/hg0urJtLm4Vu8rz M3mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S6Z/5wNPIyh5+KuwJ+nWYMjwdRrtYIDNI5a0zIC5R78=; b=pSdxgE+/LJThqgpS5V3e4dJt0CyMvYqQTZ3gK8VecrOkegX9QMMQYM8QsJPb5W1cHz 9JNRFEv5gGnNCnyGcSE/A2MY80Pv6HRfSRds4iB/zaJ3IoHnaHE2UpU9xzK5aFjOSMQJ Nc7sGZGpm2B6MEfKlS8ywLUVJKCjGk67z9sznWA4f7D+FiOrRxPJC9+ASjPS67Z/Pq9a 0CWn4+Ye59/7du1QJkgGx6Z9uGi1IphpZTOhxyIVlhlY66DgLX0nsjiyN40sI0aWa+U0 T51QqiRnhjbtUXyYdv6DXWEQlAj6saBEy5rN5XeTs/UjmkiqRrrZmWtlfSQkcwQ2Kafj Z20g== X-Gm-Message-State: AGi0Puak4MVytb8dAXmeHU0Gdv6gZatiwZhhpx6KVM8MAW9dH1IRMW7j DkiSd0UqFvoeOE2sTHf72TNHvwfUD1UXLUbQX36Hyid+5Cc2cg== X-Google-Smtp-Source: APiQypJ96L7BsC/mCNAjqPK6tc8CWpyR6A6BLJt4yPyfFZI6unAn9QmlWekFyVhj0tXZ0nb9p50/Z8E6Vgv2VnMffss= X-Received: by 2002:a92:d850:: with SMTP id h16mr21300730ilq.203.1586182652688; Mon, 06 Apr 2020 07:17:32 -0700 (PDT) MIME-Version: 1.0 References: <1586177647-11889-1-git-send-email-laoar.shao@gmail.com> <20200406130533.GZ21484@bombadil.infradead.org> <20200406141153.GB21484@bombadil.infradead.org> In-Reply-To: <20200406141153.GB21484@bombadil.infradead.org> From: Yafang Shao Date: Mon, 6 Apr 2020 22:16:56 +0800 Message-ID: Subject: Re: [PATCH] mm, memcg: fix error return value of mem_cgroup_alloc() To: Matthew Wilcox Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 6, 2020 at 10:11 PM Matthew Wilcox wrote: > > On Mon, Apr 06, 2020 at 10:09:55PM +0800, Yafang Shao wrote: > > What about ida_alloc_range() ? Should we correct it as well ? > > > > > > * Return: The allocated ID, or %-ENOMEM if memory could not be allocated, > > * or %-ENOSPC if there are no free IDs. > > */ > > int ida_alloc_range(struct ida *ida, unsigned int min, unsigned int max, > > gfp_t gfp) > > > > If there're no free IDs, ida_alloc_range() also returns ENOSPC. > > Do you want to check all the callers of ida_.*alloc()? Sorry, I can't your point. I just find the mem_cgroup_css_alloc() will use ida too. mem_cgroup_css_alloc memcg_online_kmem memcg_alloc_cache_id ida_simple_get I think we should keep the behavior consistent here. Thanks Yafang