From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AB07C3ABA5 for ; Wed, 30 Apr 2025 02:41:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFFB86B00BF; Tue, 29 Apr 2025 22:41:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D86556B00C4; Tue, 29 Apr 2025 22:41:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEC7B6B00D5; Tue, 29 Apr 2025 22:41:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 92FBB6B00BF for ; Tue, 29 Apr 2025 22:41:15 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1CABF1A1A25 for ; Wed, 30 Apr 2025 02:41:17 +0000 (UTC) X-FDA: 83389158594.06.C7068C2 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf22.hostedemail.com (Postfix) with ESMTP id 4AB3FC0004 for ; Wed, 30 Apr 2025 02:41:15 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e52eWFaT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745980875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4ZDKouradC0LYtGluHIGMIOi8zOgxaGIq6EF3UiR4PY=; b=HTBkJo4D03fHCuIHuF2qsG0lbBBeumkZf5rY12iJ9V2ubFEtxzEX8Llb/KXd4pxQ4VITOM euEtWIpvFumf34sQr0oO0uGk+LWuRiz3xaTTSGrEIHuFVX3nFSYCTyq15iVHk2o/uWZ4bH HOvqpKYMPHZNlkFXwt0FUYsl0YXOsyE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745980875; a=rsa-sha256; cv=none; b=yb2HcW8WCwvLjQGhKTftgCC8uBFzC/ZnPxGujrKbL3CMHX/XFo63FUyTdvXYiP59FX0yMh UBs5q+wZpwLgtNAGBmvQt74ycjXU4nc+wUk8HZqnKPy+LyFFAFlhIWtYtxWisUvMys2LJ5 fasMCKGSpLZfVFUOJoiZ8o+YGsGyun0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e52eWFaT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-47688ae873fso76656421cf.0 for ; Tue, 29 Apr 2025 19:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745980874; x=1746585674; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4ZDKouradC0LYtGluHIGMIOi8zOgxaGIq6EF3UiR4PY=; b=e52eWFaTWYRRim2U/vSZD8o6mIx+A8C/So/aeyAQ/EB0zHcVSvkQqDHFjYWFO7WvVz ATMSfaNB+0Xw70ioGZIy0s0bDbmVc8JvBFVEIPXeyMHcCa27TpOSra24ttqsv7ixeXcR 9wcs11mDucPnqeUfLJTym1Cd6w+a69qBa5AP+l/lzrWk6WKCJoKZ1lpAZoLdTKBR6mgu gS2e+zD32XUBImTmtXw5N7C2JyxNNcTZFXjy1nnsi9udiiBEL77bUiMPKZBQv1Enrm3q Eule0sCslRXljeWNe+pwdMkhdgsM9/2gPjEUZoCXlsF/0/ZjnPep2fcrevR9kpIaG2Ev SZ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745980874; x=1746585674; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ZDKouradC0LYtGluHIGMIOi8zOgxaGIq6EF3UiR4PY=; b=wCRxif+K6qBWg/k6mhGRWvHNSYVSCjSxgKZmNI/kQri2/zizEyikZNSb139p1DF70T hoU9zqxIb4/hSH1dN+AJ+FmRCYFXoHoPRUXM2kISVos3i7+cWchqa2MOl28uzZu35/kN /XDusTBuBA/GV0+D4qmPIX34F/sIAkBHTLZcizTgoLpkYlVRsgcfbY3H6vIK7H6fNtNM 5qxdos94oYG1nHlKxKpGMDTFdXXMGnRNZu3azHy/zIQOhGlXGus3TRYM3TBuqI6Ty6Z3 tbjjVzCWvaohV80h/THXdFDpPj2ynVNqNAH8ov+QqfPPVHLk5cDLmw+Q5fOIsN0ikL0I /0qQ== X-Forwarded-Encrypted: i=1; AJvYcCWvAwJRtsJpO2QpVt6WYfeXY1sGvYihamDdDHeM+57z23V9WoQRd31oLcp4R6yBy4LcTE23E1x7ZQ==@kvack.org X-Gm-Message-State: AOJu0YzfxuNT4OnEmjOQX6Gi25V3Q19zOaOhJyPdE3SK3jmgJMemUwyU C+ofsrNQOPsHQurNS3hAKJBjqDQM6DdoucoY1TFm3z3X+HNWWUSnyclMCLiu6lGY5MDpRD9gCq/ yVbA9OrV0uP7XFmab9m7pO4a0dPc= X-Gm-Gg: ASbGncuwflkRQtMnCQv0r04in4r5l8YTGPfpVl6/AVNIDl15oEE5+GwpIdOxN5zR8w8 zTstIZQMSa72NP/7DfBpatR+QQIjuQ/sLdehLXY8WNMhnXB49KT2+0IKQwNFssQENU+BYnxu0wq beMiitbp5HenIApbZArXwFXA0= X-Google-Smtp-Source: AGHT+IFR1kuojXQFsOpX+8bNLR71d8z097EAwu5UtFx5f83zXV+iieSPFS+Rb443vU8cxFowPZ/S1QlAw7iX0uI5JIM= X-Received: by 2002:a05:6214:2a49:b0:6e6:61f1:458a with SMTP id 6a1803df08f44-6f4fce68783mr31074286d6.14.1745980874408; Tue, 29 Apr 2025 19:41:14 -0700 (PDT) MIME-Version: 1.0 References: <20250429024139.34365-1-laoar.shao@gmail.com> <20250429024139.34365-2-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Wed, 30 Apr 2025 10:40:38 +0800 X-Gm-Features: ATxdqUF1yw1wIf5mYXnfRMQw6DatmuTyzRPTsWJjtDxso3SFmXlxsOzy5LX4vcs Message-ID: Subject: Re: [RFC PATCH 1/4] mm: move hugepage_global_{enabled,always}() to internal.h To: Zi Yan Cc: akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4AB3FC0004 X-Rspam-User: X-Stat-Signature: 4oxb4cd1xqgxukrzq8o3f8ujckqusd15 X-HE-Tag: 1745980875-185610 X-HE-Meta: U2FsdGVkX19ksBp5a47QNTGYD0s3z1+lDHBOpHbjPjMPRMqIbZVwWtgtwPpJ010BrQK+an38S6xgaq78b2TRxgZ/z703sgW+cI1xuEO+x9tPKm2Z7ouNpLeBIhZxx6v5ad8zcWfIZrB9HAHv68qBfMhRAfLAmjOHBCN++oap8RJf5xJjLQpYcsOQW0FlXnqCgTbVSdm6qctHVg9VlUSar0fomW7Vb6S2ERenlhSopaXV2PJBxwIeg7YYx2xCphLSDUotHLjcHKYq8q96ZgP6Xk+npzwJvXitPhnhp/FnN+5DqJb37kjlSTMVe/GioDfGO5FXbt8bRSE8yzn9oIoL0JPFXR1fqasO5GeHSe0zcWtxRJyzob2mr9hmZ21fiZ1C9kkdNaKoeIyMyspPzDswHzz1oFHYbw3+KZCUXGUK0sDPddGc+RSn9XuqHs+yPM2VXuf0aVWPlTDUSa/caCpNBwBlZYF2nKAiTX8b7V+4IJz2BmqSTmX3PdLQCICCtwpIUniY2nzCgJ7qvda3vRVsLHBsbhLmXH1sYfCvPX/t8s6f/arxaCzSm8ghcccAen3Rj6rl5iDPkTBbH/XaZMeX8Zq//xXu/Cf/zC8LjyWU5jUghdhSTEwnpsUvtZ7M2ONLylD++nYAu4BJsaCq3PWhqMffCfdsGdVfh2K7PfuHwbwxdItv+vVNI86sCZDGQDCjX7Ub0MhRqNk34YZLNMtVA68tThxHgh+gqsdj/8ZdwswDrdyQioyMJZ8QKB2eA4SNo/0Y4zfUCAPGCrKVSOHKgLqTRIZepHstFNJZHJs/Grx+r7Yd5+laalDIo4pMMo1NLs8gNE8GNHcZl17AHjk0igeFX8DYAzb18z22zZs2qv6MnEPq+w5uaQ6ZHs405cxl5J6ek3sIHj4MKaK/mOYUneDYYb4C9A1lPl3VBvC9r4+mfTqwSr6Ri51VnWTYvCWNj/0x75NFtG1wPpSS1zM izKcCF1b vqwmlSjkad1RsPNBs+MxQflXQIh3zLLQccDdIzGm6IAepHjf2l4Gbe7JWjuFDVf3rjWCqKbZ9/lFNm+793Lg6GO//QhiA+WGXaclae45TogfFrZ7h9tVL851i9Q2nUOHKy9f7H5WUJ8/9+q4wwVMAPCWNdyFc0IlueVao/wrelAbmARB+3hQculhEcHxXzDeZsOXXDCyafWmxdvWQSFFLNmZwT7t8E/NqvqjsrASVOz9fiZmiinIPr7YVIKDu1voXSjCN6Ck+xu0hqtdNm/1PxxXx8vbvQrYaIHAv7FO6ZN89dy9ia4ZbDBkcyPy+ZRO9c4tGDT0VZsuDtQHqgs14K+sSxrQBNH7Kpy3vvgCsdaxCKCs6hD2GFVm9mgtF1K/w9WmDE7fyUo1v6/gvpkhdKSayD3vNIkafGbiW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 29, 2025 at 11:13=E2=80=AFPM Zi Yan wrote: > > On Mon Apr 28, 2025 at 10:41 PM EDT, Yafang Shao wrote: > > The functions hugepage_global_{enabled,always}() are currently only use= d in > > mm/huge_memory.c, so we can move them to mm/internal.h. They will also = be > > exposed for BPF hooking in a future change. > > Why cannot BPF include huge_mm.h instead? To maintain better code organization, it would be better to separate the BPF-related logic into dedicated files. It will prevent overlap with other components and improve long-term maintainability. --=20 Regards Yafang