From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6499C433F5 for ; Tue, 30 Nov 2021 03:04:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49D786B0072; Mon, 29 Nov 2021 22:04:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44CCA6B0073; Mon, 29 Nov 2021 22:04:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ED646B0074; Mon, 29 Nov 2021 22:04:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id 1BDB56B0072 for ; Mon, 29 Nov 2021 22:04:36 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CAA46181327D4 for ; Tue, 30 Nov 2021 03:04:25 +0000 (UTC) X-FDA: 78864103332.26.D9318C9 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf19.hostedemail.com (Postfix) with ESMTP id 9CB06B0000A7 for ; Tue, 30 Nov 2021 03:04:20 +0000 (UTC) Received: by mail-qv1-f51.google.com with SMTP id s9so16552541qvk.12 for ; Mon, 29 Nov 2021 19:04:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qn3rCiMydHKwJRSqvEKBqOJQ42ze7JPZml2l4kAkwYE=; b=UWpY48Db8SSSvrI1MpFmmka3FNt2E40Ilz07diUL+rlM7Ybkp3oZER0vU6RA8FBNLB AjNAgOFvOuqN8bSUqDNbutYPGM/ubZZF3gbJqlTw8+BFVplkPcMsxAyYKWI2CltHW5SD 01UCvWTIXS3pPbhomp3NFBzawnac/+QAeZEQ1mvQqjXjSRPlUgw2fIILZ18F34j4cp3R LWP98ME54aLX2n4dbxs7gBaohVBXQVo9hRXbuWK/YGs1zp7PnnJZZ8DDo0wtwOVz7tmj 6HEWNE1MWGThUyb7WyNQb/I2txyAFbPnQRXXX3J8Prr8HaltOetdUg1M1wl6HD3hMBWz lovw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qn3rCiMydHKwJRSqvEKBqOJQ42ze7JPZml2l4kAkwYE=; b=19zti75ToOaPNUGjEqzfLigNmm82TCNM04Pj26jQdpSAnvvFDe/0o/ip7vyxMx5VMm HtixOec1LPIRff33JF0gjS4w6ih3VSqf64YZZImK1APH7cgrORsebdUYWC60Dtjpmcsu dy/iwemu3i4oDBl8NhM8ZZrFLnqbUaJvoBMVCDLhHy/l56plM3EEIeSqz3DwLukVmhe7 rvhuzVis0GaAtO68bKJdk3Xq46dvWMkABlglZy06z86qBhvbolqAuYxawcMrF8aeRG5P bg3dN15J8xgjcWQdlGyUlu5oDx5NWV0erepQXmCqtqvdDgy9gTVQ4U0iMQe8Bxi6qF/c lQ5Q== X-Gm-Message-State: AOAM532ZwEDhGXDIASZJnr4HvQ4AO6wa64ab0cA1CZs9v5HCMwOznOiN b71xzxbSQ6MRszP+BKmcgvHdT/r03mwtzO1X8GE= X-Google-Smtp-Source: ABdhPJzye7Mau6MSRuZs3vTVhbPaBitlduhkL5wMdjAF8yiGEWsIUxxfoSh994+EmmAGwTuyk858XFoZnyNCCbpCA2A= X-Received: by 2002:a05:6214:2303:: with SMTP id gc3mr34265426qvb.90.1638241464734; Mon, 29 Nov 2021 19:04:24 -0800 (PST) MIME-Version: 1.0 References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> <20211129123043.5cfd687a@gandalf.local.home> In-Reply-To: <20211129123043.5cfd687a@gandalf.local.home> From: Yafang Shao Date: Tue, 30 Nov 2021 11:03:48 +0800 Message-ID: Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN To: Steven Rostedt Cc: Sven Schnelle , Andrew Morton , netdev , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux MM , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko , David Hildenbrand , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek , Tom Zanussi Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9CB06B0000A7 X-Stat-Signature: uwfzq5qqmcauk34g4czihhzcigj8hm6c Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UWpY48Db; spf=pass (imf19.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1638241460-829388 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 30, 2021 at 1:30 AM Steven Rostedt wrote: > > On Mon, 29 Nov 2021 11:13:31 +0100 > Sven Schnelle wrote: > > > > This breaks the trigger-field-variable-support.tc from the ftrace test > > suite at least on s390: > > > > echo 'hist:keys=next_comm:wakeup_lat=common_timestamp.usecs-$ts0:onmatch(sched.sched_waking).wakeup_latency($wakeup_lat,next_pid,sched.sched_waking.prio,next_comm) if next_comm=="ping"' > > linux/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-field-variable-support.tc: line 15: echo: write error: Invalid argument > > > > I added a debugging line into check_synth_field(): > > > > [ 44.091037] field->size 16, hist_field->size 16, field->is_signed 1, hist_field->is_signed 0 > > > > Note the difference in the signed field. > > That should not break on strings. > > Does this fix it (if you keep the patch)? > > -- Steve > > diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c > index 9555b8e1d1e3..319f9c8ca7e7 100644 > --- a/kernel/trace/trace_events_hist.c > +++ b/kernel/trace/trace_events_hist.c > @@ -3757,7 +3757,7 @@ static int check_synth_field(struct synth_event *event, > > if (strcmp(field->type, hist_field->type) != 0) { > if (field->size != hist_field->size || > - field->is_signed != hist_field->is_signed) > + (!field->is_string && field->is_signed != hist_field->is_signed)) > return -EINVAL; > } > Many thanks for the quick fix! It seems this fix should be ahead of patch #7. I will send v3 which contains your fix. -- Thanks Yafang