From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD340EEE27A for ; Fri, 13 Sep 2024 02:23:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2764F8D0003; Thu, 12 Sep 2024 22:23:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 227BC8D0006; Thu, 12 Sep 2024 22:23:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09FE08D0003; Thu, 12 Sep 2024 22:23:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DC2946B0092 for ; Thu, 12 Sep 2024 22:23:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 92CC3A1559 for ; Fri, 13 Sep 2024 02:23:57 +0000 (UTC) X-FDA: 82558119714.21.C8047CB Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf14.hostedemail.com (Postfix) with ESMTP id CDF89100010 for ; Fri, 13 Sep 2024 02:23:54 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vq46KG0R; spf=pass (imf14.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726194129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VPVsVFceR0WWI5d/ojpASw6tDyoPFdiM2e1qY8KWSm4=; b=sYs1149HA25WB0PMsm137f6h9CC8UWS5WdG6b2wQgRYVvyvYollTb3JP4kb/IdloFXJKwL DQNHjGOPsCgQD8sysomT1lVKFifObYM3mcOUn3s4VK6kS6RcHDNDgKfrVmqDuaUn/s643b cwUlthHf6C4+0GvCP3os/959KRiVNM8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726194129; a=rsa-sha256; cv=none; b=yCqVuEaccMoBICp6pNgEvZBVfGWwXCg3qDMdcRUfzAba5qBL/2gfskxdnL3p+mFLAOrdLF CB1c+t9qT+M2Y9RPdJDKjh46MTM3pFXiZvseFBYC49LY4FhkBxQvnijhumFl/P5CsTCBq7 V/dsSeWDI3WNV1rK8coPfMW7aiLhImQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vq46KG0R; spf=pass (imf14.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6c34c02ff1cso9873116d6.2 for ; Thu, 12 Sep 2024 19:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726194234; x=1726799034; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VPVsVFceR0WWI5d/ojpASw6tDyoPFdiM2e1qY8KWSm4=; b=Vq46KG0Rwf7FfRl+6VdatBGO/3Ozs8jQGFGpxvJqrCC/TbZ9FwHXbWCqERX81xTwlH apicdmC0o13s+EhTqnf2NK8GKSECUTZzYNY+8+qQFCZjer5w3GotzaHyA5zGycLsCbPx P07XSJn9/Qb4relZSAXnL23f3YLak8TnCBhxoaw6hOjfcUQRJYlmg4WxuIkwUaWOy5u5 tiKgk02dCcUtkCib71pv1+ndPUiwR57rY9N16ijsRatSujNH8QJMpE7EAHvs0y6Xkx/3 REPhEjRpsW1EDwyxYlOSuSoRUJnJeFuoxHwe5ElmADh569u6cMpkq0Fg0eCbJveaZc3Z 4FaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726194234; x=1726799034; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VPVsVFceR0WWI5d/ojpASw6tDyoPFdiM2e1qY8KWSm4=; b=F2j337K4AwBlrh4PWoh1K1kBxY/vTz1CyOF68eF8wbyMjZQLp21Jfi5iQnIu6sLxgY aDFyqhyplK5ydeJOWymmt7ihWfACtLKdyaeg+nMxsMjv2N3dh0QorhZPidhoY0tkrN3o /62gFXAYC/QLTnQP8tPbhlD4R5PJcyL4jOO7kKglI7hc786Y3yf6ILAkJHgkdtiOkfZU J9wr2bycLG3af1Mk96fI9ID45mFH85ecpuNuMOy88vBkBnww21tnwp0ajY0xpZNtq3sE 50GdEJ29eClxGuFQLvkReVIXkcZ26bPsIN49Z/jNB5Gr6ufoKW+cnneNYnRJAx58X4cT Er8A== X-Forwarded-Encrypted: i=1; AJvYcCV31GCR7jdlIkVXID3ewDWG8lXe61Bg1SjAfOw8+lvYE4FpEwP8dXM82ALvwKQPJQh2srueEqy0Vw==@kvack.org X-Gm-Message-State: AOJu0YwDAiLVO2jcPrQ6nwiu8wRmrcS3+FIHXuW3+cqbuE4JtXPkGZQm Sbc6UCvQnHGhcn6jW+taUKfiXCZMZja/ZuvSIrRUDXqVliQ78/rrXoWMLLJiapb3+tFbnlzkhmR 2Y9Y/XZWYchCsLfOWVIwrx9HQuH4= X-Google-Smtp-Source: AGHT+IE7ATrua7rsyqeOcJseYjVtTnE4hssxQiNmRKzesjoiGraR/SEm091yrLZIkqiIIy/oAkVbRqThLd1lUTb523s= X-Received: by 2002:a05:6214:2e4a:b0:6c5:31d6:7749 with SMTP id 6a1803df08f44-6c5736ea189mr65801846d6.44.1726194233773; Thu, 12 Sep 2024 19:23:53 -0700 (PDT) MIME-Version: 1.0 References: <20240828030321.20688-1-laoar.shao@gmail.com> <20240828030321.20688-9-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Fri, 13 Sep 2024 10:23:17 +0800 Message-ID: Subject: Re: [PATCH v8 8/8] drm: Replace strcpy() with strscpy() To: Justin Stitt Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, alx@kernel.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CDF89100010 X-Stat-Signature: hsf5pu6q7aw8m6a3dk9fotku8khnn1rh X-HE-Tag: 1726194234-735113 X-HE-Meta: U2FsdGVkX19o5ZbsNXHIibbrlXAhZ/Ap9XMMVsmdGid1gN8JINRxE4msXsf9f8igfY2xXaj7AeKHhbxhO2S5ML0v33+nNixTouaI3W9k7SFEbpjCAMVeGrRKHhEx/cD5Fto93T/8uBaz5sjmZ8SRbVCSahdh8jNIdOmBqnIL2Iqi9Ac1iKlPIMX+Sa8fGCzMeYR2biA1djfyMgPr0UJoHkDzyPIdkbvFREAzu5+x+1dErpywAIefVDNrSsK6Hpho64CcBpeIOGDZaH3fqTVj/aEIqP8AbWFOn4mb16LDj1hbErWfv79rqqvX1V0v2F2fPfpFrVgtBbAzLu4u0+Grcz0EHXF3kN22qh7U6cZtB22yZrFL+b7RHCxYgNGRbisRd7VXKQ1vZUJh95TFztI8kYGOhvyJKznH/I4rFbUvyM/KSeKY5hK8V9reGj46UFfI8wKSSSuXEHpXXK4q1zZ1sHQn3hxZzR+2lseo5jGA2Ly6SvUstYMdZzdQZX6VSn8cR07wNavPJTjdYdITcSJtNTt8chYsdXPM2HpSY9/TySleiiE/2PWSJREH7EdcZ+cApfi5YY+AFv/tvHP5f17sSR+Qm3jGBRh1tL065p0YxN024N3ZSvpSsAQ4zoUNvu3t9oQl5zlCtql6KJUmFp5ObFDvdXfjRvhYXUkkmmOb03xgcnv4RMqsh46YzDZzSf5aFYbV3M091JkVei+Fos+5D53hLYvi25rh+gcCuvOVZ3HTqOyrheWpqDtios2J+Ahpx6G3Gy0YPZd9r5iSbYEc+8QDRPI7NtCsOSmLtTMBXTKc/GzBr1WZqLscFoXaDIdISo64fYEgJvPW3LdO8Oa/WeRVWeBA2UFnBRRFvUl0kpbYQii4IdyT40XkpPefhxGM10IJ/8U87sOViBnilDCJj4eyqTsGjUNoVtXrBk8UMDViizDGAKP7U7x3RmCsLM3pF9D4Qo9PNkjQF57jss2 ieuTcmJy R3d+Ntl83kZSytqAaSaq350x+fObbEha42sHaw0DgKUiitKdp4Qu6r9p+HNculzxg9vnoTxx5/nWhB+7BQAsr6nh5kD1ao3Oy+etzAAHdNtZGxIwtDQGipPfDYy8mJpG/Q3SO9D/hd0/6d3gltjYZQc/kCAPn6OaUv2Xax4QrH4DHisI6HaQ48kID9oD4k525Y3ozsvO+ZXupJta8veiYI1knWP2gzFRgyuhVcAl13Wzlz9Ra4m0ZBUmEtGaSASWXmCy0iERyBIs5UnUkbhZ1zG8Ie1PEjDzFfE87pEAjIbFxOsr8KLTDb/TY3FD1mq7OENdHitj2EBrElBrFEsjkBqhIX2FOz4xQirDwnCjTJQT1tVRUHiEOH6JAr4ditDVWtISD23mUduQMleo7xHyP9y9/mebuwqsozDd6jtwWecAORv0CPBBwxfBqUtxbaaGqeWc+GkbkCEwjS6JZBhYFrMSU6QpJpSChcOHiSBjS5o+hHETItbbCpR44glg9P4iRxCVL5FlEeiQnJFBgIf+qw9BTEO0uF9DyyvJbirbudbMaKVlcGFWOXVUaXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 13, 2024 at 5:28=E2=80=AFAM Justin Stitt wrote: > > Hi, > > On Wed, Aug 28, 2024 at 11:03:21AM GMT, Yafang Shao wrote: > > To prevent erros from occurring when the src string is longer than the > > dst string in strcpy(), we should use strscpy() instead. This > > approach also facilitates future extensions to the task comm. > > > > Signed-off-by: Yafang Shao > > Acked-by: Daniel Vetter > > Cc: Maarten Lankhorst > > Cc: Maxime Ripard > > Cc: Thomas Zimmermann > > Cc: David Airlie > > --- > > drivers/gpu/drm/drm_framebuffer.c | 2 +- > > drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_fr= amebuffer.c > > index 888aadb6a4ac..2d6993539474 100644 > > --- a/drivers/gpu/drm/drm_framebuffer.c > > +++ b/drivers/gpu/drm/drm_framebuffer.c > > @@ -868,7 +868,7 @@ int drm_framebuffer_init(struct drm_device *dev, st= ruct drm_framebuffer *fb, > > INIT_LIST_HEAD(&fb->filp_head); > > > > fb->funcs =3D funcs; > > - strcpy(fb->comm, current->comm); > > + strscpy(fb->comm, current->comm); > > > > ret =3D __drm_mode_object_add(dev, &fb->base, DRM_MODE_OBJECT_FB, > > false, drm_framebuffer_free); > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i9= 15/i915_gpu_error.c > > There are other strcpy() in this file but it seems all control paths to > the copies themselves stem from string literals, so it is probably fine > not to also change those ones. But, if a v9 is required and you're > feeling up to it, we should probably replace them too, as per [1]. will change them in the next version. Thanks for your suggestion. > > > > index 96c6cafd5b9e..afa9dae39378 100644 > > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > > @@ -1412,7 +1412,7 @@ static bool record_context(struct i915_gem_contex= t_coredump *e, > > rcu_read_lock(); > > task =3D pid_task(ctx->pid, PIDTYPE_PID); > > if (task) { > > - strcpy(e->comm, task->comm); > > + strscpy(e->comm, task->comm); > > e->pid =3D task->pid; > > } > > rcu_read_unlock(); > > -- > > 2.43.5 > > > > > > > Reviewed-by: Justin Stitt > > [1]: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcp= y > > Thanks > Justin --=20 Regards Yafang