From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47ACEC61DA4 for ; Thu, 2 Feb 2023 15:01:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9F3C6B0071; Thu, 2 Feb 2023 10:01:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4DE96B0073; Thu, 2 Feb 2023 10:01:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A16616B0074; Thu, 2 Feb 2023 10:01:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 83CFC6B0071 for ; Thu, 2 Feb 2023 10:01:43 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 09AAB40608 for ; Thu, 2 Feb 2023 15:01:43 +0000 (UTC) X-FDA: 80422666086.18.66D426C Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 595E72004B for ; Thu, 2 Feb 2023 15:01:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BuaU+P4J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.172 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675350099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oLBuC23YlkzNJJ9bFUSG7GcHohwhM4jWe1P5ffpoHfI=; b=N2e8VwQnYJmXaP50e3TAR9AR3FIN+DY6gM8R+2NRMOo8H28dg3uHWM0Mq65seumwDO0GPs 9W9MeikTlV0M45ndoSKcZCc1P7jwooJiPoIc9soG+lqWmyeR6Kh8uCktBVhWgDzUXrsFIb U9uLw4H80cgfCfeZd6btt40rSB7gMwM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BuaU+P4J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.172 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675350099; a=rsa-sha256; cv=none; b=i35rRzr8vPdnDV5f6lJlbNcoIBJe/vZox5196ByCwgVJ0R33Z2wjCkXLAxlcm7zkl3bjnQ XHImV+olO3RiEoL2O8RCrSpQb8+AgG32OQbfZX9ElHWeV6h6pknRuGli0AYIoZNb4eyTPZ qWyRt41BFqlbwBs9X43yw02tIp8PMqc= Received: by mail-qk1-f172.google.com with SMTP id x2so1073071qkg.7 for ; Thu, 02 Feb 2023 07:01:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oLBuC23YlkzNJJ9bFUSG7GcHohwhM4jWe1P5ffpoHfI=; b=BuaU+P4J6x9okg5ikzm1q16mHqfr0E1jhjk539x1XmDXNqZldJwprxkkVo3RPAlvuX wzApobl8hq1rbY7drkgHklzRhrZqasmN2kcest52sAMqleU9oHAikSSvd06y6HWwnINr Zkxb4F6c1twkA2MfTSgND/Pd8877mn9KK7nc9EzvGyhn+zalgI8ZNz//L1PGMfh8vfhJ L10W4c3BIPXAJrGHgj6KwZdVOcp0hBjfAttnfSwdjmuG76Iwk1F4+XQZf1W1WUaXJMYs 7KSeP9xm9/tT6GKBZ11IVwJDJOxUc4dzWF5ZqOa44c3ACCWDHrQZoHDQp4iu5E0hAOVP qyyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oLBuC23YlkzNJJ9bFUSG7GcHohwhM4jWe1P5ffpoHfI=; b=lIMv+95sGt+ZwUVayfzY99WRgL3Lzup/i1HYO3EwJf31kVYdVzioisSwp+ARH9st7d zxATFqdZf5KVCPVh/30rsRJwg7S3oHjzpz9IT7Rjjcd3HfAHpxFled7tWF6BAn66t4Oz 1ka6kg2VZe1ZMDwHaUhALlup8Mnb0pB/6dXDDIvZXKhwf3Qz2mW9fdtCuhmcgMIS0cHU Z2Qd88OjcQfcto4EZZSdaExR1+B8o0088CFO6B9sCFUnlKeM5WFhzqlyIUz50HEZMwLR Fq+5iPbJoSe+aMWal4s4eNGbBZebOzLNYFDbi7xC9cFQ6nm8GjigOrD4zJthe8/UKDED wHIQ== X-Gm-Message-State: AO0yUKV4qSGEfmnx+vW3hEP7fsk9ACydprj6DlKkYFTdyIAoAALoX6Hv pj7xVOh6Rmgd5FeqgW6FuiHFutGpMWG4fbrEG3g= X-Google-Smtp-Source: AK7set/sRrQmyA1JU85a11weQG62DJ5POsOsuA1qS6Nz5J1tjuvaOKHLgUxrmPYCbBeSOBwtTAnu6iYLQFqLTIJmwpM= X-Received: by 2002:a05:620a:2442:b0:728:8e9e:9887 with SMTP id h2-20020a05620a244200b007288e9e9887mr709515qkn.385.1675350098284; Thu, 02 Feb 2023 07:01:38 -0800 (PST) MIME-Version: 1.0 References: <20230202014158.19616-1-laoar.shao@gmail.com> <20230202014158.19616-3-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Thu, 2 Feb 2023 23:01:02 +0800 Message-ID: Subject: Re: [PATCH bpf-next 2/7] mm: percpu: introduce percpu_size() To: Christoph Lameter Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, tj@kernel.org, dennis@kernel.org, akpm@linux-foundation.org, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, vbabka@suse.cz, urezki@gmail.com, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 595E72004B X-Stat-Signature: dydkok4jdoer8smmjronrzfkbnh43x4d X-HE-Tag: 1675350099-823456 X-HE-Meta: U2FsdGVkX1/BbqRFqw5tvXfzAVPp1h2GNn2Z8eG1kaT1qlLsvfGcuKHOOG/KLRByOSmOv5v63+ouYF+iTQTndvWAoiaiARZEYiMnkwhI/h4WYtyXZc8AcANUApOTZhhjQDAghIhFFjyfetXOvPmx7GjNXCu55B5dMaHb7651Sd+EpbpabiRmh7VvsSBJnupfh9g9T5ByyF9TaVmLCaQDfsoc8EqJlzO9Mgdn9srJpOFA07obn5Xr8Ih7upWqMxeUC7vIkEQggh3CqXBWdC9VlTOriU5EzlWhUi5AigvC9slvxIy6rssGvDCDBJGoslFBJUlZK28RBTGhIgrX7S9J13ZaSceWXsYYMTI+mKlhJvyB+iPMp6ExP0fw25w9UuCX6OtnKUZj9iTdpMYYxDKT9KWh85iDEooA6TJIVS0lI4xv27M1w3kIfWsArdbLUbYMb8ztYoxCCrHwtVwpQjl52fSEMfCg0++fOARSOQEUCJBVR+52lHcN39csfAFKuH7Ssg6C+yOwjkbd1x6e3jCCLXGXDc0dikdAfER1qe4QV5J4Z/0+G52QDNUTiJyvhEY8fE22ru/9s4TqVsoooaM6e6Cou52vO6YC4knA0yuB6krVlR0edz+bWFtv2Uhj7wYw4gNp8Y5MyVHOj+UJUvBFwIUGj+KDdPwHN2KMuVtTzQbl3g0tFWyrGEcWQvNMWO1kbyGdmhx1Ccd4yo7CT13u1epps/ymneAi4cLxfvkcZSfAr4qFWpMrvjF8AAATdFn8CK1/Bq4Af5tjReK6NbdtI1sN6lx87UEu2kU/tKxEfOScRHsn3P4T/c9HKx9iJ1c4Cvg62TjMMR4yqHLRXf88O3RKVBbJFZ42OOMbXgTp5mJL+cpzFMxjtq1g1O5o21hyQt+P7AgtopDUHlZDFOLyWPDEg+kxkWBy35/kbYyP2+46T7meGzSc2+keokmxIH6INzEwF2HwqZCN8ljO3hi 8sYdU0lY 8/hdi0jCpTsc131wfSoz6sudyZk7WMNEzyfMBdmOLyYHZ1UhBgymb4PxIoux2xUP6PeqqlPlXGHndBv1/BFL/pfzI8g4o+Pn+edi4l/r4eIILhm7h7rltMsFdZu/NzxHMSjRIqGbMjSLiAn8FL9h0GvNlV7O1870J+QpppIVMUFiLoLE2po4illsjBkVR6CRAnuXZbIreDozVQLBMcJgEGcycOpYyG+8f2W1vCLjSSHful/mCcY/vZyPm+FDWQJP9i5+EXmjDmImEJordnPoFEcCn/RjKuF8MbFeRhEnuvwAU1sutRJ57UZm9M+0yU/npbclYVtVTtw1u2sE1fm85hA3oT6lYchtdZVQILXTxIJ5vG0yER3Eb9RS732E324wyHSG83yJOCsk8ebW/oZI8RM3g53Nfulx4C0FL0WyFuFQNXYQh4AbUHPirvVSp/RiVDAxR9/P1/0w8Fc4FzDG1xwSgv8o576Lm5eruZdCCoSxHzuSGnKJV0KtSleZ9xdbyEqhsVDF4+DU9c1w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002641, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 2, 2023 at 10:32 PM Christoph Lameter wrote: > > On Thu, 2 Feb 2023, Yafang Shao wrote: > > > + bits = end - bit_off; > > + size = bits * PCPU_MIN_ALLOC_SIZE; > > + > > + return pcpu_obj_full_size(size); > > Dont you have to multiply by the number of online cpus? The per cpu area > are duplicated for those. It is multiplied in pcpu_obj_full_size(). -- Regards Yafang