From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20EEEC369DC for ; Wed, 30 Apr 2025 02:46:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 154866B000A; Tue, 29 Apr 2025 22:46:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DD946B00E1; Tue, 29 Apr 2025 22:46:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4F056B00E2; Tue, 29 Apr 2025 22:46:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BF8296B000A for ; Tue, 29 Apr 2025 22:46:38 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0AAFE81B49 for ; Wed, 30 Apr 2025 02:46:39 +0000 (UTC) X-FDA: 83389172118.12.BF2D092 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf15.hostedemail.com (Postfix) with ESMTP id 2897CA0008 for ; Wed, 30 Apr 2025 02:46:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hWoYF4go; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745981197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oxImKa1eV0FwUaimY/FOsncvzQ7sNgoeD8dE4XJJ6Ls=; b=l2HxQKrcNIYBhq8BsGq7BtKfkA62+Iitz0wJ73jI2QFyPy7B5OgMr3p9ovKqvJ5G07Yse1 nJsC0mNFaMJiD74cpeh5in6NfBr0DVjm6EFy0Hf4Ned/pOd5vwXZ0cs6uuD5kdaZBir1QU UHvPVuxuLY6De/tu0YOwYvfwfIZxFpY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hWoYF4go; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745981197; a=rsa-sha256; cv=none; b=5v7SIOeyapDrAi6eMHB7hfTdyHklQNTLRs8XXPQ/KYMYYg3v+GBOBuctT7eWZFoNbUGP5R EInXuMLIB+tP5ALXplL6jQXUxu1X4CN74ZNKfYOg9QKXbaDYitpiNtM4z03JTwGaJpGIAY m3Ygnw2itKpkgyzOdPxfvd3JT3bjzoU= Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7c5f720c717so58730985a.0 for ; Tue, 29 Apr 2025 19:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745981196; x=1746585996; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oxImKa1eV0FwUaimY/FOsncvzQ7sNgoeD8dE4XJJ6Ls=; b=hWoYF4go5LwAJO2rOEytTuGqFSanL1NFMwRfeMWQYZ9bgDe/bSt/IGJ0tDWuBlqWmK jnOan8Ym9bmtJDjPSVLItvDm9ZVG56l1inIzf7A7LykX+xYPk6s3WYsVnr0lvQJvq/A1 QBFQ0IYYA0B4Ba4MqXzBSAvsfa++A3rSeAgCV4z/FAMhodVV5RYpKip5zzZP2aCVneiv oRI4Wcz+G4CjOuVgP6D5NNorwFSN7fm8RX7yMx5EDv71jLU7ltNk3g9VXN+yfFkcmm3z 2UuEFpkK+947z6PIvI1ZvJw2Sf8bOJLF3tsZ9N/YBKDLarYrcGE+vuuFpI4lILXEC6ld 4tHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745981196; x=1746585996; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oxImKa1eV0FwUaimY/FOsncvzQ7sNgoeD8dE4XJJ6Ls=; b=kRCLZCCwD2Qxq7b9DMU6cE3E+Q/lsi5n//gkGLqkVgO9hKqVMg2acTclyfHybU5X8s cKAykCznzmex84Gmyci9hZOGwEj8hKyFf1tuQrDWGfNqgjYJ4nhd9TQjIiSTrCUX+nwA PXdnurwsXsOSQiCMiJOEzvGaTUndR7kiGBCQEv87QDBf09G1UX2IZ8YkB7GWEY81CPOq mSyrQbtKPttT76ENVfFC9kAcRNVYuDwHifShVNEiIqeoeFm6V2xE6oRpCqxnUeK1HM3q Vw2TSCQUlLQvOW8r9PU94VTPQDkJoNMtO4TH34UMk1S4lWhBrEGi2gwB/0qMMqweAHJ4 f4PQ== X-Forwarded-Encrypted: i=1; AJvYcCUcRVIKnXvEJ9i2TChz1xs4oMzMOQ9PYMnIRZ/2M0UZJe26cKU5vV/rTutM573z+pf0sZqFsgrKlw==@kvack.org X-Gm-Message-State: AOJu0YxJoc4CozWG0d12gluSWUCtjiBQJ2f2uh3WLOH0+9vVe/AdD6Ox XhzYTxNbq3nqmAkj/idH/bhP/b3AKuW+MfmZo5QiqqbNNCYQxiam9cd8JZiKvh3DjwN49LC7Hga a/GhwnJTuSt79Umt3YA2KG4fbXug= X-Gm-Gg: ASbGnctu0IuP7HnDHI0mMoMjHUT67yHHheMuE076gf0hNUeVAoeTLOCTqIYaFRtGKUT juoc7iyQvZcLa3k+I6QToefQ6sIBHiqqOAOi6W0HfbFJMnvjBtWf0CrcZxyokP2HJvcTMTwaG4b QAzeatioj9r0dO/UXoqsIeQio= X-Google-Smtp-Source: AGHT+IECRe6ism+Yvu155vV8xPTVFGCcSdntqCfz4dursrRoKRjtP8bt5l7Trd3BzTh4v+v3iefll0v1JlBcxBrPoXQ= X-Received: by 2002:a05:620a:2890:b0:7c9:574d:a344 with SMTP id af79cd13be357-7cac7b5c591mr165048785a.25.1745981196188; Tue, 29 Apr 2025 19:46:36 -0700 (PDT) MIME-Version: 1.0 References: <20250429024139.34365-1-laoar.shao@gmail.com> <20250429024139.34365-3-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Wed, 30 Apr 2025 10:46:00 +0800 X-Gm-Features: ATxdqUFuNqknhnnMYIWzYTSfrnoAGbPUY5z6qczYS7zqpTahwC1l4k5f4r29_zA Message-ID: Subject: Re: [RFC PATCH 2/4] mm: pass VMA parameter to hugepage_global_{enabled,always}() To: Zi Yan Cc: akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: u1adrh1zyfb9zbhmzhjezbrhmgarjizg X-Rspamd-Queue-Id: 2897CA0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745981197-803019 X-HE-Meta: U2FsdGVkX18Sik6L+qXd7eS9Pjm4I4yP6D014GQBM4rog3RjYmTrAYQvLVGJ0GQLGET9WzveKU3kzV9G5iitgEqUf/rTdZPC/O4qzlVECyy+o+PUb+a7f9D1EM7YJqELbEnHftWJTmR1O+was9VSRiq3gMjOA7QDpoSPl+SZX0WgU9P65YYM/2IQffIAbEiEmosXFJrlP3UQGvmRAOxw470FrX7R7nx4/LFtAgEVJDBBieNyLBQFjYdCcx7uDDlTig40gRDuao6b5Ba5+gwqQ4hqrj9mUxoGnukWC3NrerIYtwu75mrXLhS1ATfhmlV7835lziFV7saRcdyHTFbpWuSvBEAAymc8+tM3F3qr6jZHUGG/jqmCq0eqyIjv2ROT9Kj1y9kIke7IbRf4mTL57GSS1xRh7839Lym1N1O6Sqlj2Z8dljz0hpMlhFP2rIhGbKgY1eLhmZD4kbJ0J1pwz3RdrJnZEeZIGsNwzONRQz5VKgCu1eBxngYIQ8eyLl4peOe8ffnBLpRpqmrYcQKAm37XwNpSDD9C/EImeghQAyqXPh7U+sptzZE/Q2NdEGcAgwk6Il6i3xA1XOPkVQyWciUrk2w7pbsQkixFkpldhl8rdcQugcJGGkelWwyabF8pAVwlHyRDfmQ+v/kf/9gDgCxpbUSqH8Pjy4Fe4+zKBnLYykyGKe3Anz8KPuMpI1fZIaIxcVHcrwCwZwEnqBd93LCLQURIhiBamCGR/CwfGrYiTVy0J295A9qKvZI7z2QxBaO7Ih8y+egQBVJXsYquI/aGNMzj3eecZwX9Bqn7kZ3GWEuzUf/EIwat8yUZ6xiQJb+0t6AHGK5VmB67UdTPv7VPiXiL7u1Prx+D+1JZ+vfXwZdLTGbwTOxycve69uctU9jrU9Lhp2Ju9eEJEmzYLHzTfLoYI67gegKfhPsZ5dlc8Wcu0v+n9qh09F/pA+IGdvnZMX4YpXLt1AE/5nu Z7VQoEnh ZFpyBzMRBsqeGw8SrBhubuhKXe+a7OXPzE4JXkp+UmQVJZuRQGay6NdYB3kHo2A9NzBk/GsyD9OJFxziYD9cAGylZ0WgHo7Dv4craVBAtu2RZqmfCFhqVXd5+1ci6UBZo/IDTM9o7//4+KiFUlPxbbm698Qrzy2p8uHONs8lMFoZLL3Y1Zj1IBvaXynHUrv8q2BG2qoSC2eL70NwcrirZ2cfR61sTgQSXnmkv/PCNmZWOBQlb2rYUrWthwRiNdVZWXRuEHVdWVOyRDYqYqxGSfEiKmcl7dRlmt1seZoQYZXANKuTZ4JFwdcWUCo+b2gNDyIuUvSmwziqLF43LbzBQc4Q88Q6mp7wOChOmRAnv7Ei/6mju/Zkht7FlwRgg4sl2IIZwRsUSJ+V8DKuC2SU4uaU+Of70gXI7LQ6P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 29, 2025 at 11:31=E2=80=AFPM Zi Yan wrote: > > On Mon Apr 28, 2025 at 10:41 PM EDT, Yafang Shao wrote: > > We will use the new @vma parameter to determine whether THP can be used= . > > This is wrong and a completely hack. hugepage_global_*() are sytem-wide > functions, so they do not take VMAs. I modified hugepage_global_*() to enable BPF programs to bypass the global THP settings > Furthermore, the VMAs passed in > are not used at all. I notice that in the later patch VMA is used by BPF > hooks, but that does not justify the addition. > > If you really want to do this, you can add new functions that take VMA > as an input and check hugepage_global_*() to replace some of the if > conditions below. Something like hugepage_vma_{enable,always}. Thanks for your suggestion. I'll proceed with adding the necessary helper functions for this feature. --=20 Regards Yafang