From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 762DBC52D7C for ; Wed, 14 Aug 2024 02:35:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A66536B0082; Tue, 13 Aug 2024 22:35:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A15FB6B0083; Tue, 13 Aug 2024 22:35:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 904756B0085; Tue, 13 Aug 2024 22:35:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 743896B0082 for ; Tue, 13 Aug 2024 22:35:00 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DAE7180BC2 for ; Wed, 14 Aug 2024 02:34:59 +0000 (UTC) X-FDA: 82449283518.21.63A3905 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf15.hostedemail.com (Postfix) with ESMTP id 2020FA000B for ; Wed, 14 Aug 2024 02:34:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ShyebzMF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723602840; a=rsa-sha256; cv=none; b=pfHms438CQGykQ6jVKLhUZTXdZN1pqzlKGxxt8FnJ8GfVTl2xYUC1qvesEoZG5ZDAwXO4H S6Z5f9V+5NzozAcOLz0NcxnlckYu/9mhw/VehRTLoi+d9B1V9D8geBHHzsokwWhSb6IMx4 J6nSNFy7vrnSX743Hrng87JIX+hfDs4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ShyebzMF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723602840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gulgz5rKPIgrCppnzyz5c+/APUjS7s9WOQeVGOEKdkQ=; b=EnNicBSbNeReTUT8kwy8EEJ8iwnCO0XjJ358PwxwzLlI+lYRmuZ7Lb9tinpeQWoY5z40zt dRfdF6fwPTZUBPAfq1k/F99diIjl7BfrmHmEvbjCBk2zuAX4J8x3dJb0AAmdMCMWhPTYaz UQsmnpLnb+SBRF3wK0Lcc31nVccN63I= Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6b79293a858so33136466d6.3 for ; Tue, 13 Aug 2024 19:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723602897; x=1724207697; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gulgz5rKPIgrCppnzyz5c+/APUjS7s9WOQeVGOEKdkQ=; b=ShyebzMFRR5xNzXywdvAuQD9xJGYU4oVD/q5t0cYZYSrmRCSv5USMXQ4gwsukUh4Nx UkqLMavih9oOup2nvVh5qLPtexGXCZcZsQnem0mtwJqn0o6mXH6nPTfiwxx9lC1u+tEG TODJPrtfqpExR6/oTf3vqNeclijDhZ0en3BzYzDjt1mvmmP0PJt7hNYhKahQvopWEHKX DncyPJnExrsv2bmOR1AeAF33kQvzUCMHbrVMJoD0a0gafA3gnQe6UeElpISTd6VRkPcu It8YO2miG8SToA6dQ8dZoQzYQlz6vVE9ZONvNermaoB261+3HxshY6deUXNSEweaF3bH JS2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723602897; x=1724207697; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gulgz5rKPIgrCppnzyz5c+/APUjS7s9WOQeVGOEKdkQ=; b=H5t4ONcQ7R9c2nfIi4rc2h16K4ZrJMIc9CCQwncm5Or9TRGJQ02AnER+6f24i+EciA JAXiWuOvXGItsxXgfEpJrFHTqu5D1ooe/4xDkXl17/uVfjgkbmHZjExQJ6uLLmRrDHl8 v3DhTbJgrVJG655qftu4ZKzIATh4XaGZ9IchRbgIvESGsdmiWZNKyezv0OHR4rHwknAZ fO3RDWx6dI6DJkDAOCd3/edvOITIKsmDXiFtjIC4qiT3MRLq0BqGTADqbzDmag9+26Z9 2waZft+wmkrxen/3OtIsoim7YeqVCJPLhV5rzXLW39yArtblYDNk/xWVUWRDZsbJBWJA 8rNQ== X-Forwarded-Encrypted: i=1; AJvYcCUPFZm5xTdF5O+UlyrUGbB1ATYxKRXZhmo+Thz1YOCdYxD3B2qij+9TDrdfX1X/wnWqiwr/qHyOnt+JAJojr608+04= X-Gm-Message-State: AOJu0Yw2IaYeiL9fJwjnk5OSdLhvEV8HVW/TmWGqAcUr1i88SYYf9GpS LxRt5XIw7JkwFF23wy2mEGy/hMK4J48w3K6GjjKBDLSw+D86hpT/iM8eAJ12zrm+NV78bfbfBgu ZcPYXBfNn/2zCAGuyZCaLB600zvY= X-Google-Smtp-Source: AGHT+IFMSVMbk2rFvvLCxVG+t2Kro+kM02PzB20ab6DAgtzjWvP0nxAeN6FMupoLej6GxB7D7awodMjAvR0yE5dJ7Jc= X-Received: by 2002:a05:6214:4413:b0:6b7:ab54:3b90 with SMTP id 6a1803df08f44-6bf5d22db83mr14601296d6.35.1723602897166; Tue, 13 Aug 2024 19:34:57 -0700 (PDT) MIME-Version: 1.0 References: <20240812022933.69850-1-laoar.shao@gmail.com> <20240812022933.69850-8-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Wed, 14 Aug 2024 10:34:21 +0800 Message-ID: Subject: Re: [PATCH v6 7/9] tracing: Replace strncpy() with strscpy() To: Justin Stitt , ruanjinjie@huawei.com Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Masami Hiramatsu , Mathieu Desnoyers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2020FA000B X-Stat-Signature: 4gjxhqgknbbion9uacjmupfa57x7kinw X-Rspam-User: X-HE-Tag: 1723602897-258843 X-HE-Meta: U2FsdGVkX1+XV4mi9xEJbfPIlZKwCoznOxKc1/yAg/M5FvTlmh4dwMmIJP5c+NWBnYrEBcXYWuAWo0xsO34mfqVcJjcUraso4S+MGBRFlLaQV1Kodp+kgDHEUNvLw1j0iXaR9Q9QONiMbmZKOPgouOXiAe5/xqaPju+3kSAU0BTgqyLdYWaE2UMXA0dyEHj2olQxjnn4R884OMPz1S72TjRgbb/jnJh0T1zoKwm4v79NtJNYtv2qA/rF17gbh/tQsCC0gwnvrrbbyhM6OHQ/SKAAUUibo9L0CRMjZBs0R9jwlRsKLj7qfgIXuQ1bfqmD8tbWpIwmNXxA0sdLMrQnLXgoDUoENENTvTwwOv+rpDqh2euEnyOr3tNm4xT7RLAdNORR7TqbY5aMNwv7mbudY7IfYjiyUlB6+2hJBkW0TuEbvmF65u/eMxkOn+HhonY/HpE1A/UCkRagNIK/tm8pHmyuZWsKnmJatLM9JEl/0O8RHJw+AjtD2NsuLNPHF4WGp4ICQkIqbkklwNMK3zvL4EvU/F7sPeTF+1UBETPkFIJ+XlAyZhKP3bHjpxA+0Enh1eINej2QjCeyt1zPgWf7YcYe9smt840axDzyeoYnS4jYVWd464Iq0ZYHJ6Yj5asPCJLnVCAjW9oNyQs3nvQWbt1fIBFbWHhXC8ynSroXc7Fdtp6SGR1eYYoGdvrGhODABe7iY8oBX/R2uzrJZDH8prRSZ75qfMTCo0m9KMCzZY6l72zyDA8SJa65ryeXRNi8TKCRiucZAnK3VzcgWQwxC8SAwGvtSsE5VeQ9sLJulx5eWTZmv0cDhrMZchkF6ubGoH/FWpP7fs2ycp6Tl6b+6EAJI/4f5FPWA3KIBmun4QRta6Jr5Z8IVr3XnBUFbjl6hH75Q9f2NEqhENUumjXltQ7aELHCEre/Cw7D47xUG1133l91KqBtuYqImKBAX4Bqb8woJDdMkU6NhUTUadQ G9tDrAE6 Po3iYKAzFieHmmnZ9zGJcJg7D6yoEjxtUXRIuMiB5lDXMmHjsXB6Qtzh1/VZNpCLaUSg7w+2O3N3dcY030Cqgt79K75aXss3Vpmn8suFQcxNRBI9xLtrZancFj6F56d2s6sb7BVEmN11t0i5WZrc5eGllobcthQadEac3jV4EWNe81BWJQgsH5RIVFO66HDP1OAtgp0gtvpXLSgp5LQO1F202KnumY7xs8WLxxZvQuu6wg53k6jYU8FFThxdByeghxT9ySXQLKTHQIv5kVHtQepgevqPGSk5+9ngEgAgrhQfeh0obWcxFGvv4E9L0yoSh2eKuT0tYsxZVMXP2cP/WIY7u02sNu20X5kx16nnET2JfAUAwYnT3EIryWvS1mRVa+CZb5PjzjQq6uYDSC9PdHiquM0JhIDpwXAlCOfr0voN1+KJVO2M1ctg9rW3aKCcrEd8I1Fd4oX7Z4ZDczsGOTg1C3+wucM5aMWseALT8b4A5QBomm+7D5a++0T3fNqKxyy8P X-Bogosity: Ham, tests=bogofilter, spamicity=0.132372, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 6:31=E2=80=AFAM Justin Stitt wrote: > > On Tue, Aug 13, 2024 at 3:19=E2=80=AFPM Justin Stitt wrote: > > > > Hi, > > > > On Mon, Aug 12, 2024 at 10:29:31AM GMT, Yafang Shao wrote: > > > Using strscpy() to read the task comm ensures that the name is > > > always NUL-terminated, regardless of the source string. This approach= also > > > facilitates future extensions to the task comm. > > > > Thanks for sending patches replacing str{n}cpy's! > > > > I believe there's at least two more instances of strncpy in trace.c as > > well as in trace_events_hist.c (for a grand total of 6 instances in the > > files you've touched in this specific patch). > > > > It'd be great if you could replace those instances in this patch as wel= l :>) > > > > This would help greatly with [1]. > > > > I just saw that Jinjie Ruan sent replacements for these strncpy's too > and tracked down and replaced an instance of strscpy() that was > present in trace.c but was moved to trace_sched_switch.c during a > refactor. > > They even used the new 2-argument strscpy which is pretty neat. > > See their patch here: > https://lore.kernel.org/all/20240731075058.617588-1-ruanjinjie@huawei.com= / + Jinjie That sounds good. Since this change can be handled as a separate patch, I will drop it from the next version and leave it to Jinjie. Please note that Steven might have a better solution for handling task->comm in trace events, so it=E2=80=99s probably best to leave any chan= ges related to trace events to him [0]. [0] https://lore.kernel.org/all/20240603184016.3374559f@gandalf.local.home/= #t -- Regards Yafang