From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06ABC2BD09 for ; Sun, 23 Jun 2024 02:30:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 383796B0595; Sat, 22 Jun 2024 22:30:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35A166B0596; Sat, 22 Jun 2024 22:30:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FAD66B059B; Sat, 22 Jun 2024 22:30:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 01A546B0595 for ; Sat, 22 Jun 2024 22:30:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 79F41C0248 for ; Sun, 23 Jun 2024 02:30:09 +0000 (UTC) X-FDA: 82260573738.07.0571915 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf11.hostedemail.com (Postfix) with ESMTP id C111440008 for ; Sun, 23 Jun 2024 02:30:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WhFUhEl7; spf=pass (imf11.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719109801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WM541qVAnGiANIIksD1Xne6uz5S+eheGdJIN5eBGE8Y=; b=TjlnYC1Xr61282f4A1On1p2IDkZBSM1M3gyh8vCBFJHnaF2sjgTkPI6W+zFXYQMmY/8XGW bv66cFvhukWStx8/WVZtWw8CjJ+pJJhZFkFtzG9kYC860qeZCc9TCqNm+GS46IQe/BAMPp 78JG1IQb7jI5vQ7+Nc/Zw7ajfqzU3No= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WhFUhEl7; spf=pass (imf11.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719109801; a=rsa-sha256; cv=none; b=Cb4afj6GPYwAEBt680ijJaCmZzBCHL/0kgwcuQGrqcETCx+iby7qFPdIkLDHCFInGSvs08 6M3YQzOT4ZaFlYZySxUg9uEljyEPXcS67J+cFnmef0wrxBTFG5lveQvuHUhd26QjRoPHmF qp9IB9umGLC77pbqGwPw4GP/EblVDT4= Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6b52eb2ee2eso4184076d6.1 for ; Sat, 22 Jun 2024 19:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719109807; x=1719714607; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WM541qVAnGiANIIksD1Xne6uz5S+eheGdJIN5eBGE8Y=; b=WhFUhEl7aGg0/Kgu41xJiOStCFJAFCSjuDuzQeL077Lj8vACfF31V0YgKyQglUVVtD yWzcPJIlQvOpOvphLCwdDPlXbyKjLVT1pg6zYrsWB7SHf0y6IWiRWKjY8+lqTbJbrYMV pBlC6/9/C7rCRcXAzYzk7NzYs76kcLgfhuqdNbba71KK54QXXe1SuHF9IwUsEGRIxVBJ IAzNXr+eZTtzSf83zx5HtTX7slG439DzEbwa88R4YxWPtd0S2n8F8iFGIrZ7Y1kcbk3H Q53n19ElwRBwBANREztbcchNgTuuSQmckFcYHW5ExAkbKBZyKrgeQI3XjTk2rEWno7Vv 354Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719109807; x=1719714607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WM541qVAnGiANIIksD1Xne6uz5S+eheGdJIN5eBGE8Y=; b=bR1mf2QHvudk9hZ5Tu9SQ3zBSBS6/LBBN8pTc5ZIMbejPA8QByFmlYW1thkOd1njAf BZufnnMSoX1o00fU+IUdn0DAFCbAXYxkv4TvMIQ9jG8uwulvN+WfZ/bevW3fRkDawxB3 99PZgQFt+xh7kl66+QtHEByJYO4py+H7GhCa500d1rlcYaZy4mgbKCuYO634WklxJjBI t5+b42+jSMCaJrqXnBNKxqwEfN5RRX39eSoxZ5/PTOpAPW2kKFuleUEWoVxp2sYqRKmR HUiZMPAG8iLLmDBktHF6hgUvvBj/LkmYzHWUt6yEls/KRxWsiJCokYq4CGAT2du5cgxO 3nMA== X-Forwarded-Encrypted: i=1; AJvYcCXTFwrqeWf5LeO57PUZH1j+HLRGfvHyWu+ncydXZ7e44deDMyHDaV2c6RiVmcAlGtX8Ei92KXnQ1deVFc3IL9CchXk= X-Gm-Message-State: AOJu0YzGZ8lhnQZX1Ac3kHFd9nQ9Ja5ruOGkXfncHcBghgPrzg4Icp0T 5LZaN9E2BbfBz9uBF3qmzWx1Eia4CKEP6lj+AhONGAK6pM1RrnHQcR4b8Rx3NmwaDY+4TEdGF96 aWVH8N/mfWf3+ULRz94tFocgPRfw= X-Google-Smtp-Source: AGHT+IEeabbh6/EMckVo526ehLQ90tgELbRwQuFwnoLikHZJL17E+5jYV7YmCBYvSb5so7hxOyIwV/nrsBs0ESAd1BE= X-Received: by 2002:a0c:e1d3:0:b0:6b4:35fa:cc17 with SMTP id 6a1803df08f44-6b5409c7b57mr14480146d6.20.1719109806997; Sat, 22 Jun 2024 19:30:06 -0700 (PDT) MIME-Version: 1.0 References: <20240621022959.9124-1-laoar.shao@gmail.com> <20240621022959.9124-7-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Sun, 23 Jun 2024 10:29:30 +0800 Message-ID: Subject: Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} To: Matthew Wilcox Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C111440008 X-Stat-Signature: pmb8uw3hkgye5kcd5qn6ep5qg6cse4pu X-Rspam-User: X-HE-Tag: 1719109807-811184 X-HE-Meta: U2FsdGVkX19kA249zzoT+T5XhEMmKFJGIbAMigUliYXRDbh532o0Qn3kojQhyh1GXdNExTJ2E9p4zS8/s6AHeb6g5+YJ5MY8vKocfT/8C1GurbEcoRLEDozm3LAh53eOCpoSPPYGeUb6uSk11kMOmRxCuS1u09SpLm/lyb11RquK8G7aT3G/QFeQzK5P8j/wyPHbnieo1AoqhmGULMt/DEHozQHfS6ed1ytf7+HgbCpjLAGn1UUrES+74kA55kElwgsuxwby1gYq2Hyv1MsB3QllRniUHMUeVpPy191wrvsho4gwh4sXe1ZKALDMeqc2XMzDlHHACtz8Xn6FEItUz8fCjELqFSX2GiO4qILVsg5dMJ6iS5/vxDvFyHW5Cv7eCFp/dKIuUpnbK7+AeHTi9ljDmWErX5WFkQXhEBedjdhZKGw36n0a7bBm5TUtvnK546cty3Pe2EXJ5LCE0/98klTWjfv9Gf7cn+l5nTEVtRXKfHxYCDMjPYycvD2Tc6gfB8i+X4v/9y8CbiFW66bRbM2FDvYf8bmcpIpIjK0nFE43wyHOJBVsGKTyW7HTO/yXExev7K2/sE7DA+/KtZw0MFIh5U1RM4uMX3ZnRkPCioh/vHIJwDsuZVXH9FatGObV509n+X+Z6MefuRufUDLokFsSKzxmT/klxwr0PF+P1RlRwJt9qXRIHlxwtuLC8RDJqdPUC4oWC+kB3HdppgJMlZcbJKZeUQYmxBltY+Z0/1uIobxrR59vzsVRaMO3oh2BccafuNqaH0vZtGx3s7f+x6XZjoBtDC8cZdFSBJHAXSI0AXpOUiZik8GNlp8A9BepTk0UFH2V73Za6AFBNZ7+Q/W85v+3hpGFymALq0EA9ZPrvMAYocQDPO4s0zKubZvjm+KNmDslWsmgRWA3t9IBlMB+0nruDb07/ATMiVA2SiHFSxMG1pMFUQ9NMjJ1teW6e9O1geCPKXisyRzh/Re lpfsg2Xz /NK7rd9/PDn5xNgN52p6RFbaFgp6/01XwkkAKw3s///bhVhC71dLHWT2AJxOz22Jn1ve2sf5sENBZk1z+xiHzVIw8bTODKXvVz/Ogj7sdVWBiCGBm1lXVQg4L+FsvxMvN4j69h291LSzy6hG+u1q9JYuqe9wHtF+Cs4Sw9A6uDI2AOL9eLt5BylO0C9B5KU6dIZwYJlqvAj0t49IlHecoUn6fEn9GTu6QLIQz/jFw9ArWpE/wF59DQhG71mU+CGYh+UegIJjyT3GAnayjd2ebRpwg78tkEDJBPKNQGKl0IwxvqHQRW9zxySO1ScDX3KGj/VcM58cm5Cpoh5TLkoNPOxMxSEk/x93gaGDYNzTjFtukja7DkI7dE8eaJb1n4Yhqz3xQeC1G9hNu1B9S1IkRkxogYVJmIyBq9QC8pzz/1CGN2z4xtoTGgvbsq3KXTK7DjyWApJGtlPufWceP19lpM9R9PZ/ViIYC0H7U3pGbrqtS5JVOQhrJDLeO0WB3Q7naLqtG X-Bogosity: Ham, tests=bogofilter, spamicity=0.001464, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 21, 2024 at 9:57=E2=80=AFPM Matthew Wilcox wrote: > > On Fri, Jun 21, 2024 at 10:29:54AM +0800, Yafang Shao wrote: > > +++ b/mm/internal.h > > Why are you putting __kstrndup in a header file when it's only used > in util.c? I want to make it always inlined. However, it is not recommended to define an inline function in a .c file, right ? > > Also, I think this function is actually __kmemdup_nul(), not > __kstrndup(). > Good suggestion. Will use __kmemdup_nul() instead. --=20 Regards Yafang