From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 602E3C433F5 for ; Wed, 13 Oct 2021 05:21:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D616160EE9 for ; Wed, 13 Oct 2021 05:21:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D616160EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 83C3D6B0071; Wed, 13 Oct 2021 01:21:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC2C900002; Wed, 13 Oct 2021 01:21:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DB7E6B0073; Wed, 13 Oct 2021 01:21:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id 6043E6B0071 for ; Wed, 13 Oct 2021 01:21:26 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1387C8249980 for ; Wed, 13 Oct 2021 05:21:26 +0000 (UTC) X-FDA: 78690266172.01.10DAD6E Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf11.hostedemail.com (Postfix) with ESMTP id C3A4CF0000AF for ; Wed, 13 Oct 2021 05:21:25 +0000 (UTC) Received: by mail-io1-f45.google.com with SMTP id 5so1410243iov.9 for ; Tue, 12 Oct 2021 22:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HrVnYdvI1ca9LbsCkXNOnKAwpoN4ydhXRtKRKADEOQU=; b=nt6L1D2kMe0H+xLU34jtGvuORRKO6p2aAwgyBfS/+x3ODQ6Y2BysZJzgDmFDc8HpWX dwZwB8dWdgkfGbNcuDLFPATBrsMWehipHbe8HtHDPfhmEi+YrVWDfT/v3ng6qMt6zQ/R xUMGZSgNkvFBtk6Uk67nvQ70onY/9GVHz9JP2MPlgGF0kqpGtkM7GMhKQM9iTHO5QuLA 0bTnpolct4Azz9eLdSjK+E+5puAFGt+gsiWRYMUX2j8FhL3chrA1+MbNCPauBF9ksg89 +cGNw0iv2lFv4sD9vwfNwkDJbug1RClcZ2Udnwyg4j+jeF+BTL70qPfdYZtTRDU8+FrP HBYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HrVnYdvI1ca9LbsCkXNOnKAwpoN4ydhXRtKRKADEOQU=; b=O/vGgy53ZL7wJ+vmNSsKP0FQxJJO2j58Pus74vg5qQEZ6fKyTTkKU1tmZuL6Vqx0cu KA3LJBQqhw8XDD8ihRz5ryTSvmz+xSBz4UIcEZZtPE+dyc4FFptipRuu0+Ow/t2yT35i 2DNkTy+0LDBMNMxe/sP1Qrzc+4r4thnDgdohecVRXQtdPgpgsgEkAEsUjnk0Ckj61L1U An0bwx+4aijNeK3Xyo+rxuwbnTvc1s+4fz3MYHRcGJkvY2ylY+EL/3/s/2GaArf7wFu5 JmE4MMsJSDbXiUgy7l107g3BLq9rRF654RCNCEUyXHEesrIvPR6tuivZGVaTD03twFX2 FsxQ== X-Gm-Message-State: AOAM533059KWPhqGpM5X/qJTRYts2DdUbKxstm/jXYZv/iW2Us/rd2lw 0ozfHLuuSDVLiohtMl2yIqOJWfK6JMl+sjJHGsM= X-Google-Smtp-Source: ABdhPJzkmXgH1hVrkdFiXx1Ak2By2/TjMlOyFFuCTSjzrFLsvcFmy3k2eF0xvNlO5eefEJd5L0iZgwJKJccO5uxundo= X-Received: by 2002:a05:6602:27d4:: with SMTP id l20mr13134069ios.94.1634102485109; Tue, 12 Oct 2021 22:21:25 -0700 (PDT) MIME-Version: 1.0 References: <20211012182647.1605095-1-willy@infradead.org> <20211012182647.1605095-3-willy@infradead.org> In-Reply-To: <20211012182647.1605095-3-willy@infradead.org> From: Yafang Shao Date: Wed, 13 Oct 2021 13:20:49 +0800 Message-ID: Subject: Re: [PATCH 2/5] test_printf: Assign all flags to page_flags To: "Matthew Wilcox (Oracle)" Cc: Sergey Senozhatsky , Petr Mladek , Linux MM , Vlastimil Babka , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nt6L1D2k; spf=pass (imf11.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.166.45 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C3A4CF0000AF X-Stat-Signature: ps66b34qxkoki1bxkbnye6wenukuqe4u X-HE-Tag: 1634102485-658581 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 2:31 AM Matthew Wilcox (Oracle) wrote: > > Even unknown flags should be passed to %pGp so that we can test what it > does with them (today: nothing). > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Yafang Shao > --- > lib/test_printf.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index a52c1c3a55ba..f744b0498672 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -608,14 +608,12 @@ page_flags_test(int section, int node, int zone, int last_cpupid, > int kasan_tag, int flags, const char *name, char *cmp_buf) > { > unsigned long values[] = {section, node, zone, last_cpupid, kasan_tag}; > - unsigned long page_flags = 0; > + unsigned long page_flags = flags; > unsigned long size = 0; > bool append = false; > int i; > > - flags &= PAGEFLAGS_MASK; > - if (flags) { > - page_flags |= flags; > + if (flags & PAGEFLAGS_MASK) { > snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name); > size = strlen(cmp_buf); > #if SECTIONS_WIDTH || NODES_WIDTH || ZONES_WIDTH || \ > -- > 2.32.0 > -- Thanks Yafang