From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D25CC433E0 for ; Thu, 28 Jan 2021 07:44:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F40BF64DD6 for ; Thu, 28 Jan 2021 07:44:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F40BF64DD6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 765DD6B0070; Thu, 28 Jan 2021 02:44:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 715EA6B0071; Thu, 28 Jan 2021 02:44:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 605AF6B0072; Thu, 28 Jan 2021 02:44:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 4B4D06B0070 for ; Thu, 28 Jan 2021 02:44:42 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0EDEA1EF2 for ; Thu, 28 Jan 2021 07:44:42 +0000 (UTC) X-FDA: 77754396804.17.chain37_1a147852759d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id DBF6B180D0181 for ; Thu, 28 Jan 2021 07:44:41 +0000 (UTC) X-HE-Tag: chain37_1a147852759d X-Filterd-Recvd-Size: 6644 Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 07:44:41 +0000 (UTC) Received: by mail-il1-f178.google.com with SMTP id g7so3300160iln.2 for ; Wed, 27 Jan 2021 23:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ztUYIztZJjhj5tFTgkC2lU/YF4nMMpQ1Z9nSKOugLuE=; b=BnIWltQ+ltM4LRkMogP4dKfVIO7xiPORVwxQ0nsXxhWa1OMmPQ4GucpEe2IKlqyiyO qPu2N5q9y/dQLjkdqAXqjloZXd7nOGxnHMSx9ZTjaTjrN+kon2+/7TPOHF+honm8KB1S psmdStrdSQGYK5ABjeFcm9+bscp6aYtbQ7YjNAIVnm1DaXlN4RSpTsckF14PXrnFPorU J0znJ2RG4GQMSOagUDSu1ksZ3bx8wpiO8fwY+H7K9aP/N/oek7kKdsvppEsCiZHF9f/Y 3DkjaGdBemoKcJ+wl6dZrzvQNz3EjiQkG/KiJB6vXLuc3BnUv8b9gCmkaADf6llDpv0N wBeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ztUYIztZJjhj5tFTgkC2lU/YF4nMMpQ1Z9nSKOugLuE=; b=Duys4EQcnfDk0ZIfOUd69Af/gn/Iiw/tCGtJX0mIn5u83rZ7pqRprxeCAhgFLfufBJ s+F44kUBA+kKH9N3lADWRBDlGPFWMjR0+Z9pQ0Nj1Wq7Q6ThM/UiSAgYOkTUgIiUn39e I15MV3AdWgkMc5oLQ4lTv3ktJHJBd5IkZomdjsKXotlzthKy23QEwke4Iiat+qYSzlah +7tduC2HCiPDAikKUIE/IzIkhC3E7/J2Di2XXHJ7Verm4CZBlcK8CGq6NexGbIw2nL4o 4OncTMkEzfWE1vhPDdzYQtPxd3Dfg0RWMUKRGtUHtQbeUieFRX0PulW/Q0I4XEjoLxoz WBGA== X-Gm-Message-State: AOAM532OfZTF190Z1Gyc8cah0zQFlJpsNLy2Vhielt6egh0b2vLlvi0o HKcmVkGnU6iaZeFD/I68BhtmXlmkPDs2sk6fpt8= X-Google-Smtp-Source: ABdhPJzULsm865g/naY1bEEhYBuGR1pd0EN42gD0wgvfHu/xIbSXDX7Yp5vnipe1yrPYgKoMcYpzkBcEKziuVwuEmYM= X-Received: by 2002:a92:5bc2:: with SMTP id c63mr11992705ilg.142.1611819880901; Wed, 27 Jan 2021 23:44:40 -0800 (PST) MIME-Version: 1.0 References: <20210128021947.22877-1-laoar.shao@gmail.com> <20210128021947.22877-4-laoar.shao@gmail.com> <27e53062-7b0e-42e8-6f44-4eba44832805@huawei.com> In-Reply-To: <27e53062-7b0e-42e8-6f44-4eba44832805@huawei.com> From: Yafang Shao Date: Thu, 28 Jan 2021 15:44:04 +0800 Message-ID: Subject: Re: [PATCH 3/3] printk: dump full information of page flags in pGp To: Miaohe Lin Cc: Linux MM , LKML , David Hildenbrand , Vlastimil Babka , Christoph Lameter , penberg@kernel.org, David Rientjes , iamjoonsoo.kim@lge.com, Andrew Morton , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , andriy.shevchenko@linux.intel.com, Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 28, 2021 at 10:52 AM Miaohe Lin wrote: > > Hi: > On 2021/1/28 10:19, Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > > the full information including section, node, zone, last cpupid and > > kasan tag. While it is not easy to parse these information manually > > because there're so many flavors. Let's interpret them in pGp as well. > > > > - Before the patch, > > [ 6312.639698] ERR: Slab 0x000000006d1133b9 objects=33 used=3 fp=0x000000006d0779d1 flags=0x17ffffc0010200(slab|head) > > > > - After the patch, > > [ 6315.235783] ERR: Slab 0x000000006d1133b9 objects=33 used=3 fp=0x000000006d0779d1 flags=0x17ffffc0010200(Node 0x0,Zone 0x2,Lastcpupid 0x1fffff,slab|head) > > > > Thanks. This really helps! > > > Cc: David Hildenbrand > > Signed-off-by: Yafang Shao > > --- > > lib/vsprintf.c | 42 +++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 41 insertions(+), 1 deletion(-) > > > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > > index 3b53c73580c5..bd809f4f1b82 100644 > > --- a/lib/vsprintf.c > > +++ b/lib/vsprintf.c > > @@ -1916,6 +1916,46 @@ char *format_flags(char *buf, char *end, unsigned long flags, > > return buf; > > } > > > > +struct page_flags_layout { > > + int width; > > + int shift; > > + int mask; > > + char *name; > > Should we add const for name ? > Good suggestion. > > +}; > > + > > +struct page_flags_layout pfl[] = { > > Should we add static const for pfl[] as we won't change its value and use it outside this file ? > Sure. > > + {SECTIONS_WIDTH, SECTIONS_PGSHIFT, SECTIONS_MASK, "Section "}, > > + {NODES_WIDTH, NODES_PGSHIFT, NODES_MASK, "Node "}, > > + {ZONES_WIDTH, ZONES_PGSHIFT, ZONES_MASK, "Zone "}, > > + {LAST_CPUPID_WIDTH, LAST_CPUPID_PGSHIFT, LAST_CPUPID_MASK, "Lastcpupid "}, > > + {KASAN_TAG_WIDTH, KASAN_TAG_PGSHIFT, KASAN_TAG_MASK, "Kasantag "}, > > +}; > > + > > +static > > +char *format_layout(char *buf, char *end, unsigned long flags) > > +{ > > + int i; > > + > > + for (i = 0; i < sizeof(pfl) / sizeof(struct page_flags_layout) && buf < end; i++) { > > I think we can use ARRAY_SIZE here. > Sure. > > + if (pfl[i].width == 0) > > + continue; > > + > > + buf = string(buf, end, pfl[i].name, default_str_spec); > > + > > + if (buf >= end) > > + break; > > + buf = number(buf, end, (flags >> pfl[i].shift) & pfl[i].mask, > > + default_flag_spec); > > + > > + if (buf >= end) > > + break; > > + *buf = ','; > > + buf++; > > + } > > + > > + return buf; > > +} > > + > > static noinline_for_stack > > char *flags_string(char *buf, char *end, void *flags_ptr, > > struct printf_spec spec, const char *fmt) > > @@ -1929,7 +1969,7 @@ char *flags_string(char *buf, char *end, void *flags_ptr, > > switch (fmt[1]) { > > case 'p': > > flags = *(unsigned long *)flags_ptr; > > - /* Remove zone id */ > > + buf = format_layout(buf, end, flags & ~((1UL << NR_PAGEFLAGS) - 1)); > > flags &= (1UL << NR_PAGEFLAGS) - 1; > > names = pageflag_names; > > break; > > > Many thanks. -- Thanks Yafang