From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2861AC27C54 for ; Wed, 5 Jun 2024 02:49:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8196B6B0085; Tue, 4 Jun 2024 22:49:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C9A76B0089; Tue, 4 Jun 2024 22:49:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66AC96B008A; Tue, 4 Jun 2024 22:49:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 45E4D6B0085 for ; Tue, 4 Jun 2024 22:49:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 03591A1CC3 for ; Wed, 5 Jun 2024 02:49:33 +0000 (UTC) X-FDA: 82195304268.17.68218BE Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf05.hostedemail.com (Postfix) with ESMTP id 4021C100007 for ; Wed, 5 Jun 2024 02:49:32 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=miy8c1Z+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717555772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2saUQpdqdIbqLGxvd8R0wiju4YwezRrdt4faqpUQys4=; b=7XrhY52xPD3wLcy7btf4wkqjjLT1JFUlY0WbcLnzcSOU9yM54LC69uOlBhEltQIrwfgSpr QM9w3ZQPOdXxKUd+0Vr6aWWGSTUT4ypzm2jEXm8bVgm/GIFIYSKCBIlNObBtf6KwhIYpwU Z3CiI556L/j8b2MF0g/ifBbidhaPFYA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=miy8c1Z+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717555772; a=rsa-sha256; cv=none; b=wzAEOY01M3ESp1hW3N8ZIga84FPA4vU1BY7VA0mtbJuGpfhk/GVMfXdZypiVTDqBGugpEf nKLjAs7IppvOHtm1YEORUL2MAzQxKMWY3KUY5MDIAQtgrjSVuue0WnErVYuvhA8qJMkdi3 ktSGrlFqpfVFZr7WaqvHKGiJU44RmSg= Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6aedd5167d1so26158106d6.1 for ; Tue, 04 Jun 2024 19:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717555771; x=1718160571; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2saUQpdqdIbqLGxvd8R0wiju4YwezRrdt4faqpUQys4=; b=miy8c1Z+xorUKe9R1RwS3SMOp5JQOnuCEfClQAEDAaKaej9sqUHvQbc4oYVhCd6pzC 2PMqxE2pq+Fkrkb/Sun0SbCxZofXC4DON4zyJ9+UiYBB6YTRUtP6uNBU61yfJAv+7bkM FDcLh85OfP5Ij+45zlfWt+15kQAGbie85wHlvHrEYg3Sty5dz0zKO0ceyf8YdMpY48sr YoNHln5WZPZOfxPQ/UilLK1TSwVp1duMPTe3Ce8P7pghhZmQVmKi25Fb+PLTKflE53gj BkiTGJ1CIHt0+S1AoaJXIEgPQzmN1iJ2e6CYsTBlby9AOAUp4ByRvGQMTHP4MCmZN/I8 vZEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717555771; x=1718160571; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2saUQpdqdIbqLGxvd8R0wiju4YwezRrdt4faqpUQys4=; b=fuwJG4F/fF5d4FhxlZxFKOpZwA9xrh6fyc1sbfyMivxDl88WiXmM/JH3+sOQyk1gfz T5WBqNV6qYcbJ5WSgjK0jXCJ2WqvZ8qRUk2vm6o8NN95Nhu/YlONvOqK3C4Q9VVZ0tDk N7PX9c63bgKeLG2RQRco5nUASE5plgy8C3yw92sAqev8kGoVdw3jupto5V13x3mX1Mej Y95iSqdSKFqHVvp2QwNnsCalSWxLGQlvM4ooHpknprAVXkfSPpE1x+hIEEcUhjNBJZtB 5e1vv3aVkMmvQvhQkqDxo4xbPoELjwDacsbFD8//b3ntVjUllYwuZhlgMGgdCeNEEia0 nqFg== X-Forwarded-Encrypted: i=1; AJvYcCUa08OOQynXDotqWkEtEzJByWS4xMpLDSzE687ihek0FUS2JZpp1xtfNXbO5X0L+V8zbzEUrWDsG4xn5vnSknoLLjs= X-Gm-Message-State: AOJu0Yxr/Kgd6H0Gy+iJiJC69i7/vp5qmIyeHX/JVtJKvXTLpo8O0qI7 Gd9MtAd2i8XwM4MPQX4CsE1yIf72wwITu9Wa9JSvW7Du9nBv3sGxWjoHCCxV7h3IwdPVTlXPCUE UQiDmRKFotjp7yj+iGXoMKeZGJ0s= X-Google-Smtp-Source: AGHT+IFq+yCl5o74ZjH3g13NJDso8wQ5+sJqbQadqfrtImzCDvp3GWtQvEB2R3IWUMP4fI/FfSN1B6bVUP2acYQYprE= X-Received: by 2002:a05:6214:4498:b0:6af:d47a:1421 with SMTP id 6a1803df08f44-6b030a9d410mr14097896d6.60.1717555771212; Tue, 04 Jun 2024 19:49:31 -0700 (PDT) MIME-Version: 1.0 References: <20240602023754.25443-1-laoar.shao@gmail.com> <20240602023754.25443-2-laoar.shao@gmail.com> <6cf37b34-c5e4-4d92-8a60-6c083e109439@stuba.sk> In-Reply-To: <6cf37b34-c5e4-4d92-8a60-6c083e109439@stuba.sk> From: Yafang Shao Date: Wed, 5 Jun 2024 10:48:55 +0800 Message-ID: Subject: Re: [PATCH 1/6] fs/exec: Drop task_lock() inside __get_task_comm() To: Matus Jokay Cc: torvalds@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4021C100007 X-Stat-Signature: xno9w4hqcdutqzkxbdgnr6bksgq4tysz X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717555772-304649 X-HE-Meta: U2FsdGVkX1+OFgwKeCeqkxA/d52ZsE698QehG8wh3Hh4hq/cZHrkt1m7mHMOM1798/wm5rG5pVyO411ngJ7rwsBbUR4bHSDnLloJBsUyTb5+7aIay2rCfzSHKsny048A/Nw1NyAsYnHFbw/4HwrrXv9yUH2h+hXiy+XV/ueS+A54vfwSMr3LOE83QS6B2BtXzRyGpx662hUrOpRW7htQCCeWO27WXRTqe4y+S5yXsCAdH3P+LsOpcE4RWJKUHBVt/5qfG6fOuxNQ692fgkjJss+rpqI1OPEnWiuiB0TtexCRibwbcUp3L9+0ID5agSxYhVXl/KgndDlGF175DTPADKNp2ZgDsDAxrO2NU0OdZxT8+2XAkz/bHp7++10mnB6zk9qewcbbLwN4c9ya7umnJnKlvFp/2cVQubTRedjWAYSsLjtkDuJ5uYKYt/pnR0mKAXJupDrj4iDfG62wcROYYiDqSnwKc1SRK0MrSu6hWZ5x/5qy25fHrJvEj4KiZTOSJFG5jjW5kYJBsYg1jTJr4P2+ioTz5TvJd76gztN6XTqpSCp5PkeFP6jlxqLaQxZkIzk+7MfbGEAw6V7Wezppo7R0OhqEcrM9oBVQDlhYItom+t5IHYoccyNeD9Z+QrI2dsvoOPAH12b/mGmZHdB9ReUrEVQFN1k33kIsAgAeGQCtkU+DGozTY7RX8O+kWCQtiUA/K5e9VszCG12ZorwhJ3/iMHA/yWlBnOHvglrg+UM+DFqrsxqpKrh1sdsZfM/MVzgCvPRmzPiofFrD4o1xLufSvzwpTHzF/J/bYnhl2SpXTNK+bkiTTmwOeQZi75CbITRlegiMGO7UgaLljcddhPjYFVCD4LSPRXOjlsQUyCNGVb2JUlSdXvAl2wqhD7jXXxjVGosTn9lvS1PK3/i+eXgfApK9qKSIrU0MSawAOIve6KlpM2iB8yqXKv/TFjDhQy6iqHuOtVd9AYDkEy8 Litt+U/l zhhCsu5mvTAbdwkEjNfHwF2VE4XmVgQIB1jIDl1WyJwm3cMJMuWq+cMa1clcbKIFgVu4vqJRIev2UGIaUhv1kjk6JZr2OdoBX3JsQ6hZwCqLdmDQGRJEsRqLdAd9T1D3pexLafMGHv/msK66dBi33NXyGzoxbHwVh97yZemeQzyth0UrFlrCvEkEpvV2Ae6SiKLqO0MdsIHAbtBmsiKUlDYGm+C5XhzQ7IMSpfnfWBjF/UJIJDKILpYBrWxZFf5+xMiCIMOr4EdgorYxzVsCgEKVHLJMPdkheTynDoNGnfCYjGlj0YD83rSDN0aA5cyGQhYOkpSL20lAyDCGsn7L6z4BCDuSiwTkzdQ7anqh6E8JA06f9d0Bt44IPt97v3LlDUQOXqa08N3OuCx6LCSW0yt4K37muJQvvyXdvMhP8cV5MO+lDDR6zr9aZnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 5, 2024 at 4:01=E2=80=AFAM Matus Jokay w= rote: > > Sorry guys for the mistake, > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > index c75fd46506df..56a927393a38 100644 > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -1083,7 +1083,7 @@ struct task_struct { > > * > > * - normally initialized setup_new_exec() > > * - access it with [gs]et_task_comm() > > - * - lock it with task_lock() > > + * - lock it with task_lock() for writing > there should be fixed only the comment about ->comm initialization during= exec. > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index c75fd46506df..48aa5c85ed9e 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1081,9 +1081,9 @@ struct task_struct { > /* > * executable name, excluding path. > * > - * - normally initialized setup_new_exec() > + * - normally initialized begin_new_exec() > * - access it with [gs]et_task_comm() > - * - lock it with task_lock() > + * - lock it with task_lock() for writing > */ > char comm[TASK_COMM_LEN]; > > Again, sorry for the noise. It's a very minor fix, but maybe even a small= fix to the documentation can help increase the readability of the code. > Thank you for your improvement. It is very helpful. I will include it in the next version. --=20 Regards Yafang