From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 756C9C05027 for ; Thu, 9 Feb 2023 11:28:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E254B6B0071; Thu, 9 Feb 2023 06:28:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB82F6B0072; Thu, 9 Feb 2023 06:28:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4F306B0074; Thu, 9 Feb 2023 06:28:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B18036B0071 for ; Thu, 9 Feb 2023 06:28:40 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7FC70406BC for ; Thu, 9 Feb 2023 11:28:40 +0000 (UTC) X-FDA: 80447530800.15.3B3A828 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf17.hostedemail.com (Postfix) with ESMTP id B89D540007 for ; Thu, 9 Feb 2023 11:28:38 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K055cZuD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675942118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cDkWXAEEhy2VoXh+Bc3398ODh0oG5X691Xoq6e7LZmg=; b=eY/9jzXkeDFkZdnGwiYd7atIVR3IUPC9ygihFEmNKGBXxCJMyIIIu5asQ92jeEO7VRF/Et EoAYEgLxnEZ4IaZjLGzrleQ0Zw4rWy4+HOqaeU1LnPdWjg1Y2nT1LyfH4q+NiNS9qjd+Ha fYRrKa59EngXnvBsljfPIWl61IQHYys= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K055cZuD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675942118; a=rsa-sha256; cv=none; b=rksE76tSa8sG/yFmM4bsspr5FQvWO+I7mDTWKLvj/eThH7iNYEt4zZQ4wzYyRg1+Js/L0q bhoClkQ/EWdahnaiL4ZQ5/aq+4hoseRgd0y2EkJQKCWbYtvF2fGk+dy+Ii660LA8pQogar oWAmWDMqqMKjD62uLcb71V+6HEgX1Yo= Received: by mail-qt1-f174.google.com with SMTP id g8so1424499qtq.13 for ; Thu, 09 Feb 2023 03:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cDkWXAEEhy2VoXh+Bc3398ODh0oG5X691Xoq6e7LZmg=; b=K055cZuD84EE4vZQSZTVkgvlYu6HEsqiYoe0wUMw1gXWvVpibA8mZVBwCnGtHYDZjj vCeA0nXg0VBUFLVkpn8DaNNZiR0uFOc8MzsnALrn3of8Zfpjvr20WerxDWbyWAqvjnT4 wJYREah2Bzt1cZu2v+KGxKGL7jRm8Uj4xcpHb38gq5rJic3U/2+lXLsWwast+ErQUBRi PMno/k5THMgxcHw39OD4fW6z15xJnDVP6An9Ajhpr5emlZS5RYonCETfxXryUGlVu1B3 rg4rERM/ld+83BXTfwnH29Bhjcc1cO6vyDUpBrBgkwryqLwyHiKxZ4fZ1DNHLYi04l4c 3GVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cDkWXAEEhy2VoXh+Bc3398ODh0oG5X691Xoq6e7LZmg=; b=V63nd9C+45isoGzXa9GVNkurjU0604Nrm9mJvN3xDvdpJ9Gq92HeQrBk1zaG8EIUZE x9KlOgY1Fqztt3NKOkpqQ33vQH6xNorBQsWox326/mVzIMe5BeYVyD65qXNsXPGI7yzQ Dj/LPGJaRiuY8/npvm7EPMAEK+r4AJ51DA9hQmyDfaWP/xqSLsDGT8G0VRU/LhOC7gYH BUOYOVSI9S0auf170mUg7BMP+GK3mopuT6T1h3NzRl6X5QQE1jSOYYgezlm2V2oDfz66 fJS/Uj9LJim1XIYi2FjsGse3aotODP/SeO4GHyUp+70PUN3Fv7NJqpw1NdwpJda3RGHL itNA== X-Gm-Message-State: AO0yUKXBpLeOvkIF/tiGjaggu3Lv2f9X23GrZ2SrMuHCLT3mFnOz+GkU fCci+VNtwJGKi1fXSrTsg+Kx1MtCb9XScahE43M= X-Google-Smtp-Source: AK7set9UnhO3e0ZCvAf4BBcgOgkkPqdkdK7wmZPj6GUROOzAcJSKfG0kRz3snJW7n6FP3me6fhAqzM31MvVZQSdnKlM= X-Received: by 2002:a05:622a:1c8:b0:3b9:b1a5:b52c with SMTP id t8-20020a05622a01c800b003b9b1a5b52cmr1634714qtw.166.1675942117789; Thu, 09 Feb 2023 03:28:37 -0800 (PST) MIME-Version: 1.0 References: <20230205065805.19598-1-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Thu, 9 Feb 2023 19:28:01 +0800 Message-ID: Subject: Re: [PATCH bpf-next 0/5] bpf, mm: introduce cgroup.memory=nobpf To: Roman Gushchin Cc: tj@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B89D540007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: zf3jpwtbc11ummhcctsgwx9fz4xtun1o X-HE-Tag: 1675942118-260429 X-HE-Meta: U2FsdGVkX18osVKQ9xBhtwmgAMH/oJeZGKFWnnjYESREcHvOIYZTgKHVJtrSiYxE95WmnfQ7brcwYxZgD/r9RdsSgaDLRxh2wZOpNPAEmOqfNqlzll6SXSVIXveOszeKhdUKMJ/+2R2GaZ9AifXf67+csitw6TrsviglxGDhU8JBrvWQ95WGN2uO8udyi0r2dP7KC74wMZ/eDYVfWdRIu343/qzi5Ue54ZT7M+qesF46/IbE0eIBNd6WcxSa8EeFYwNFwt5CjX+fy+ThvxgntrJPZPWLvIv6WuHyfiu4r5Ym3P+NZUYQCFhg7COxjAQfOUmwEsitB+wnlk0lEcd2a2jJEWBzeCjM82OgZXeTqVpMOZszgvIbk3IKy5ymm3+PqVUZ/vTiJMrujvQWCuOZ54/8G4yZXyx0cWQb314QFbgLiDqnoRrX7CxVISTjZXqNFeb0hj/IzOH23MVDonOGEUAaw1il6YE7FJMrtKHKcrca+fCsimVY4VRsWHKTPMifeW7Uq5EZx4EbqPnCf41YwmgAkS5WAVUt++5aoPIgHJ0IfH5Zab+unz6xRgJmAtQJM2FVpdIj9idlLm+snkQF+ThAOpYqyYZaZS3DVynnyAhIQ/6be02/W46l8p2boy2SkR67+c9H7Fn+rZrsh8PL38c8saVe5mDcs3rXx0EfVlqvVDghm8bGXJYSqJ4yG0f67VHSHe/9tgXB5uRk2o868A7YGXIAXp44ByQaSPPkpy+m3eG+MiBO5KbgaZMkpQMAoagA5iG8lJ3f0PSeTFTH7hcGZVDJmKrMXaILM9MIHOF67uOnPrerG8+HX3vlbUL6NdKji4lfB+qn3ZK8Ab24A28bhxN+eVz2xZJ7NUTu+fkpjCWSaQsKhrbT5oacr144JaL7TCLFr5Ht7iaCzKEHA4v/SaqMm2hGGhOEu/yYxSe9qixpRoGx7ugLCDBq3JzOqlfJ/YNIzWl+kw3fieb Qfuqjekw CcJf+6pRKKRfMaqysxKVOmumU5JbIaldYy/JgHq7kUSflUYnuADr6Vz5MK33Vh3nEQbG3kEspfsA2jYy3AV0BQvNyNcjQGPwTv6JlSzbuDVpszc+bgEpcnGn8JttpAb1CT4FUdYc7ceNSgQ2QMP7LHz0fj6GOuXn66c3hH5JaxWg+7bIfw3aWDF/1MAcoQVXs7EWaoCmuB3aBzHvjWGg6jLIBLV+o0P6Otwd8tdVfohEiNnAaFwXmkcpjiMAOurZK9RGrXEe6tcsPUmSvUZGVN+6QtyXNyHfNqTC3A+/AQyBXiZ6y1mL8SHuChLNbTbPhypLclDYLcw+UsMMRYI2RFeb5e053yZq2zF69g4150V6060lUKYMcqysFNlhk48TEBicwkQqczJvXjSXCLrolXe0YCw8NJOlzrO/mafaNL6kvN79MgM0FBsqjqCl8/YaDbO7AJxOIjhiPa/oQ+en/o4RWtFQavxSQp2mBE/QcG3DV3X+TjfTsxQBZ0wGHENzyVU1yJUHii52KEuUW4Kvi1S5ROhZQgCWwvTiUlddDmjepkXY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 9, 2023 at 4:54 AM Roman Gushchin wrote: > > On Sun, Feb 05, 2023 at 06:58:00AM +0000, Yafang Shao wrote: > > The bpf memory accouting has some known problems in contianer > > environment, > > > > - The container memory usage is not consistent if there's pinned bpf > > program > > After the container restart, the leftover bpf programs won't account > > to the new generation, so the memory usage of the container is not > > consistent. This issue can be resolved by introducing selectable > > memcg, but we don't have an agreement on the solution yet. See also > > the discussions at https://lwn.net/Articles/905150/ . > > > > - The leftover non-preallocated bpf map can't be limited > > The leftover bpf map will be reparented, and thus it will be limited by > > the parent, rather than the container itself. Furthermore, if the > > parent is destroyed, it be will limited by its parent's parent, and so > > on. It can also be resolved by introducing selectable memcg. > > > > - The memory dynamically allocated in bpf prog is charged into root memcg > > only > > Nowdays the bpf prog can dynamically allocate memory, for example via > > bpf_obj_new(), but it only allocate from the global bpf_mem_alloc > > pool, so it will charge into root memcg only. That needs to be > > addressed by a new proposal. > > > > So let's give the user an option to disable bpf memory accouting. > > > > The idea of "cgroup.memory=nobpf" is originally by Tejun[1]. > > > > [1]. https://lwn.net/ml/linux-mm/YxjOawzlgE458ezL@slm.duckdns.org/ > > > > Yafang Shao (5): > > mm: memcontrol: add new kernel parameter cgroup.memory=nobpf > > bpf: use bpf_map_kvcalloc in bpf_local_storage > > bpf: introduce bpf_memcg_flags() > > bpf: allow to disable bpf map memory accounting > > bpf: allow to disable bpf prog memory accounting > > Hello Yafang! > > Overall the patch looks good to me, please, feel free to add > Acked-by: Roman Gushchin > > I'd squash patch (3) into (4), but up to you. > Sure. Will do it. -- Regards Yafang