From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA0CC433E6 for ; Mon, 1 Feb 2021 14:45:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E05826024A for ; Mon, 1 Feb 2021 14:45:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E05826024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5A8A26B0078; Mon, 1 Feb 2021 09:45:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5588C6B007D; Mon, 1 Feb 2021 09:45:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 449116B0083; Mon, 1 Feb 2021 09:45:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 2CF1D6B0078 for ; Mon, 1 Feb 2021 09:45:18 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E5AEC181AEF0B for ; Mon, 1 Feb 2021 14:45:17 +0000 (UTC) X-FDA: 77769971874.20.party17_1f14c5b275c3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id A2801180C07AB for ; Mon, 1 Feb 2021 14:45:17 +0000 (UTC) X-HE-Tag: party17_1f14c5b275c3 X-Filterd-Recvd-Size: 4098 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 14:45:17 +0000 (UTC) Received: by mail-il1-f173.google.com with SMTP id p8so15776488ilg.3 for ; Mon, 01 Feb 2021 06:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I4D16KIn4mdPhfH6zQNKK7p0fTmhOo1v0cmsmsfFxGA=; b=ug+16pnxrHl306VQCEZxGDt73DrCGl7Zi3egCSW52HPzvQ/Edp9CyOFir9ng16GLUm Yyhrt3Z13jo1fBi6m+vJiQ9GJ6h4bbFEvTw+RdSCZEPgXBTIeTki/oJ7DbbJSqEOI3SM Za5k4fAaBsVrzR3jmWK5zflFA3IF7LZ9ijBB++Wp+AcvobpOId8znN9+/3Xjz9qG0xZU aPAM+USuXjkHZAl2peQIwb6cpUGApEebiM6kCBobWsBBXhwcWHYYdZbveDX8KlDSA7RM DPqGBt+MZMwFBGGbjeMn4mbaSkm61rMebEK/VRw2aHWEZDILkLzr8XJpjhAMCZnae98E WoAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I4D16KIn4mdPhfH6zQNKK7p0fTmhOo1v0cmsmsfFxGA=; b=YeHtNGYYzE9do4TQ4lzeeKX30eVfAS+mUgAizgcFWIsaF92GUj96CMUCiJSyrdjVWR unW+Cc8XmWEDCoSbf2peDGUdvPrzvj51b87TKvVvf3kwLX+6tMYLn/gRULlYh7ivNVej 6mXwHceGPqI3b3ssIFVD0sW+n/nq1n0dsJgxk18awj6YKoX+wtlaxHGoKIfpk3ybVncP 5CqX7HMExEgc0F1/DppQOP8KtQfreWrvGURAvDfQZgh3q2zKZ30QVU/K+94sH9N3K6HC 2QaRfQGjr3wDGVSbb35DLD8U4sL2W5LJ5yTNlqUgrNolQ73hwWaibjWjrV1/Jd63LmPh Su4w== X-Gm-Message-State: AOAM532uwIT4+E6mlfYYDTOuNzy+4Yqe6PC5d8G/PNCbDbg+3U3bdT3U DoMgrLwSrt5H1kxMZ3okTtiABfbU6vzGgCBjAO4= X-Google-Smtp-Source: ABdhPJzi7UA8le4Q9njnbQvMd8GQ/IaIjSSCpNOKHw4aAjJVWKUJXO5L9Xg7MA54CfrfIjTfnOyWrHZ9jkJpXGKc4do= X-Received: by 2002:a92:d3c7:: with SMTP id c7mr12632482ilh.137.1612190716727; Mon, 01 Feb 2021 06:45:16 -0800 (PST) MIME-Version: 1.0 References: <20210201115610.87808-1-laoar.shao@gmail.com> <20210201115610.87808-4-laoar.shao@gmail.com> <20210201141505.GR308988@casper.infradead.org> In-Reply-To: <20210201141505.GR308988@casper.infradead.org> From: Yafang Shao Date: Mon, 1 Feb 2021 22:44:41 +0800 Message-ID: Subject: Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp To: Matthew Wilcox Cc: Andy Shevchenko , David Hildenbrand , Vlastimil Babka , Miaohe Lin , Christoph Lameter , penberg@kernel.org, David Rientjes , iamjoonsoo.kim@lge.com, Andrew Morton , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Linux MM , LKML , Joe Perches Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 1, 2021 at 10:15 PM Matthew Wilcox wrote: > > On Mon, Feb 01, 2021 at 07:56:10PM +0800, Yafang Shao wrote: > > - Before the patch, > > [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head) > > > > - After the patch, > > [ 6871.296131] Slab 0x00000000c0e19a37 objects=33 used=3 fp=0x00000000c4902159 flags=0x17ffffc0010200(Node 0,Zone 2,Lastcpupid 0x1fffff,slab|head) > > I would suggest it will be easier to parse as: > > flags=0x17ffffc0010200(slab|head|node=0|zone=2|lastcpupid=0x1fffff) > > That should alleviate the concerns about debugfs format change -- we've > never guaranteed that flag names won't change, and they now look enough > like flags that parsers shouldn't fall over them. Good suggestion! I will do it as you suggested in the next version. -- Thanks Yafang