From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9C05C433EF for ; Wed, 13 Oct 2021 05:20:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5433E60231 for ; Wed, 13 Oct 2021 05:20:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5433E60231 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CA9C26B006C; Wed, 13 Oct 2021 01:20:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C59B46B0071; Wed, 13 Oct 2021 01:20:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B48D26B0072; Wed, 13 Oct 2021 01:20:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id A52D46B006C for ; Wed, 13 Oct 2021 01:20:47 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6529618264840 for ; Wed, 13 Oct 2021 05:20:47 +0000 (UTC) X-FDA: 78690264534.17.896841C Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf27.hostedemail.com (Postfix) with ESMTP id 2609A7000091 for ; Wed, 13 Oct 2021 05:20:46 +0000 (UTC) Received: by mail-io1-f47.google.com with SMTP id e144so1446644iof.3 for ; Tue, 12 Oct 2021 22:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xM0Sfh7G6XofRwfC/PRBrfo5D+ZUd6FFO3tMb8Km2xU=; b=KGR0NUxk80tls1ABQR9ynE6WnCoXgWwRD7ntKsgSfrKJ7BrrYXN6uUFa+vzf6To/bV aCbQhrFirgRtonqical8yx+g6jKr6tPY54X7y/PX7hF35vOy6/7m0XEqiToczJv3n13N z86eAvrJ9Xeo7RPVhwuLyeM/UQh+UQuqgxjgXWt3B5Hw7JQaggYYkIUOKQ3Z0vEG7nhQ wbBGTcg6pZFYDG0S/c7YfXqgBpeWxJdkA0fhTRbt/aYTyRB9l5CWF09WxeCLf4r04iUA R9six+amG9TW7uvbiVyyB604YQKYyUsAsPmzvG0G42FpoNhUOlq5kHLAXdYaPQeX4QFe jHYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xM0Sfh7G6XofRwfC/PRBrfo5D+ZUd6FFO3tMb8Km2xU=; b=ActughayFZcLv23VVfp46/lNnw+muYB6rdBgR+wTbWoP6AR8hhOJRn7yAWcfiXQ2Lt ax0vcjWtVBO2MU5UAbr9v8Loj0ZIK121++YqB1TpNFOd3B/WV1uIX51OQKx9u6aKodsw GoV9Z4NzB5HReBG7yc+Oq1wv8yW/e+k7y+Co+uMwOABJ8o93HbhOb4hsG5x241Cla/va BGVZ70zcgojIkrUn/yuygpzo5G89lgyFy6u9vDYIHfEBDx+eh82aC0+nLRTtaPSQkQSp SAEYXw9QzdTJKCWKdLm1RNI42fn0ifm6+gnzaRWJ1awoe0+szzq74+dAEXPHR9NyAjK+ zY2w== X-Gm-Message-State: AOAM5321hQKczVYxDH5EeB6XWWcVyWfPlLeAVjfdwxn8hIPE/ETeqf/n apoSvh0Tm0WMcu0bwIVXkF7Nu4yIMBHta13kF2s= X-Google-Smtp-Source: ABdhPJw1xHM4wBwBZvC5GOpg86KaRsR+MyzLIxVFEkM/BD5QC9+08mcL85VxGPAV68t+eg5gmVcfeoTuzHCW4u8zy2c= X-Received: by 2002:a5d:9493:: with SMTP id v19mr26913650ioj.34.1634102446384; Tue, 12 Oct 2021 22:20:46 -0700 (PDT) MIME-Version: 1.0 References: <20211012182647.1605095-1-willy@infradead.org> <20211012182647.1605095-2-willy@infradead.org> In-Reply-To: <20211012182647.1605095-2-willy@infradead.org> From: Yafang Shao Date: Wed, 13 Oct 2021 13:20:10 +0800 Message-ID: Subject: Re: [PATCH 1/5] test_printf: Make pft array const To: "Matthew Wilcox (Oracle)" Cc: Sergey Senozhatsky , Petr Mladek , Linux MM , Vlastimil Babka , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2609A7000091 X-Stat-Signature: 6jicr9so4xxz16iaxbnpu1uuc3dje1r4 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KGR0NUxk; spf=pass (imf27.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-HE-Tag: 1634102446-678878 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 2:29 AM Matthew Wilcox (Oracle) wrote: > > Instead of assigning ptf[i].value, leave the values in the on-stack > array and then we can make the array const. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Yafang Shao > --- > lib/test_printf.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 55082432f37e..a52c1c3a55ba 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -586,22 +586,21 @@ struct page_flags_test { > int width; > int shift; > int mask; > - unsigned long value; > const char *fmt; > const char *name; > }; > > -static struct page_flags_test pft[] = { > +static const struct page_flags_test pft[] = { > {SECTIONS_WIDTH, SECTIONS_PGSHIFT, SECTIONS_MASK, > - 0, "%d", "section"}, > + "%d", "section"}, > {NODES_WIDTH, NODES_PGSHIFT, NODES_MASK, > - 0, "%d", "node"}, > + "%d", "node"}, > {ZONES_WIDTH, ZONES_PGSHIFT, ZONES_MASK, > - 0, "%d", "zone"}, > + "%d", "zone"}, > {LAST_CPUPID_WIDTH, LAST_CPUPID_PGSHIFT, LAST_CPUPID_MASK, > - 0, "%#x", "lastcpupid"}, > + "%#x", "lastcpupid"}, > {KASAN_TAG_WIDTH, KASAN_TAG_PGSHIFT, KASAN_TAG_MASK, > - 0, "%#x", "kasantag"}, > + "%#x", "kasantag"}, > }; > > static void __init > @@ -627,10 +626,6 @@ page_flags_test(int section, int node, int zone, int last_cpupid, > #endif > } > > - /* Set the test value */ > - for (i = 0; i < ARRAY_SIZE(pft); i++) > - pft[i].value = values[i]; > - > for (i = 0; i < ARRAY_SIZE(pft); i++) { > if (!pft[i].width) > continue; > @@ -640,11 +635,11 @@ page_flags_test(int section, int node, int zone, int last_cpupid, > size = strlen(cmp_buf); > } > > - page_flags |= (pft[i].value & pft[i].mask) << pft[i].shift; > + page_flags |= (values[i] & pft[i].mask) << pft[i].shift; > snprintf(cmp_buf + size, BUF_SIZE - size, "%s=", pft[i].name); > size = strlen(cmp_buf); > snprintf(cmp_buf + size, BUF_SIZE - size, pft[i].fmt, > - pft[i].value & pft[i].mask); > + values[i] & pft[i].mask); > size = strlen(cmp_buf); > append = true; > } > -- > 2.32.0 > -- Thanks Yafang