From: Yafang Shao <laoar.shao@gmail.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Bharath Vedartham <linux.bhar@gmail.com>,
Linux MM <linux-mm@kvack.org>,
shaoyafang@didiglobal.com
Subject: Re: [PATCH v4 0/3] mm: improvements in shrink slab
Date: Thu, 6 Jun 2019 23:03:12 +0800 [thread overview]
Message-ID: <CALOAHbBuF07j1Nt2tAg6Hd2ucse6O9PLhY-yr_K-56zerst=iQ@mail.gmail.com> (raw)
In-Reply-To: <20190606144439.GA12311@dhcp22.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
On Thu, Jun 6, 2019 at 10:44 PM Michal Hocko <mhocko@suse.com> wrote:
> On Thu 06-06-19 22:18:41, Yafang Shao wrote:
> [...]
> > Well, seems when we introduce new feature for page relciam, we always
> > ignore the node reclaim path.
>
> Yes, node reclaim is quite weird and I am not really sure whether we
> still have many users these days. It used to be mostly driven by
> artificial benchmarks which highly benefit from the local node access.
> We have turned off its automatic enabling when there are nodes with
> higher access latency quite some time ago without anybody noticing
> actually.
>
> > Regarding node reclaim path, we always turn it off on our servers,
> > because we really found some latency spike caused by node reclaim
> > (the reason why node reclaim is turned on is not clear).
>
> Yes, that was the case and the reason it is not enabled by default.
>
> > The reason I expose node reclaim details to userspace is because the user
> > can set node reclaim details now.
>
> Well, just because somebody _can_ enable it doesn't sound like a
> sufficient justification to expose even more implementation details of
> this feature. I am not really sure there is a strong reason to touch the
> code without a real usecase behind.
>
>
Got it.
So should we fix the bugs in node reclaim path then?
Thanks
Yafang
[-- Attachment #2: Type: text/html, Size: 1820 bytes --]
next prev parent reply other threads:[~2019-06-06 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 10:14 Yafang Shao
2019-06-06 10:14 ` [PATCH v4 1/3] mm/vmstat: expose min_slab_pages in /proc/zoneinfo Yafang Shao
2019-06-06 10:14 ` [PATCH v4 2/3] mm/vmscan: change return type of shrink_node() to void Yafang Shao
2019-06-06 10:14 ` [PATCH v4 3/3] mm/vmscan: shrink slab in node reclaim Yafang Shao
2019-06-06 11:17 ` [PATCH v4 0/3] mm: improvements in shrink slab Michal Hocko
2019-06-06 14:18 ` Yafang Shao
2019-06-06 14:44 ` Michal Hocko
2019-06-06 15:03 ` Yafang Shao [this message]
2019-06-06 15:33 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbBuF07j1Nt2tAg6Hd2ucse6O9PLhY-yr_K-56zerst=iQ@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=linux.bhar@gmail.com \
--cc=mhocko@suse.com \
--cc=shaoyafang@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox