From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85761C61DA4 for ; Sun, 12 Feb 2023 03:20:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D4516B0073; Sat, 11 Feb 2023 22:20:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 884B26B0074; Sat, 11 Feb 2023 22:20:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 724926B0075; Sat, 11 Feb 2023 22:20:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 602FF6B0073 for ; Sat, 11 Feb 2023 22:20:27 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FBC41C630D for ; Sun, 12 Feb 2023 03:20:27 +0000 (UTC) X-FDA: 80457186894.24.F270FFC Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf19.hostedemail.com (Postfix) with ESMTP id 6AD881A0005 for ; Sun, 12 Feb 2023 03:20:25 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=j8Ffzjjf; spf=pass (imf19.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676172025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jV1+eUp6/la6bHJXVKZFSm553P2HVk0e+WKQfNoEdNc=; b=zo/O8Bm/zUrsa8QudgEuVjG9kiF3rWYR54CczflBoobegdEMKS69BmrroR4oYX7niSJz/s Ipe1n/k84y7jG79c/3n8PlHX4Dzxgzn/a8U10xhcWgxfeIjxtO6geAIueTa+22tl5irzlW pO0ArofxSGtizHkF+/zQAY9cV/zcTHA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=j8Ffzjjf; spf=pass (imf19.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676172025; a=rsa-sha256; cv=none; b=Ajj1oOjP7vfGq/qpNaoShZmMAvayQTqIAeGiZIoPWQ7cw94HPpk4ASOTZXymL5wCUCQXX3 G9YkHwwwBmkSEFd1vgHfnQYWQTK99oTCbLZaMc3DPNlwgSXON/9hK/b3go/LLN6pn3LgX3 LoeJkFRA8fAG3794JmZ6tNliCxV2I4Q= Received: by mail-qv1-f50.google.com with SMTP id k28so6358058qve.5 for ; Sat, 11 Feb 2023 19:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1676172024; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jV1+eUp6/la6bHJXVKZFSm553P2HVk0e+WKQfNoEdNc=; b=j8FfzjjffbHe996BSSizWFQR8U1LbnObkHS0KW8Sxe+1TLrVLo8zfGGQInnU6xhzbH gMukGPH+cudoOQUyCtBPxH09ZU2QkK/nJH8ttz5+m/XxBZSzTkAF4Ap4BYSEh5CyWXu5 Oapp+5NFd6/X03kKRS+eEcIGQbsuVSOR0T6TXsKtH1llkFVNF2hbgFGkDXAYC3CUbScz uMe/G49BgtdoBhJd/CQtnIiXZwA9o8VLDw6QjV16jK+tWqv8k8XLX8azqyCTZjqVm4rG N41ZuE+xIPxbYbnKDnOYkXcT+j/J6svp22SBMNzQA2X2XCNnyzisAN4pmaKROvaZqJ5G VvlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676172024; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jV1+eUp6/la6bHJXVKZFSm553P2HVk0e+WKQfNoEdNc=; b=4WmNl3ECJo0s9wdI6bAc8dg7vQhLE46Gfjm66dteDwChQITn04M/i49Bdal6sQ5CaB 02bpAZFdy4vaTamATTPp0EHKau2A0wDJ46jQ2OtsPwBFwcFeIF9IXRcCvPy4VM3m1KL9 3D93PEog/3I6p8VFGB4rF3g+hlSHH1luI2x0OTJeZROCWg05QpdvMmozcJohUvbjlQy+ 3pfiYbVVLMjdqiNeqDq1+w1KMi+xMp+tXqUbVf3iQpPIOwdTKBMQkAYNs7R9cor0Jniw d5dWViiLc37d0H98jfFplWpo23NDmqQxYcJlfqNINfWUdfXKcZPXCzq7amnnVBeX7joA 85vA== X-Gm-Message-State: AO0yUKWqWdmTtWvl85Ee+ToKjFa+rv6yrL4cbMeSuiAUJUw7L+E9UdTl GmjVF3E4aXNlHX5DO4ha3/FO7Bq2gHHjdDBOBEo= X-Google-Smtp-Source: AK7set9FOLosm1uHLls6cm+ufXyr97cSU/KvUyJyDOaMrnKJORlpTgb//i4VEJg64RftXvO3KX+HEdzTDo0amEJz+vU= X-Received: by 2002:a0c:e003:0:b0:56c:f4:989a with SMTP id j3-20020a0ce003000000b0056c00f4989amr2018254qvk.64.1676172024552; Sat, 11 Feb 2023 19:20:24 -0800 (PST) MIME-Version: 1.0 References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> <08e1c9d0-376f-d669-6fe8-559b2fbc2f2b@efficios.com> <20230211165120.byivmbfhwyegiyae@airbuntu> In-Reply-To: <20230211165120.byivmbfhwyegiyae@airbuntu> From: Yafang Shao Date: Sun, 12 Feb 2023 11:19:48 +0800 Message-ID: Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN To: Qais Yousef Cc: Kajetan Puchalski , Mathieu Desnoyers , John Stultz , Alexei Starovoitov , Andrew Morton , Network Development , bpf , "linux-perf-use." , Linux-Fsdevel , linux-mm , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko , David Hildenbrand , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Steven Rostedt , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek , Lukasz Luba , Qais Yousef , Daniele Di Proietto Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: butm8pghjtuydauh76mpdm5k9im434qb X-Rspam-User: X-Rspamd-Queue-Id: 6AD881A0005 X-Rspamd-Server: rspam06 X-HE-Tag: 1676172025-393951 X-HE-Meta: U2FsdGVkX1/oIUtcpz1Pz3qAUG1mvEKSXhJd9k/x7LIKUZ27zJOppz6iWfGsk1HIaJXXF3EpXmbhdOYGwXewN7f3hN4gEJJ/0aL3MX3pcgqO+aW2+n7D5B07ysmu3oExRUuQSC1R5FP+T3TfBpsM1tx4Sq+rE+Fd8xXpnp5SO1dzLo/v4rBtyhWGURMnSMQ5YTQJHkDQ08kTr1+TFGMCbOTpo+S7oQ7MpAcTdlcRlTlR9HRgo7q5gG7+WLnR6s4vPjA2PaauIakFQT+/DB7f935wZc7fylc+mPc+cWLRNLmwVoso3a5O/h4TXVRLOHtkaPuYOUu5WV1gX5BrTmMCnpGk9HUe/lm4+4r7s5jfguTj9kgHxp4mOwTrd0RRU0eWXyQkWgdTsva4FSpbj1PWstOIrElkrC1S+G1xA1+CBlVCqLSmS0Qgoo9UV27JvOCJ2IOOydUtil3fUT2bknQRjD8r1y8YQP8sbGTUeuhAXPjE32LWs069FKWc+y45GXB8cQLYS79nw325vDFIbnpwhY/iyoUrmR+/K0ahTT+aAGpyxDz1pRatQFdTOAZ/7gi71M3ccEnnGgTHjiiaHip/IDhsWIeML5mB+RR5JTL8LUMfpjvxtcfOlpe2c+jzthdalUeW37uaCMc6PSKsuNRffUetvtBAwn+G1lj0YWHx3EHh0J7UkhgZwojOqmIq+6qBiiCDgHdQxbojHN2GR7IYO1RhyQGP4L2UYioj9Xe3xuymHp2Z/kKDNdeDlfqhE02i+HFg39RBxGxCiaefQF6g0LhoaV9eYf7U2bO9zUOk6k2Bs4KCVrrwzabw0E9BwNxXSx7UFgtC3DHTKuqjCJ3hhNarK9Q26yw28/3+oGRtngHWWIiaRvqU/ysaGcGLbeTeJQ+cpgRY2qwwXdoi4NfY3Ted1W9byg5PlH8PAbPbzit7coTMTfn0px3gdIiDOv8FZ/0MnZqDMpEGQk4fe8A t518I/UU mf3Xafsp3Xs7DngoonElq7+x+5vxdLpcFSWFAWqlcV+onz6s1NryIgE6DQ+GrmndDABu96Lji/Jqe1drthzgrPu8/7E8awi9xJc0RcG2ZKDNRv5NtvCRtouJUkZYKodnkH1raT8UCcaFMNpP+F5zjpq1GjHmvQ+0Ovb6N0gMJc0VlbScyOSBA4sS4L/HN183OvfqwwBk1h/Y/AdGoLLIcR2CSbxmCLNY/naimnuYOLaWSLOKtEEBu7ZBz67SFrk4Kv+GfLlTOZoFZasiEIojtu1GhKkgIR4RZ6hr9EoovBGP9QALS8mV43Nn94KhkQoeCP8+7jfoJVhP/16j9W0NhWbM2IQi0dtBx7sr7EnKoqhE2cMGF0s/JX+CXcc0UBI8FXqxayK7o0tBWxu+kuVmLOl0cG+VwWzG0j5x2TWOY6aVFWSarPjftnYjXYILJfJIPjPQGShqoPvQyvZ7PRpD+okwHX0BB95c2OKtvCh6BQmEGf4n220C5JENRluc5Ux1RoGk3FY8sRGqJntO9xMCJekkQVxXracGrBxtB/J5hKUVTJK/L9NfRqJPL9WHFslhJHdeUo2tyFa0acoBW+axVqm05kB20Yx1IG+kq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 12, 2023 at 12:51 AM Qais Yousef wrote: > > On 02/09/23 23:37, Yafang Shao wrote: > > On Thu, Feb 9, 2023 at 10:28 PM Kajetan Puchalski > > wrote: > > > > > > On Thu, Feb 09, 2023 at 02:20:36PM +0800, Yafang Shao wrote: > > > > > > [...] > > > > > > Hi Yafang, > > > > > > > Many thanks for the detailed analysis. Seems it can work. > > > > > > > > Hi John, > > > > > > > > Could you pls. try the attached fix ? I have verified it in my test env. > > > > > > I tested the patch on my environment where I found the issue with newer > > > kernels + older Perfetto. The patch does improve things so that's nice. > > > > Thanks for the test. I don't have Perfetto in hand, so I haven't > > verify Perfetto. > > FWIW, perfetto is not android specific and can run on normal linux distro setup > (which I do but haven't noticed this breakage). > > It's easy to download the latest release (including for android though I never > tried that) from github > > https://github.com/google/perfetto/releases > Thanks for the information. I will try to run it on my test env. I suspect the "systrace_parse_failure" error is caused by the field we introduced into struct ftrace_event_field in the proposed patch, but I haven't taken a deep look at the perfetto src code yet. > Kajetan might try to see if he can pick the latest version which IIUC contains > a workaround. > > If this simple patch can be tweaked to make it work again against older > versions that'd be nice though. > > HTH. > > > Cheers > > -- > Qais Yousef -- Regards Yafang