From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC92C433E3 for ; Thu, 16 Jul 2020 03:19:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 766EB2076C for ; Thu, 16 Jul 2020 03:19:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ChXd0Ebn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 766EB2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E54326B0007; Wed, 15 Jul 2020 23:19:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDD648D0002; Wed, 15 Jul 2020 23:19:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA4006B0023; Wed, 15 Jul 2020 23:19:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id B1E656B0007 for ; Wed, 15 Jul 2020 23:19:22 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 02E502DFA for ; Thu, 16 Jul 2020 03:19:22 +0000 (UTC) X-FDA: 77042483364.08.suit23_270a77526efe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id D339F1819E798 for ; Thu, 16 Jul 2020 03:19:21 +0000 (UTC) X-HE-Tag: suit23_270a77526efe X-Filterd-Recvd-Size: 7841 Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jul 2020 03:19:21 +0000 (UTC) Received: by mail-io1-f68.google.com with SMTP id v8so4567742iox.2 for ; Wed, 15 Jul 2020 20:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hnZOL6HRqScQnYHTHjj8Lsq7JLhMkooWzCSxNal6lJg=; b=ChXd0EbnTGIYNSJ4QMMTQkoXexH8r/VaQw4m2Uo3H4eoG69eUJKMaoi6tbBn0zMzev mYLkKxah5c18A8N2icjH3YYRg1IKfLwoRc3uDjfMuhdIl0/DbKTkKB0KGHzRE0hvEVNQ 3JoU9S2ibRhJlcaORQIU/9xthgJHkzV3Fqby19y0MWafr2+GMkK/ly63JljsUFyX9lfr NlKnqmySE+Zzsmaw5QMuKJHcDGPzW4/YWVNq/7LMZz+tRyZghq6WEx8PvTUtsefLcNTR QuUbpdYfg3WEoLViEchqhOIKxK1EKmLzCRg9TPbAMQVGpzHuxtlwzylTI21tmesdCODX NfSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hnZOL6HRqScQnYHTHjj8Lsq7JLhMkooWzCSxNal6lJg=; b=NneXXjPEZOUsPyTcqdi2PyNWW1cUtSTQ25Q9QJMAH2TrPsnr8pn0kaY0itG263dWAE UR9bQVpQrNymydOkMNtSH5oBaFQlxMcL3pjEFl9MuoomskrpAOwe0iTY3XRQVpOL6zDO 6QdPYNFxp6M+IOD7g2LD1/BvVM7W1nYkcH46bbGVnNzgQXbRnb607gJFYjv6RhYvgxDB JVJqIlkMk0VXpn47vQqVQNbmSFDK7AHyDbzrELO+jQBF/NJv8jUJgTktmAumZUAFWzKv t5pvHk6MLCWYWIcJXc5ucB4SirmsAymhH3mRsQk1sMp+z+E7JveUq0ZB1FgA8q6Bg6f7 Vn8w== X-Gm-Message-State: AOAM530nGft0Nx8A25r28P3z5cP/bYMVwbuIwM+z6+yieTvHPyMclmOM 7FNdbeSDtKJ5u6GqI2krOGQBq7R2WnVkfoxCZc4= X-Google-Smtp-Source: ABdhPJykR1pPQktU6DP4xptM8uEyTeohejJ218u/CEGWCWchdeOMVNbjY5zKD2r8UwquIQt7p4UfGUYGyWe20LRC7kg= X-Received: by 2002:a02:a797:: with SMTP id e23mr2800056jaj.81.1594869560712; Wed, 15 Jul 2020 20:19:20 -0700 (PDT) MIME-Version: 1.0 References: <1585649077-10896-1-git-send-email-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Thu, 16 Jul 2020 11:18:44 +0800 Message-ID: Subject: Re: [PATCH v2 0/2] psi: enhance psi with the help of ebpf To: Shakeel Butt Cc: Johannes Weiner , "Peter Zijlstra (Intel)" , Andrew Morton , Linux MM , "open list:BLOCK LAYER" , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D339F1819E798 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 16, 2020 at 12:36 AM Shakeel Butt wrote: > > Hi Yafang, > > On Tue, Mar 31, 2020 at 3:05 AM Yafang Shao wrote: > > > > PSI gives us a powerful way to anaylze memory pressure issue, but we can > > make it more powerful with the help of tracepoint, kprobe, ebpf and etc. > > Especially with ebpf we can flexiblely get more details of the memory > > pressure. > > > > In orderc to achieve this goal, a new parameter is added into > > psi_memstall_{enter, leave}, which indicates the specific type of a > > memstall. There're totally ten memstalls by now, > > MEMSTALL_KSWAPD > > MEMSTALL_RECLAIM_DIRECT > > MEMSTALL_RECLAIM_MEMCG > > MEMSTALL_RECLAIM_HIGH > > MEMSTALL_KCOMPACTD > > MEMSTALL_COMPACT > > MEMSTALL_WORKINGSET_REFAULT > > MEMSTALL_WORKINGSET_THRASH > > MEMSTALL_MEMDELAY > > MEMSTALL_SWAPIO > > With the help of kprobe or tracepoint to trace this newly added agument we > > can know which type of memstall it is and then do corresponding > > improvement. I can also help us to analyze the latency spike caused by > > memory pressure. > > > > But note that we can't use it to build memory pressure for a specific type > > of memstall, e.g. memcg pressure, compaction pressure and etc, because it > > doesn't implement various types of task->in_memstall, e.g. > > task->in_memcgstall, task->in_compactionstall and etc. > > > > Although there're already some tracepoints can help us to achieve this > > goal, e.g. > > vmscan:mm_vmscan_kswapd_{wake, sleep} > > vmscan:mm_vmscan_direct_reclaim_{begin, end} > > vmscan:mm_vmscan_memcg_reclaim_{begin, end} > > /* no tracepoint for memcg high reclaim*/ > > compcation:mm_compaction_kcompactd_{wake, sleep} > > compcation:mm_compaction_begin_{begin, end} > > /* no tracepoint for workingset refault */ > > /* no tracepoint for workingset thrashing */ > > /* no tracepoint for use memdelay */ > > /* no tracepoint for swapio */ > > but psi_memstall_{enter, leave} gives us a unified entrance for all > > types of memstall and we don't need to add many begin and end tracepoints > > that hasn't been implemented yet. > > > > Patch #2 gives us an example of how to use it with ebpf. With the help of > > ebpf we can trace a specific task, application, container and etc. It also > > can help us to analyze the spread of latencies and whether they were > > clustered at a point of time or spread out over long periods of time. > > > > To summarize, with the pressure data in /proc/pressure/memroy we know that > > the system is under memory pressure, and then with the newly added tracing > > facility in this patchset we can get the reason of this memory pressure, > > and then thinks about how to make the change. > > The workflow can be illustrated as bellow. > > > > REASON ACTION > > | compcation | improve compcation | > > | vmscan | improve vmscan | > > Memory pressure -| workingset | improve workingset | > > | etc | ... | > > > > I have not looked at the patch series in detail but I wanted to get > your thoughts if it is possible to achieve what I am trying to do with > this patch series. > > At the moment I am only interested in global reclaim and I wanted to > enable alerts like "alert if there is process stuck in global reclaim > for x seconds in last y seconds window" or "alert if all the processes > are stuck in global reclaim for some z seconds". > > I see that using this series I can identify global reclaim but I am > wondering if alert or notifications are possible. Android is using psi > monitors for such alerts but it does not use cgroups, so, most of the > memstalls are related to global reclaim stall. For cgroup environment, > do we need for add support to psi monitor similar to this patch > series? > Hi Shakeel, We use the PSI tracepoints in our kernel to analyze the individual latency caused by memory pressure, but the PSI tracepoints are implemented with a new version as bellow: trace_psi_memstall_enter(_RET_IP_); trace_psi_memstall_leave(_RET_IP_); And then using the _RET_IP_ to identify the specific PSI type. If the _RET_IP_ is at try_to_free_mem_cgroup_pages(), then it means the pressure caused by the memory cgroup, IOW, the limit of memcg is reached and it has to do memcg reclaim. Otherwise we can consider it as global memory pressure. try_to_free_mem_cgroup_pages psi_memstall_enter if (static_branch_likely(&psi_disabled)) return; *flags = current->in_memstall; if (*flags) return; trace_psi_memstall_enter(_RET_IP_); <<<<< memcg pressure -- Thanks Yafang