From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 788A7C10F29 for ; Mon, 16 Mar 2020 01:49:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 24C09206BE for ; Mon, 16 Mar 2020 01:49:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Anh/jF7O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24C09206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A74E36B0003; Sun, 15 Mar 2020 21:49:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A25C96B0005; Sun, 15 Mar 2020 21:49:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93A646B0007; Sun, 15 Mar 2020 21:49:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 78C866B0003 for ; Sun, 15 Mar 2020 21:49:27 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3022E181AC9C6 for ; Mon, 16 Mar 2020 01:49:27 +0000 (UTC) X-FDA: 76599543174.29.noise71_356542dfa6b27 X-HE-Tag: noise71_356542dfa6b27 X-Filterd-Recvd-Size: 3635 Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 01:49:26 +0000 (UTC) Received: by mail-io1-f67.google.com with SMTP id q128so15535279iof.9 for ; Sun, 15 Mar 2020 18:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yoq2dm2wMdYmvERBny9tE6W3gD6b5KdDrVUkIqFMrbk=; b=Anh/jF7OcNxqH4rjeyCa4ugaeVhHAk1PRwDAFHIDH87cC7icS4Rn5glt3z4HIV7z1p sopw9Y9rvRapYILcvn8hq/10UEfcMqBryRSpfYlpRwKl2WaSvvB2/uElI2xkI5pklANR KFtkr62yG/Pm7zOFMa0cWMV9YhkdzVGD/BNA7KZFVzRX0+A0S61FsmYb1BAjqxQY5FqJ wycmJ4pqctxLUNeHwwHCdRsuDT9ZpQyzW0nSDmiTfkSpZ8/WlUj1KftmaRDF7gVuLrad 3RgeWTHHR2xqbhdOKuwWmkmVtQr0hBKAqoiSS1+2G3Bdbg55Oz5MCHBVUct+L600MgkL CSYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yoq2dm2wMdYmvERBny9tE6W3gD6b5KdDrVUkIqFMrbk=; b=GjXCcAavDTF+Gic5t3msIaMcvwy4+Ci86RlUIXlVBrGNZaX8ahNNFCKKIiCooxyYg+ xpe/+njNxrGHSSNn2UsonWfbnhRwjHToBF1LssgKNo9YC+oj+rPh18udBeDcoqdPRYHJ TROv+8XNDEYmHYjbdeYInYAFdLvvxoRQ5h6QB/y75INXaLihBZMabUPgyL3DByNYYc5B VvaWajUK26Aj9sq7F4aHAMZRc+M1YBa+n/Me5IyjcIB9MUHRZn6YMYTR407HOSQJ3THV gl0x7sJhh/WsF7Fq9cHRbacbm79qETPK110Y8AirKQAFs2uT+fJARydj4Ib+MaXzhCDL DwZA== X-Gm-Message-State: ANhLgQ35wS93IOuyqLksr3pV+hwoISiu7BDiEHk9bzugb+W3nVwAC7FF mJVoHsgQLOoPq03Yr82/fSKhWSlIVj2qk92/wUk= X-Google-Smtp-Source: ADFU+vu4geqTV/LsCUJBg68QI3uBOWcuDWuhDYh1Th68uei++Exp9g0SEYeh9cAewcwPcjtzLCXmrGEP8H9Vv5FZWjI= X-Received: by 2002:a02:c7cd:: with SMTP id s13mr8356495jao.81.1584323366115; Sun, 15 Mar 2020 18:49:26 -0700 (PDT) MIME-Version: 1.0 References: <20200315095342.10178-1-laoar.shao@gmail.com> <20200315095342.10178-2-laoar.shao@gmail.com> <20200315160332.GW22433@bombadil.infradead.org> In-Reply-To: <20200315160332.GW22433@bombadil.infradead.org> From: Yafang Shao Date: Mon, 16 Mar 2020 09:48:50 +0800 Message-ID: Subject: Re: [PATCH v5 1/3] mm, list_lru: make memcg visible to lru walker isolation function To: Matthew Wilcox Cc: Dave Chinner , Johannes Weiner , Michal Hocko , Vladimir Davydov , Roman Gushchin , Andrew Morton , Al Viro , Linux MM , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000106, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 12:03 AM Matthew Wilcox wrote: > > On Sun, Mar 15, 2020 at 05:53:40AM -0400, Yafang Shao wrote: > > +#define for_each_mem_cgroup_tree(iter, root) \ > > + for (iter = mem_cgroup_iter(root, NULL, NULL); \ > > + iter != NULL; \ > > + iter = mem_cgroup_iter(root, iter, NULL)) > [...] > > +#define for_each_mem_cgroup_tree(iter) \ > > + for (iter = NULL; iter; ) > > + > > That's not the same signature ... for_each_mem_cgroup_tree() isn't used when CONFIG_MEMCG is not set, so should remove it. Thanks for pointing it out! -- Yafang Shao DiDi