From: Yafang Shao <laoar.shao@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Dave Chinner <dchinner@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Roman Gushchin <guro@fb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>, Linux MM <linux-mm@kvack.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] mm, list_lru: make memcg visible to lru walker isolation function
Date: Mon, 16 Mar 2020 09:48:50 +0800 [thread overview]
Message-ID: <CALOAHbBEt1wBe8hTk8c=WA0ZeDinH2bVZZtCwvv=qFG-8i6p1g@mail.gmail.com> (raw)
In-Reply-To: <20200315160332.GW22433@bombadil.infradead.org>
On Mon, Mar 16, 2020 at 12:03 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Sun, Mar 15, 2020 at 05:53:40AM -0400, Yafang Shao wrote:
> > +#define for_each_mem_cgroup_tree(iter, root) \
> > + for (iter = mem_cgroup_iter(root, NULL, NULL); \
> > + iter != NULL; \
> > + iter = mem_cgroup_iter(root, iter, NULL))
> [...]
> > +#define for_each_mem_cgroup_tree(iter) \
> > + for (iter = NULL; iter; )
> > +
>
> That's not the same signature ...
for_each_mem_cgroup_tree() isn't used when CONFIG_MEMCG is not set, so
should remove it.
Thanks for pointing it out!
--
Yafang Shao
DiDi
next prev parent reply other threads:[~2020-03-16 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 9:53 [PATCH v5 0/3] protect page cache from freeing inode Yafang Shao
2020-03-15 9:53 ` [PATCH v5 1/3] mm, list_lru: make memcg visible to lru walker isolation function Yafang Shao
2020-03-15 16:03 ` Matthew Wilcox
2020-03-16 1:48 ` Yafang Shao [this message]
2020-03-15 9:53 ` [PATCH v5 2/3] mm, shrinker: make memcg low reclaim " Yafang Shao
2020-03-15 9:53 ` [PATCH v5 3/3] inode: protect page cache from freeing inode Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbBEt1wBe8hTk8c=WA0ZeDinH2bVZZtCwvv=qFG-8i6p1g@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dchinner@redhat.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox