From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C86DC54FAA for ; Wed, 28 Aug 2024 12:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA8D66B008C; Wed, 28 Aug 2024 08:59:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E58F26B0092; Wed, 28 Aug 2024 08:59:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D21F86B0093; Wed, 28 Aug 2024 08:59:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B2C626B008C for ; Wed, 28 Aug 2024 08:59:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 61CA4A1FDB for ; Wed, 28 Aug 2024 12:59:03 +0000 (UTC) X-FDA: 82501659366.26.4A86E47 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 8944A100003 for ; Wed, 28 Aug 2024 12:59:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="LID/2bRb"; spf=pass (imf14.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.161.53 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724849854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pH7WFnf9Z5U9s40gHaojKFntzdW0wQvoSDRbtMTVsPI=; b=IGxkvHThCyom6ZxqbPA+SKuwwbEvsZXRlVw//bq+JYLUVebPK5aBWaCP0mf8G/50QWN32e 71pE40lOXQwxWumznOFfKEgZRApnyvNXGM0QSB1oRGWgVxkh/vs2nXVZ1VKxShPRO5+f5I K1raIhYynVdIPHG2Uh8tUusx88xNhBE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724849854; a=rsa-sha256; cv=none; b=meC+kyp9LBADzp8W730Q+MnM02ZuAzR7x/yzv1DgceZ5/DEpzASg5EOlYCZ6W8g8m5cz+r YEsi2/Sa4MUPDV2CxTIrArJ1EDuDodh0YPjsSSCDIB2NH2DcdUR/363CU2HQDYBcHzgnJF atnjlHV5alv7C8MNC+kfRTiAQiLPtxg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="LID/2bRb"; spf=pass (imf14.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.161.53 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5d5eec95a74so4238343eaf.1 for ; Wed, 28 Aug 2024 05:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724849940; x=1725454740; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pH7WFnf9Z5U9s40gHaojKFntzdW0wQvoSDRbtMTVsPI=; b=LID/2bRbeF4XtzTwkwM7c7WvwoDB/r8xlmCZMSVmh7lnretkK5Z63/5FasbstRhg/U tXjKRSgyP+Cy/5DAmqx+dm49jIRdbXmuUFBwU2Wgv6uLOLqdFNV+cYdGQf/utk9AiKFi LigPfBdeyuTlTC/C7L69ZuKR7k82MYzcK/b+vXhaZIxh7SxyVg+ebcJEWHuPNup0iBvN Wn2/x9qH4vd5yb34AmjsipCj5dhOQfVbkc/SB8ucGbg6ItzZpNc78nWlKRpVfM5V91lt 2+tdecYk5v87TSLWa4rqkYLgXlqqXpugVzmXKuMZXCQz7W1/a9qOECpcfrDFG45bVQLy V2jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724849940; x=1725454740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pH7WFnf9Z5U9s40gHaojKFntzdW0wQvoSDRbtMTVsPI=; b=KFWGAKa2S3LRIqJrK6XVJRK2CCbqCvNushkSimcZwYgvpSYRsxsgF6sWW+91et2O7j lcCbIsfcvnuiqJ/T76yX6aTvyj54J+P5Cm5pTFLerUDuQfWYHt7YuWx+ZRYpenvfjBdl gTILmDO28Z8g4Xj3YhqD9D9WBTTuzw/wsPajVaf7Wn3VpCTVMrKCz0LkAeykCwmMuL6i CDzfDJamQCI9/cm0aBbh/HIu5HevRBsOF4o7SCSC39jdkCIP6YJT0coA/NWcAMUkeeww mzjEHuU8KB35ow/QBJ8RDoDcIH/RLwgT0o1JtzLWz3VrRbBz/5GN9+x5miAEs01hmtID OVVw== X-Forwarded-Encrypted: i=1; AJvYcCVLfGPlx2oc1nVmH9l9cmL7Zqpd2/TvKiZ9tOaMV3J/vxgXxXw/UEwqU35P62r8wR6yWWIBsStvTw==@kvack.org X-Gm-Message-State: AOJu0YyPoR/V9z3mpJwhvqwP0KCf+XExcWXtq6TP5VmuwdHCzEqaOKRj ngd67iMDF6GX5BbgvKiUE28ISx/tT5Y5xC579EEhPs1bdC9GtoqKU0jYdULr+VQlOX98TYSsVy9 n5B3A+RHV+SWh6duyAamNrzKoyAk= X-Google-Smtp-Source: AGHT+IH+dDHakcMPvkuKOsY8mULW4jaimlsccjCHmLOHF71l0LdgzI569jfkq53KV+Wjzqed0wUcjeuwQ65gQxSdFXk= X-Received: by 2002:a05:6820:1611:b0:5df:8577:e7b with SMTP id 006d021491bc7-5df857711e2mr1981136eaf.0.1724849940444; Wed, 28 Aug 2024 05:59:00 -0700 (PDT) MIME-Version: 1.0 References: <20240828030321.20688-1-laoar.shao@gmail.com> <20240828030321.20688-7-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Wed, 28 Aug 2024 20:58:14 +0800 Message-ID: Subject: Re: [PATCH v8 6/8] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} To: Alejandro Colomar Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, justinstitt@google.com, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Simon Horman , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8944A100003 X-Stat-Signature: o5mmjrs7aoo6h6b8ftuobx9opf11sq3w X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724849941-156931 X-HE-Meta: U2FsdGVkX1++DwlsyRTKhKpuWRu+xNZYq5NestgqLhCBGgNB6G3mb+IzfEvzpHU5v58mcRozx3uY/ZZxtByZRA1Z1TaJyTsCAWm/rmZhqB53gcQVMWtQvUEBXo1E8AOe5gAD/uHg8xnvugzMwjzfj1gicojKeqq58aaxIWLEkla5Rgqmvbsqmhr1zIDbZEbAvdEWnX8+XGWp0nJvxBolVMqz/RDpWEQZbPL4WAD5xYkMIPpIADCNsR88DQJebf5wD6AbKomFP6+gt4nYssxa7MRlf19f/hXCGM/HZxEna0MsBrX02OqWN3eJ44BGGvyrRo1YmkJTzG8ndOFWrHYyQa1lYoueaXFbAH9UPOAYXVjlzHNxqps/IullVmj06qbi7qytigHnTSu5LmnI1nn4L3x9EhgWrOF0J+B5evNWNBNS2TKeddVOyyZbMqDTfTe+SyO41RJCkbXz+TxQWMZWu7z4ona+Jow3c3MX7zoNIk6U7fgGJKo1hndRuEGawiyZc4cb2IxYF9c5pZ71ZCBYw+wXbl7qmv1CsVqLpf2eCHl1gOpoYdGqxiwmzn53eeT4A5WG/xA42+AQivnAOy/V/7SW4dAtkU4bTOwIQqH1lE4Rlgy8yIKSYB491T8cjFyt3/U32sYNa1tC16p3qzxEqYtGGNZumwgQjrpJpg3DFg9McYcWs/5wTO8ZJ9fdJtomw3aLVvgZv1orTKUJFt5/VFtE32fY8Dp10ZX5qlHjKax7VG4iTH1zMC54Mp13mqzvrdLruiIxyn5cibmHfOolbPxbU8Li5VUy5VxNMnmsD+nozsha+t8NpYY3GB9t2KwTGBmu7UK4FKosz/rzFhXYt6PbAtN9nymWXf8v9KzkchOcpWPofubDopkw9crnuDddnewYSAo6ZioRvr4EMhJGmIBuXYXIfEqH+WTfRER/5KsN0ttGN3VqKOptZf4g8BPK3hhU8W0+FbZLjNRUDFJ dzsvCv6n IZmEbIh1vC9skuLKEPrpsSsSIkEV4mKQ/BEwsnwHQHfCzQYX3ZFXocx1WLIz/uzstfkKR3IvFsAa2J3ysaggT3UUjr3Jn8gc6WLdrmwEKugnq/Y9dzMKDBaMmp0hlJJ9FTlGiv4rCTOWK2Obx5QwMl5WdOw8eNfLE9+tHC7TQ23R3RJ9mWF3Go++/97Q61dqjeHYiZreU6jjl1mA35ctvA46i5eThdENl2akrZDR+cSmjNQBYCXBQeMKbMOVrgwOQqGR2ydpuQwGIALVOGTyNcQjXk3Lyr5rR8ygScv5nSfK55FaIepEppzOxZ/LWG37oGMPEKUr0XzDQrmokaA57smFCzruMstoMGKxWrT1kQiefX10nGoY10gBeWRi3POV6Lvf1ehLrYzFj6DmgGnslLkU5SydStGs17J7rnDgL1RDP3bSgYgavEgo5M8Dkc8kTKDcP75DqCmIv9WaFNxJSt0hPqUNdwFKHifeisLxV5yVcOu3kV9UUS6MXFAtHEK4zk7Z5g4XHy/aAOSUwJQfy/ApEwQVHdd96GiR9aZh3s8906T9qBFNWRiBOzhIdjhcfSnuU4eb52JnV9+uoFpYW8o0ZWt13aazyt+ReDimP3hKeSucRLKeter5vB+cypzaN+Q/gzMNe2GD+yZnNE0VdczDPJ9aVfPzV04cb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 6:33=E2=80=AFPM Alejandro Colomar = wrote: > > On Wed, Aug 28, 2024 at 12:32:53PM GMT, Alejandro Colomar wrote: > > On Wed, Aug 28, 2024 at 11:03:19AM GMT, Yafang Shao wrote: > > > These three functions follow the same pattern. To deduplicate the cod= e, > > > let's introduce a common helper __kmemdup_nul(). > > > > > > Suggested-by: Andrew Morton > > > Signed-off-by: Yafang Shao > > > Cc: Simon Horman > > > Cc: Matthew Wilcox > > > Cc: Alejandro Colomar > > > --- > > > > Reviewed-by: Alejandro Colomar > > (Or maybe I should say > > Co-developed-by: Alejandro Colomar > Signed-off-by: Alejandro Colomar I will add it. Thanks for your help. --=20 Regards Yafang