From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F06DC54FAA for ; Wed, 28 Aug 2024 13:41:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 950016B0085; Wed, 28 Aug 2024 09:41:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FF7F6B0088; Wed, 28 Aug 2024 09:41:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C78C6B0089; Wed, 28 Aug 2024 09:41:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5EE1A6B0085 for ; Wed, 28 Aug 2024 09:41:18 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F30144201E for ; Wed, 28 Aug 2024 13:41:17 +0000 (UTC) X-FDA: 82501765794.30.511A15F Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf30.hostedemail.com (Postfix) with ESMTP id F3C3A80021 for ; Wed, 28 Aug 2024 13:41:14 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WCr30RZg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724852454; a=rsa-sha256; cv=none; b=HGpRwFaof2XsgSHJUpAwq+HRiu6jQfeoKulSrFS+WVr6ISyGdU66sJLRDoJg3CdpE6j3W6 tKRHh+f5kto3G+nGm5l7PI7414VEyHtd9nS1sKPWo5/OguptQOArmPe8l1Lu2Lh7lqrxAx yH50RvENh28Qt9ITcn/zNAVGaM6IWYs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WCr30RZg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724852454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZM22fWGyfP7pTHMrkwvXyYB2yArAZ5REiY88yMWxV58=; b=hAxyVQsUL9eNaagi20nMqF6i7i+dqZtBeceoGoZ/WTFyiy4wkkL3PRM/V9KCheX5ZAxRas rUezkIE+6jkgMlUIWjngqf4NAXefA7aETnk0Rc2YyfT2kNYbLCNLVBBqtkp/Gadm3X5tqN DskZtndSBByt/w+GsedqAlaECp+/oPU= Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6bf705959f1so6029436d6.1 for ; Wed, 28 Aug 2024 06:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724852474; x=1725457274; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZM22fWGyfP7pTHMrkwvXyYB2yArAZ5REiY88yMWxV58=; b=WCr30RZgPNwJzu5LYw/kN9R35UwJjYEjXsXIN18p84Uqk4NlAFFTxQbO+oS3arAng4 UGaa3zsamaXVTJblbxGVNA3WxKe2i0ct6oPSyNbPJ18CYfntG1TLx9dhupf8/ObiWG/i 8siExH8sWHW/tUtnFw6mhxxaxIwF59UuTBhV9jE6WYnIGyGhf8+NLyCQwR5dP6Vdsrpt fdmX/C0m8E8uM3NawQCvF619rHAzCiu4hW7tcrfDJEaLJO5EwyuSq5dIsUmfSkuXviaV XszSkWfkMtiOVWAeokowE5TEtaceoY1tgtGg4jSZbAjTR9RNYZ8HWwBzOrBW+xqTVqDD zSVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724852474; x=1725457274; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZM22fWGyfP7pTHMrkwvXyYB2yArAZ5REiY88yMWxV58=; b=S0c5r/63PYuhswY/rWD+vsblSG78Q6loB3HT4WAKWTYnmFzQ9BONVTZoql16Mdotoh Z+RSM/VNPiQe964ghKVP+wTSvo/7C+WuQtaR9FbfxW0ERWQHhTlyyrP6fne4OzdD97IP 3sGb9vKWXKuamhxygAXyHQ86Kkd2ay8cYQoBb+6g4aKqIAaabzB+TZCWYVlWBTYrieiF Yi4pfpk/sJlOpA+z7noxN0bvKVwJuiEZ5eRaXuO7MvhfV0e0ZxqOFvbHh/0Px93OZdHp fSsVIH7ACVSLTLwzGiXYlgQDydZt49rbhhbJIAE3nsyv5TDIn7QX5WjSeNO3mev7dm05 znvw== X-Forwarded-Encrypted: i=1; AJvYcCVUJUZQumfmNIcvA9RWCoTKf6XewI4J49FRlOFn3fmuhGRPxooly30AYrGq7/WicYSvPOY1Somg/w==@kvack.org X-Gm-Message-State: AOJu0Yw1lLBIDI13M+fet2UrO69nJyPJf1RBTKL2hgRA9G2JAvXgreqm jLy9YlyxL+DBSJqA2N8vpoZUyrwhdpmxzi5LXNIXZ7tTESb8vygfWUuxXegHonP422yBRnomrtk 0ELKRsSaHuJysEI7h+A59aZ75Hto= X-Google-Smtp-Source: AGHT+IEyHFAeIj+i9dwO5uOiV3XCouo/U0KX68AiGeUIHgmLKbuZ6ld4KcpgR5tcN/ds4tOwYEpli4MYtWggh3QrvFs= X-Received: by 2002:a05:6214:448e:b0:6c1:84ce:8f31 with SMTP id 6a1803df08f44-6c335c60e6emr43501846d6.0.1724852473892; Wed, 28 Aug 2024 06:41:13 -0700 (PDT) MIME-Version: 1.0 References: <20240828030321.20688-1-laoar.shao@gmail.com> <20240828030321.20688-2-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Wed, 28 Aug 2024 21:40:35 +0800 Message-ID: Subject: Re: [PATCH v8 1/8] Get rid of __get_task_comm() To: Alejandro Colomar Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, justinstitt@google.com, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Matus Jokay , "Serge E. Hallyn" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: F3C3A80021 X-Rspamd-Server: rspam01 X-Stat-Signature: cj5jn9o1f37aru785ueajxaj48trkuno X-HE-Tag: 1724852474-721939 X-HE-Meta: U2FsdGVkX18ii4JVs2kNYcNIEUwwLTQfZemni0JsJsFPQ7PAF1oELCkedgpnUytLuE47se0v6uOYoi+AK7H0ilZdGBNgpKy7AdgFPZ0gFpJnaVFHNTb9tZXGetqKV+2iHmH82ahRzdzA+XkcKVGC2yPKciv3z1//61mX5z1uOePyrGvCmbrO5kLIFRWKTtoJtbk6D57WEnj+u1VsQMbgwe9gFoXgx1j4xeycTt5LeVewArxSCaTcrrDb1qQFCNDr+3aKni8O80EYeHGFB42v+hD+tiwQHyKm9xONi/jAuj7aLNB6pN6TCDQ0O4oq5IYGRd+zP+ZFCzILnKDyLreaKvGl+fTlqNhiOtoZWzRq9d7kr5/CD3HASyUBbJAMpYwH8ITdki+iNrh3lCURZ+fVjY1Y9LBBQdvPeTcuNNkslR4GVA6bJWpMjpWo0IaqngtQfQ2l9tD9NExhn0NtlJrP8UITuryhamwlC1TdHY8g9OCLhzw7zcv1vLI9YF6ngRkujsDdQILdnP57bIhTHy71pvB5xv2e/l6e07alZAZB5CQPEaviaDeIJOlDn0j5W6YsvxLm2FkbMn63y9YfScUA4vDhOutg4H+4ZN18qRu7KzcLZfNLjQVX3hlySTsTCDndOzPxWwkLfiZMJulJP0FvqahuKdRcj4qPHfyzMitck4z94vOeoPBtQGJCuYyUBPh2PAAZp8J0QHyYGTQbhGpHP3sTTwvJuNT8IdiLNmY33dEm/F++KsirlXCeNqm2JydKbm4K50olWJRSqKevZfU1ZhtduhCqWcVX79UGx9ZftOpwdSd8aUFFZ67Z13EZUYrl7aJaIbCn+nbCAKU/QL80/89c/5TUmBpZs6QD28aFfxjMp+mpK7mMEjEi0rop+uff60hBfamrVPOdXpWgg7lB3g/j5Jt1tdLrgfNnOT3Tfl3BfIyVqiYTbobfr3wzID7kt5krnBOf60/ELuHULpj m2fz95BO JLqS+cpZNaSghDOKS9OiScXa6Ze2piLFv5Oruo/dd/S0Cgl+amOqyoKQj45acLSkA4pOeQqDQo7LxxnGMcYL3RXeaV3MzfFxbgFaAz6rke2Qs3IhS0OrmU0keX7cRLH7QwzkLFa5u/Czh9G4fhKPICdDqKbuIh/xr7lg9cpR5dGgylbNtahN4RqFUF90Qf6d6489gU5eFS/sx/Zmt9nMmN7IxkOPAjrLW9FJTr/FkYefprSVlQfdn8lvVunn9365vB9ZKF9tayQNDI02RWufeLba+kd9nO1CFm7YVgRY9pSpuaTIJtJ9WpKIAIVn8OuJmDtaL7g66ykqdDh29KiF5qoKI3ANreGSbz9mIJCtycUpkb0x4X0aRBuTMZBN7idQ8tSNXoRvedOvB4TOU1b0R6T366BhpJj/SHbUkDTmrxrIJni8jXAngI8uLHn4RrT3Ka6Sf+0EtNrlbd8Pl6uGUn+D2TzSFnUWNxmTqF7AHIHStG4mZjsnrYMZ3ACKH9UeIDEOyPt3DB8GyYpQpVQTAM44FR6mVVHpKHd0qetpqmMW5v8NqDBAnyFy0lvgoNaJqHWmTFzrIlvSHPvMr5CW3l7LLzZcPk3PinRQ0yxfKE3KRB7IdSdlVBv2wkpgDeh1P2EFTp659V6IR0qP8e/ACB7JsHMGcemTNrPVcF1HYJ7PZpORal2j2lB+4Hjai3n6dggPHmhCCmBYUg/H7qHilLwI6G9bCwOBl8S7NK51Ug2onpX+Ee+CGhsN9Ox/IMy4O8CSbdePjYsaacjvh0C/eMkEFBlrJS/S3HtJFf+7qxuH8UuIr/FC4gqLTdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 8:58=E2=80=AFPM Alejandro Colomar = wrote: > > On Wed, Aug 28, 2024 at 12:15:40PM GMT, Alejandro Colomar wrote: > > Hi Yafang, > > > > On Wed, Aug 28, 2024 at 11:03:14AM GMT, Yafang Shao wrote: > > > We want to eliminate the use of __get_task_comm() for the following > > > reasons: > > > > > > - The task_lock() is unnecessary > > > Quoted from Linus [0]: > > > : Since user space can randomly change their names anyway, using lo= cking > > > : was always wrong for readers (for writers it probably does make s= ense > > > : to have some lock - although practically speaking nobody cares th= ere > > > : either, but at least for a writer some kind of race could have > > > : long-term mixed results > > > > > > - The BUILD_BUG_ON() doesn't add any value > > > The only requirement is to ensure that the destination buffer is a = valid > > > array. > > > > > > - Zeroing is not necessary in current use cases > > > To avoid confusion, we should remove it. Moreover, not zeroing coul= d > > > potentially make it easier to uncover bugs. If the caller needs a > > > zero-padded task name, it should be explicitly handled at the call = site. > > > > > > Suggested-by: Linus Torvalds > > > Link: https://lore.kernel.org/all/CAHk-=3DwivfrF0_zvf+oj6=3D=3DSh=3D-= npJooP8chLPEfaFV0oNYTTBA@mail.gmail.com [0] > > > Link: https://lore.kernel.org/all/CAHk-=3DwhWtUC-AjmGJveAETKOMeMFSTwK= wu99v7+b6AyHMmaDFA@mail.gmail.com/ > > > Suggested-by: Alejandro Colomar > > > Link: https://lore.kernel.org/all/2jxak5v6dfxlpbxhpm3ey7oup4g2lnr3ueu= rfbosf5wdo65dk4@srb3hsk72zwq > > > Signed-off-by: Yafang Shao > > > Cc: Alexander Viro > > > Cc: Christian Brauner > > > Cc: Jan Kara > > > Cc: Eric Biederman > > > Cc: Kees Cook > > > Cc: Alexei Starovoitov > > > Cc: Matus Jokay > > > Cc: Alejandro Colomar > > > Cc: "Serge E. Hallyn" > > > --- > > > fs/exec.c | 10 ---------- > > > fs/proc/array.c | 2 +- > > > include/linux/sched.h | 32 ++++++++++++++++++++++++++------ > > > kernel/kthread.c | 2 +- > > > 4 files changed, 28 insertions(+), 18 deletions(-) > > > > > > > [...] > > > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > > index f8d150343d42..c40b95a79d80 100644 > > > --- a/include/linux/sched.h > > > +++ b/include/linux/sched.h > > > > [...] > > > > > @@ -1914,10 +1917,27 @@ static inline void set_task_comm(struct task_= struct *tsk, const char *from) > > > __set_task_comm(tsk, from, false); > > > } > > > > > > -extern char *__get_task_comm(char *to, size_t len, struct task_struc= t *tsk); > > > +/* > > > > [...] > > > > > + * - ARRAY_SIZE() can help ensure that @buf is indeed an array. > > > + */ > > > #define get_task_comm(buf, tsk) ({ \ > > > - BUILD_BUG_ON(sizeof(buf) !=3D TASK_COMM_LEN); \ > > > - __get_task_comm(buf, sizeof(buf), tsk); \ > > > + strscpy(buf, (tsk)->comm, ARRAY_SIZE(buf)); \ > > > > I see that there's a two-argument macro > > > > #define strscpy(dst, src) sized_strscpy(dst, src, sizeof(ds= t)) > > > > which is used in patch 2/8 > > > > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > > index 6f0d6fb6523f..e4ef5e57dde9 100644 > > --- a/kernel/auditsc.c > > +++ b/kernel/auditsc.c > > @@ -2730,7 +2730,7 @@ void __audit_ptrace(struct task_struct *t) > > context->target_uid =3D task_uid(t); > > context->target_sessionid =3D audit_get_sessionid(t); > > security_task_getsecid_obj(t, &context->target_sid); > > - memcpy(context->target_comm, t->comm, TASK_COMM_LEN); > > + strscpy(context->target_comm, t->comm); > > } > > > > /** > > Ahh, the actual generic definition is in . > You could do > > diff --git i/include/linux/string.h w/include/linux/string.h > index 9edace076ddb..060504719904 100644 > --- i/include/linux/string.h > +++ w/include/linux/string.h > @@ -76,11 +76,11 @@ ssize_t sized_strscpy(char *, const char *, s= ize_t); > * known size. > */ > #define __strscpy0(dst, src, ...) \ > - sized_strscpy(dst, src, sizeof(dst) + __must_be_array(dst= )) > + sized_strscpy(dst, src, ARRAY_SIZE(dst)) > #define __strscpy1(dst, src, size) sized_strscpy(dst, src, s= ize) > > #define __strscpy_pad0(dst, src, ...) \ > - sized_strscpy_pad(dst, src, sizeof(dst) + __must_be_array= (dst)) > + sized_strscpy_pad(dst, src, ARRAY_SIZE(dst)) > #define __strscpy_pad1(dst, src, size) sized_strscpy_pad(dst, sr= c, size) > > /** Thank you for your suggestion. How does the following commit log look to you? Does it meet your expectations? string: Use ARRAY_SIZE() in strscpy() We can use ARRAY_SIZE() instead to clarify that they are regular charac= ters. Co-developed-by: Alejandro Colomar Signed-off-by: Alejandro Colomar Signed-off-by: Yafang Shao diff --git a/arch/um/include/shared/user.h b/arch/um/include/shared/user.h index bbab79c0c074..07216996e3a9 100644 --- a/arch/um/include/shared/user.h +++ b/arch/um/include/shared/user.h @@ -14,7 +14,7 @@ * copying too much infrastructure for my taste, so userspace files * get less checking than kernel files. */ -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) +#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]) + __must_be_array(x)) /* This is to get size_t and NULL */ #ifndef __UM_HOST__ @@ -60,7 +60,7 @@ static inline void print_hex_dump(const char *level, const char *prefix_str, extern int in_aton(char *str); extern size_t strlcat(char *, const char *, size_t); extern size_t sized_strscpy(char *, const char *, size_t); -#define strscpy(dst, src) sized_strscpy(dst, src, sizeof(dst)) +#define strscpy(dst, src) sized_strscpy(dst, src, ARRAY_SIZE(dst)) /* Copied from linux/compiler-gcc.h since we can't include it directly */ #define barrier() __asm__ __volatile__("": : :"memory") diff --git a/include/linux/string.h b/include/linux/string.h index 9edace076ddb..060504719904 100644 --- a/include/linux/string.h +++ b/include/linux/string.h @@ -76,11 +76,11 @@ ssize_t sized_strscpy(char *, const char *, size_t); * known size. */ #define __strscpy0(dst, src, ...) \ - sized_strscpy(dst, src, sizeof(dst) + __must_be_array(dst)) + sized_strscpy(dst, src, ARRAY_SIZE(dst)) #define __strscpy1(dst, src, size) sized_strscpy(dst, src, size) #define __strscpy_pad0(dst, src, ...) \ - sized_strscpy_pad(dst, src, sizeof(dst) + __must_be_array(dst)) + sized_strscpy_pad(dst, src, ARRAY_SIZE(dst)) #define __strscpy_pad1(dst, src, size) sized_strscpy_pad(dst, src, size) /** -- Regards Yafang