From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 692AEC433FE for ; Tue, 2 Nov 2021 13:48:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E92F660524 for ; Tue, 2 Nov 2021 13:48:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E92F660524 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 770E96B006C; Tue, 2 Nov 2021 09:48:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 720986B0071; Tue, 2 Nov 2021 09:48:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E81A6B0072; Tue, 2 Nov 2021 09:48:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 50BE36B006C for ; Tue, 2 Nov 2021 09:48:47 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ED68A18458A89 for ; Tue, 2 Nov 2021 13:48:46 +0000 (UTC) X-FDA: 78764120652.25.941A0A6 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf05.hostedemail.com (Postfix) with ESMTP id 9134E508CC8F for ; Tue, 2 Nov 2021 13:48:31 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id ay20so4346517qkb.7 for ; Tue, 02 Nov 2021 06:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wu+GXwP0q8/l280sPfS5y2dnw2tDTjbgcZxPcts0nWA=; b=YcR3IuaAtTNd5UTAQgUBmbub0s9rZKVwSQhTU6bWJJuuGdsbgVWzNuC9hWKqyxfIx3 99mns3eEXlEacdvGFsKoPPJhXuggFk/5dE5jXNf97+xm8eN7len5sSHHLvp3lWncIqzh nqpTbP+Mq8ng1LNy3wXdOjEpj+jjzNB2OP/wuFZPk0/GaFXjhxctxfJRVTWOEq2Zc+SW DNyX54rGB6MewKL70f5/ukEdoSGntFVl195Te6GLkxv8TwgbyAW3u4004JSdT9R69nCM R+qKublTKycWSta+kv7uhK7PGTiFSv2r4mma2kG4TFzwKpMJAYoo/7RA//x4Akoe3VkM BmPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wu+GXwP0q8/l280sPfS5y2dnw2tDTjbgcZxPcts0nWA=; b=KN0KjKn2o8pStQQgFcE1p8ZHk+E7e8L0zIXZo4NMThBdMfhrRqKqzK5H6dYRseT5cR xAh5gDGGz9ommpUFfqbYaI/BNnNrg7Q2COO2IRdBfMCCfkoBk1XLK7/FlbTtwditaPYl UMy5E/t3SNL4Zx+GLyAyEim5LvjeYgkUVZMjeFuxMBVfblCC7J74sMgKlIry0X2Zpeeg ij8urO+xwlGTD8dOUU8N0FcNYriUQfBG0plWPvusG2wfufZGKk5crL1vUljKGqYf0sOe 1Pxi4ryrMtiTrIEDmL50Kn2hq/TNlaNEHPenKJ68Sv+kSnufDouW0Wgmi0KrIJzE/oA1 1S9w== X-Gm-Message-State: AOAM530hb6uS6vMKnbNfY5Bg2kJUj5dG3UauWWZp1DkYmEkh2xS/1EF3 JGBVAq447pIOBTia1MEp5ozLZo+552QQ5pIDDcY= X-Google-Smtp-Source: ABdhPJzdAcu/rqsJAHYEDYHQWB2i5R24SjAWs9ovT6Ku6QrCQM5eY4Gm09bilSgO5SNhaLL7ebVPVXMe4LoGH0IsBkk= X-Received: by 2002:a05:620a:40d6:: with SMTP id g22mr29784297qko.104.1635860925969; Tue, 02 Nov 2021 06:48:45 -0700 (PDT) MIME-Version: 1.0 References: <20211101060419.4682-1-laoar.shao@gmail.com> <20211101211845.20ff5b2e@gandalf.local.home> In-Reply-To: From: Yafang Shao Date: Tue, 2 Nov 2021 21:48:10 +0800 Message-ID: Subject: Re: [PATCH v7 00/11] extend task comm from 16 to 24 To: Petr Mladek Cc: Steven Rostedt , Andrew Morton , Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Peter Zijlstra , Al Viro , Valentin Schneider , Qiang Zhang , robdclark , christian , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Vincent Guittot , David Miller , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, netdev , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux MM , LKML , kernel test robot , kbuild test robot Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YcR3IuaA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: qtqpkbqpzyw55whdrnh51wbmeqapigz1 X-Rspamd-Queue-Id: 9134E508CC8F X-HE-Tag: 1635860911-628153 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 2, 2021 at 3:56 PM Petr Mladek wrote: > > On Tue 2021-11-02 09:26:35, Yafang Shao wrote: > > On Tue, Nov 2, 2021 at 9:18 AM Steven Rostedt wrote: > > > On Tue, 2 Nov 2021 09:09:50 +0800 > > > Yafang Shao wrote: > > > > Now we only care about kthread, so we can put the pointer into a > > > > kthread specific struct. > > > > For example in the struct kthread, or in kthread->data (which may > > > > conflict with workqueue). > > > > > > No, add a new field to the structure. "full_name" or something like that. > > > I'm guessing it should be NULL if the name fits in TASK_COMM_LEN and > > > allocated if the name had to be truncated. > > > > > > Do not overload data with this. That will just make things confusing. > > > There's not that many kthreads, where an addition of an 8 byte pointer is > > > going to cause issues. > > > > Sure, I will add a new field named "full_name", which only be > > allocated if the kthread's comm is truncated. > > The plan looks good to me. > > One more thing. It should obsolete the workqueue-specific solution. > It would be great to clean up the workqueue code as the next step. > Agreed. The worker comm can be replaced by the new kthread full_name. I will do it in the next step. -- Thanks Yafang