From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43FBBC433EF for ; Tue, 30 Nov 2021 15:54:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADB7D6B0073; Tue, 30 Nov 2021 10:54:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A62EE6B0075; Tue, 30 Nov 2021 10:54:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DC146B0078; Tue, 30 Nov 2021 10:54:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 793F76B0073 for ; Tue, 30 Nov 2021 10:54:16 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 442C08DF63 for ; Tue, 30 Nov 2021 15:54:06 +0000 (UTC) X-FDA: 78866042850.18.75304C9 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf13.hostedemail.com (Postfix) with ESMTP id D685D10462A4 for ; Tue, 30 Nov 2021 15:54:00 +0000 (UTC) Received: by mail-qk1-f170.google.com with SMTP id q64so27278799qkd.5 for ; Tue, 30 Nov 2021 07:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5jfG9Qw6wgd9sRjYfyHDytET8Ac/XcqwnteljgGuckk=; b=BntxTnwecg6BJSWIvVKExBquBtQ30s/lQ1YU/vtHIPa1Rx8ar/0r4fbnZzkVxmuMAb OzAbN7axchp00LTYFaxf1R9+06zsQfibPFDthdJkWHwessPgB59jSkf2hhJC9Jya5qyy HlASVFBQYACqEYVUo0srq3QkMFzJGpti1VVHtgcnXPBDChfHu3LanOSzPF2UPdSdM8Gk ouRdu2IXl6S/VnlWEksWw3jwf6CY3mhCilbCsObeM91dghSXL7b0a41ke+NdWEQkEgzh Won2HU6OUxb+j1fd9BYxScLJplAHx9QZ5JOlu9jWIR1hHSvIoz2zJCWmVGE6ELg+suCU X1ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5jfG9Qw6wgd9sRjYfyHDytET8Ac/XcqwnteljgGuckk=; b=ekDt3+Zl7vJ1LlQmNH1YKyN9BDA4tjb50w2NwzsvQ3wwUHHCqz4bkBzFt5biSq9w9M emIDd1/VHhlgYufIFl/V6cxBjJibH9ji+mK/wIs7JbYRvpZ/U9FymjYe1u8UZpfcCmqW wW/JkQsPVkUWskXNSHmYwd/+rLJQrJr9R86ZTUNCdqkXvjHitYDJzYfJHFMmf+CPrTOi EOObfzv4O4sfuUpAzcKsPmC7CWPFUaBFnY7QCKdBFWqWmnro+FEA2nwxUJsU1lE9Nrgy +aj3hxpDptheWvVF2otQEYwIXdvm9/KacuIfDWwRjuSqBoENo5Kx4NpGUcpvF5e8F0QG vL1Q== X-Gm-Message-State: AOAM533BC7qFSceXmzltNk1G6hoZahevqF83MEciQ9KmT3YVkJ5QivUd qAvi6xCGtn5LzoYW+Q9ucaU1yJO/a6G0sEfwQSQ= X-Google-Smtp-Source: ABdhPJyonKn3G8UIi6BT3phblLDnrVQm6qLkdWviQusM/bKsEz//a+DZxT6MhXu5EzeyFmfNCV15y1QUuJs0ifkzE2Y= X-Received: by 2002:a05:620a:2e3:: with SMTP id a3mr7577qko.451.1638287645274; Tue, 30 Nov 2021 07:54:05 -0800 (PST) MIME-Version: 1.0 References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-5-laoar.shao@gmail.com> <20211129110140.733475f3@gandalf.local.home> <20211130092240.312f68a4@gandalf.local.home> In-Reply-To: <20211130092240.312f68a4@gandalf.local.home> From: Yafang Shao Date: Tue, 30 Nov 2021 23:53:30 +0800 Message-ID: Subject: Re: [PATCH v2 4/7] fs/binfmt_elf: replace open-coded string copy with get_task_comm To: Steven Rostedt Cc: Andrew Morton , netdev , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux MM , LKML , kernel test robot , kbuild test robot , Kees Cook , David Hildenbrand , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Petr Mladek Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ccym8919wzibnxmckpg3eofaxgytbyxp Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BntxTnwe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.170 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D685D10462A4 X-HE-Tag: 1638287640-766702 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 30, 2021 at 10:22 PM Steven Rostedt wrote: > > On Tue, 30 Nov 2021 11:01:27 +0800 > Yafang Shao wrote: > > > There are three options, > > - option 1 > > comment on all the hard-coded 16 to explain why it is hard-coded > > - option 2 > > replace the hard-coded 16 that can be replaced and comment on the > > others which can't be replaced. > > - option 3 > > replace the hard-coded 16 that can be replaced and specifically > > define TASK_COMM_LEN_16 in other files which can't include > > linux/sched.h. > > > > Which one do you prefer ? > > > > Option 3. Since TASK_COMM_LEN_16 is, by it's name, already hard coded to > 16, it doesn't really matter if you define it in more than one location. > > Or we could define it in another header that include/sched.h can include. > > The idea of having TASK_COMM_LEN_16 is to easily grep for it, and also know > exactly what it is used for when people see it being used. > I will send a separate patch (or patchset) to replace all the old hard-coded 16 with TASK_COMM_LEN_16 based on the -mm tree. -- Thanks Yafang