From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E90C433F5 for ; Tue, 26 Oct 2021 01:49:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 753C1603E9 for ; Tue, 26 Oct 2021 01:49:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 753C1603E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 135B0940008; Mon, 25 Oct 2021 21:49:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E66C940007; Mon, 25 Oct 2021 21:49:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF117940008; Mon, 25 Oct 2021 21:49:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id DC214940007 for ; Mon, 25 Oct 2021 21:49:24 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 90FA439BBB for ; Tue, 26 Oct 2021 01:49:24 +0000 (UTC) X-FDA: 78736906248.32.ECA2534 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf23.hostedemail.com (Postfix) with ESMTP id C700F90000A5 for ; Tue, 26 Oct 2021 01:49:16 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id y67so18093556iof.10 for ; Mon, 25 Oct 2021 18:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q9ixNJMryetrNkf64Gif/9S4GmDdPd1m0A8YYlrDxDA=; b=TBnfJZ2THlgi6EJWoe2MO5u+LFFM0EWaiS+gotcqJjfIh8zd+i2c6molpxOgo/9s4D dFOGYLm+q0OhSm73HgMzBOqjy2LkiZ+kuDPMyr4SFVGL5gxwrAXFIhbwonRW2eC7qEAi 2K8GtjicsqXI4vzFSsCcedGOgub8jloVy1yjHvaPn9352ZIndl5Ea4DrrTu7ZAAqMD6J QogrxjLepRtyf4KjhS9R4PcbYPfrlWzBubvr+fLQWsihUtby/5E+e0AX6/dw9h9USG1r A5SxerUB1p4uMYV8rL9Pf7naaoIsGCSa6jAI2ewjP+7NXDjJEMyjy+fqlQ0t6wtZiIpc /BXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q9ixNJMryetrNkf64Gif/9S4GmDdPd1m0A8YYlrDxDA=; b=D8CK6xj5ANFesXWu/w3xThV8WkyMI4nlqImlCYQzcQHRPMq3zSWL2YOJKvhRx8JA30 ZUjFoi/ousS7g1tb5jbspubDcgvzIsgkEKKAGEyj0tCyaOhP2lJ+adOW2iHEz7e/lYXk cuFrlQF5w3SzAlWfJDnAwNbDXRT/GfK/G2XDJ4NAAQTxnAWpsclpGKDxCZaSPNXnZXmL faW4s1WD6TB5wHOd3fRyp/8wYDFwdA7i9n3rC4eB1BLpO8tnW7V2wu5oGXRRF/quJVh6 SF1H3mBhz04hDx1TqpoAagCuoUhl1OkigeeVnBGdKLA+ZF/yq9pGm/b/T9bwyIQSMw4v gZmA== X-Gm-Message-State: AOAM533YYe57GqRcEtJKDO8Bc24xybCYiv1M/woeiUSpALEHqyRm9SVe 2sIJFw8yLgmfugGx5ftKM9j5RHqP6wZHt7TOmyQ= X-Google-Smtp-Source: ABdhPJxyqz6JE4o8mcyL8jtdYd9fyB0EJ9+xMphQ3cQq2Z6znTX7NDxCDSShbtRLSLDUkJdu8VHSeeQUDN0xgh39/eo= X-Received: by 2002:a05:6602:1514:: with SMTP id g20mr13536302iow.9.1635212963546; Mon, 25 Oct 2021 18:49:23 -0700 (PDT) MIME-Version: 1.0 References: <20211025083315.4752-1-laoar.shao@gmail.com> <20211025083315.4752-2-laoar.shao@gmail.com> <202110251407.6FD1411ECB@keescook> In-Reply-To: <202110251407.6FD1411ECB@keescook> From: Yafang Shao Date: Tue, 26 Oct 2021 09:48:47 +0800 Message-ID: Subject: Re: [PATCH v6 01/12] fs/exec: make __set_task_comm always set a nul ternimated string To: Kees Cook Cc: Andrew Morton , Steven Rostedt , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Petr Mladek , Peter Zijlstra , Al Viro , Valentin Schneider , Qiang Zhang , robdclark , christian , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Vincent Guittot , David Miller , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, netdev , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux MM , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: rtu79u5q16n6az8twj5dfgugpkhyt8ym Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TBnfJZ2T; spf=pass (imf23.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C700F90000A5 X-HE-Tag: 1635212956-645891 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 26, 2021 at 5:07 AM Kees Cook wrote: > > On Mon, Oct 25, 2021 at 08:33:04AM +0000, Yafang Shao wrote: > > Make sure the string set to task comm is always nul ternimated. > > typo nit: "terminated" > Thanks for pointing this out. I will correct lt. > > > > Signed-off-by: Yafang Shao > > Reviewed-by: Kees Cook > Thanks for the review. -- Thanks Yafang