From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43507C433DF for ; Thu, 15 Oct 2020 06:10:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 95B8D22249 for ; Thu, 15 Oct 2020 06:10:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WjAeHA/w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95B8D22249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB859900002; Thu, 15 Oct 2020 02:10:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6A986B0070; Thu, 15 Oct 2020 02:10:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95747900002; Thu, 15 Oct 2020 02:10:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 69D5F6B0068 for ; Thu, 15 Oct 2020 02:10:02 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DF0C0180AD807 for ; Thu, 15 Oct 2020 06:10:01 +0000 (UTC) X-FDA: 77373134202.22.root58_4a0a95127212 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id A700B18038E60 for ; Thu, 15 Oct 2020 06:10:01 +0000 (UTC) X-HE-Tag: root58_4a0a95127212 X-Filterd-Recvd-Size: 3779 Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 15 Oct 2020 06:10:01 +0000 (UTC) Received: by mail-io1-f65.google.com with SMTP id q9so2889052iow.6 for ; Wed, 14 Oct 2020 23:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GhEYHeNyHPnH2FGy1MtBzHI0hjjTlMA4cX8D6yJQ2mI=; b=WjAeHA/wWhvAU4TNL73rBUzLosSTSCLaVO/Zm+5Spi0wtwEu3UlDDwfdGjGJEWETlD T+CrJ5yZQMcDMm2m1PLatlDNWzNnTnBl91bWwZwN3XoiOu/4e77gjXRf7bhwT4X9CcZ/ KGIq3gTKEzwbtZSPyXUq2IFXkUu0yR3iE94K8MKnXMIdq2E8d4MqvlEFyHSTWbCYsaya 8oTpGDmrdFjkv9RDt1vjjOttgV4j0YYz150QHXlAo15KQbiwSj7EYff685fOBRY9YZ6J wbsbbjgos3DW4IPM5nwCHXS73NPI7732ez9D2NPE9o4ozOlwcPYplNHHPebDOy1pBoKD Rz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GhEYHeNyHPnH2FGy1MtBzHI0hjjTlMA4cX8D6yJQ2mI=; b=ftkxig6GkpCb5vtNZQEU/CFvdkcB3D8tqO9RS33xPVgqzvQwVR+qAFsGUlQoeJesxf KwXln3p96MdBTMQxzu4SMfFY8wkYWIw+O2cK02hWd3NGLu87LtZ63Lcfyfybsx8yqpVe 5iuUs8pFY6OS2948VyFUu0+7hJ3oreI33TBXYGxY4fUXv9ApJ5sHUDuCQQJ53ZEqELQ9 3FjnYgfzl8vxckjnJevolchgEVm0VtlLKq0KDQ0o7zf1kk62N4/00CpJgVuoCB/TQLDN BhX4oIKE743kcgDR4VExy6Cz0UNsiJR6OTkMPBMjlxYop9HZFbbB19H5Dv4YhtSVmJkw 7Uww== X-Gm-Message-State: AOAM5332/iZSg6QPfNyMpi7j8xNMKaDmVGVi6wkVHMBLcDgkR+o4JmyU pcwRKsyY/sNPN7mL0hLbhk3jK+Epqwfs9UppQo0= X-Google-Smtp-Source: ABdhPJxekI1J0dYf7d5zbhc3cVxIx3EnMbNj7C30QS1HWhig9R1Vowu568czLV4/D4+zrLOq57GtIlLY4oTApNqJ6L4= X-Received: by 2002:a6b:b413:: with SMTP id d19mr2160176iof.10.1602742200656; Wed, 14 Oct 2020 23:10:00 -0700 (PDT) MIME-Version: 1.0 References: <20201015054808.2445904-1-yanaijie@huawei.com> In-Reply-To: <20201015054808.2445904-1-yanaijie@huawei.com> From: Yafang Shao Date: Thu, 15 Oct 2020 14:09:24 +0800 Message-ID: Subject: Re: [PATCH] mm: make __invalidate_mapping_pages() static To: Jason Yan Cc: Andrew Morton , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 15, 2020 at 1:44 PM Jason Yan wrote: > > Fix the following sparse warning: > > mm/truncate.c:531:15: warning: symbol '__invalidate_mapping_pages' was > not declared. Should it be static? > > Fixes: eb1d7a65f08a ("mm, fadvise: improve the expensive remote LRU cache draining after FADV_DONTNEED") > Signed-off-by: Jason Yan > --- > mm/truncate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index 18cec39a9f53..960edf5803ca 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -528,7 +528,7 @@ void truncate_inode_pages_final(struct address_space *mapping) > } > EXPORT_SYMBOL(truncate_inode_pages_final); > > -unsigned long __invalidate_mapping_pages(struct address_space *mapping, > +static unsigned long __invalidate_mapping_pages(struct address_space *mapping, > pgoff_t start, pgoff_t end, unsigned long *nr_pagevec) > { > pgoff_t indices[PAGEVEC_SIZE]; > -- > 2.25.4 > Ah, this new helper is only used in truncate.c, so it should be static. Thanks for catching it. Reviewed-by: Yafang Shao -- Thanks Yafang