From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E144C433DB for ; Mon, 8 Feb 2021 14:02:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C153D64E85 for ; Mon, 8 Feb 2021 14:02:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C153D64E85 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 19E1E6B006E; Mon, 8 Feb 2021 09:02:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 14FAB6B0070; Mon, 8 Feb 2021 09:02:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 016826B0071; Mon, 8 Feb 2021 09:02:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id DFCDA6B006E for ; Mon, 8 Feb 2021 09:02:39 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A7B61824999B for ; Mon, 8 Feb 2021 14:02:39 +0000 (UTC) X-FDA: 77795266038.23.view46_4107965275ff Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 8938A37608 for ; Mon, 8 Feb 2021 14:02:39 +0000 (UTC) X-HE-Tag: view46_4107965275ff X-Filterd-Recvd-Size: 3984 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 14:02:38 +0000 (UTC) Received: by mail-il1-f175.google.com with SMTP id q9so12821342ilo.1 for ; Mon, 08 Feb 2021 06:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yIihDZxPKVTZ1cae8PC+4utdo23XVf26uo8MplI1V+0=; b=m1W98MPiWn4KqSymHwJpE0IYeZ4Kk7EKtE/yH6HlXnJnP+InMrRxcG+AHXDkf6K1m4 ZZFeHbBjc85xHQKYWMRu0QbYyqegM0zJHRWU8yCTos5TTZOSXDY9xxJoGSq8n0pKSXJn oXRjWbdlRowm9TB9qftEVBVIvs0l1qfr18Hc4QC8qoYOd6814V728pj6UN6vQDx1pd+W mX0MKpocW86nHrSM2q6I1ZNJrMpZ5DMPdsQOs+gFKciAQ4TfPfTYpZrbZ/IVb0pyXXgp H1O743tZ6XyH7oqVGMOO+3nTWZ91+LqY6ltl2/E+3y69qobNurfdz+KiQ8S9V2IkY32k 7B/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yIihDZxPKVTZ1cae8PC+4utdo23XVf26uo8MplI1V+0=; b=AskKcg1VBy94vlYcSpJ2+VD2w1DbHYhR8ZttAkgEv5pz+FlA7BhySy7tGq+V+QgpYx l+gahPyd2cojD9GsJFsQaDRce5xuzWoJoE2RbF06oCvFZ17qyaCLLE1jnvoiZ0eXMzsx NJfgNybNAmaIxtue922bgmEZ5RQpvbSWI2x5T3fuNEXiIyi1SZ3ir2Bml/iSmjHkzdmJ 7Fhi/sTHYr21lcE6vAO3seBMbN7VqVSKERfJnVVj/EkWiGVvPZp40rKJozCh4sTPaIWO 8WLBUNeDLRziVZLqcQ3+t+OmDl0ztp33klQJDJcLdYQQSYKPpcqFHDAwYWEhq2TbHw85 otVw== X-Gm-Message-State: AOAM53310fxrhNByGVZl1IYua0VkJwZXoeQdI9otZTFmn8VV2YezZWhF g5Keji50DiYVrZZ74m1nqXtc2w6qJGxctZQlcuQ= X-Google-Smtp-Source: ABdhPJzLjfJQyfk8VbCRnosnrTVY2UPFJFyklm3HOduIZeC19YDcALQpXQJxAX3f0H8THQ+CbOh0I5mdROhUD8nUPfg= X-Received: by 2002:a05:6e02:1447:: with SMTP id p7mr15814152ilo.93.1612792958315; Mon, 08 Feb 2021 06:02:38 -0800 (PST) MIME-Version: 1.0 References: <20210208101439.55474-1-laoar.shao@gmail.com> <20210208122009.GN308988@casper.infradead.org> In-Reply-To: <20210208122009.GN308988@casper.infradead.org> From: Yafang Shao Date: Mon, 8 Feb 2021 22:02:02 +0800 Message-ID: Subject: Re: [PATCH v3 0/3] mm, vsprintf: introduce new format to dump full information of page flags To: Matthew Wilcox Cc: Andy Shevchenko , David Hildenbrand , Vlastimil Babka , Christoph Lameter , Miaohe Lin , penberg@kernel.org, David Rientjes , iamjoonsoo.kim@lge.com, Andrew Morton , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Joe Perches , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 8, 2021 at 8:20 PM Matthew Wilcox wrote: > > On Mon, Feb 08, 2021 at 06:14:36PM +0800, Yafang Shao wrote: > > To avoid breaking some tools which parsing pGp via debugfs or affecting > > the printf buffer, other new formats are introduced, so the user can choose > > what and in which order they want, suggested by Andy. These new introduced > > format as follows, > > pGpb: print other information first and then the names of page flags > > pGpl: print the names of page flags first and then the other info > > This is overengineering things. We already print in little-endian order, > and the other information should be tacked onto the end. Just extend > %pGp. Andy's suggestion to add another flag was a bad one. > All right. I will do it in the next version. -- Thanks Yafang