From: Yafang Shao <laoar.shao@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@linux.com>,
Miaohe Lin <linmiaohe@huawei.com>,
penberg@kernel.org, David Rientjes <rientjes@google.com>,
iamjoonsoo.kim@lge.com,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Joe Perches <joe@perches.com>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/3] mm, vsprintf: introduce new format to dump full information of page flags
Date: Mon, 8 Feb 2021 22:02:02 +0800 [thread overview]
Message-ID: <CALOAHbB+xuDFnaBgQpf+1bf1SOdTkn10Mgtps8Adn7yp3_JFfw@mail.gmail.com> (raw)
In-Reply-To: <20210208122009.GN308988@casper.infradead.org>
On Mon, Feb 8, 2021 at 8:20 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Mon, Feb 08, 2021 at 06:14:36PM +0800, Yafang Shao wrote:
> > To avoid breaking some tools which parsing pGp via debugfs or affecting
> > the printf buffer, other new formats are introduced, so the user can choose
> > what and in which order they want, suggested by Andy. These new introduced
> > format as follows,
> > pGpb: print other information first and then the names of page flags
> > pGpl: print the names of page flags first and then the other info
>
> This is overengineering things. We already print in little-endian order,
> and the other information should be tacked onto the end. Just extend
> %pGp. Andy's suggestion to add another flag was a bad one.
>
All right. I will do it in the next version.
--
Thanks
Yafang
prev parent reply other threads:[~2021-02-08 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 10:14 Yafang Shao
2021-02-08 10:14 ` [PATCH v3 1/3] mm, slub: use pGp to print " Yafang Shao
2021-02-08 12:21 ` Matthew Wilcox
2021-02-09 1:04 ` Miaohe Lin
2021-02-08 10:14 ` [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-02-08 16:33 ` Vlastimil Babka
2021-02-08 17:26 ` Matthew Wilcox
2021-02-08 17:59 ` Vlastimil Babka
2021-02-09 1:06 ` Miaohe Lin
2021-02-08 10:14 ` [PATCH v3 3/3] vsprintf: introduce new format to dump full information of page flags Yafang Shao
2021-02-08 12:20 ` [PATCH v3 0/3] mm, " Matthew Wilcox
2021-02-08 13:25 ` Andy Shevchenko
2021-02-08 14:02 ` Yafang Shao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALOAHbB+xuDFnaBgQpf+1bf1SOdTkn10Mgtps8Adn7yp3_JFfw@mail.gmail.com \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox