From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B065C433E0 for ; Fri, 22 May 2020 16:28:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C96AB20756 for ; Fri, 22 May 2020 16:28:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lfm2XyuL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C96AB20756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5BD9280008; Fri, 22 May 2020 12:28:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5471080007; Fri, 22 May 2020 12:28:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40FA980008; Fri, 22 May 2020 12:28:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 2637780007 for ; Fri, 22 May 2020 12:28:02 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D35D449960D for ; Fri, 22 May 2020 16:28:01 +0000 (UTC) X-FDA: 76844886762.18.kick70_8046524c35e25 X-HE-Tag: kick70_8046524c35e25 X-Filterd-Recvd-Size: 3998 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 May 2020 16:28:01 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id b15so11207200ilq.12 for ; Fri, 22 May 2020 09:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TysnkmOIkLeX9KxlHLPL4xK1JYCC9XQVpNTteD8sJWI=; b=lfm2XyuLMBYBEMicKkNUBvKtTqemJXPbmFBeN/eDLNIxq1Id68/49Ne+gIoDwSCuxt PeZotFigJ3ZPSD9p6jTGhATFunfQ9qsPYh76th8MHBQeNDElh3K4ig7cWIiYTF1beD9I ZhK/eAXZzgrN6Zfj6BDIp8VMQbVyI5viIJjrVpBW/BnSbFVqqUN0n3+xKKdukU2d4JTt ocbVEWftg/opspRtHbRTG3DtRVxzVSXWHlF/bgAKDT0g/A+frfgtgjGZZy2+xfX+Hu+f 3xn7ErM5jt3GoVN0OtIsP+1x1V9o3ktTP2HTuxHEsbtjlbdMByZrDzBW/vFnZKr6Qwz8 CEfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TysnkmOIkLeX9KxlHLPL4xK1JYCC9XQVpNTteD8sJWI=; b=mE/j0g1xjQYz5cOlhmRNZGA8gml96IFXObr2KeprVyEUAsPH1rLUKkT/rFjbOvS+CV f2Wdvd91sCwa7o38mEZXyCtI/GNulKanKYzbGzszNj2kHzTHtHeMV2ivGBc1WiLknNmV yknsHD2qzobVyRGTuFDlQPAaMQdrHcvjkAhz2FhtBndtEQsWeJA4HPjSNbho3lKe3VJx CFnBZqu6eP+Chl4OAqPmfntkTVNOccCIZt371kObd2nyLLWpdxV4PsKSx44FVxO7yZrK 9KEs/Wde08X/toUQQY9BWMjF6c92mf15bH7bgA8X1CvKU6uMEXMgc+IKfGYEXLo6lRkl A6aw== X-Gm-Message-State: AOAM530YGDyGBFHHfsjzU+ns4p8oBjPpx2On0d9WipkXTdMuZnJkEY// OLyO0ynj74Rif328bSPe8ziJ8eylEiVbbPn3Tlo= X-Google-Smtp-Source: ABdhPJygTKEZ0/3slz2Qencuk56A3Fa5sc0tQiWlaV/GUulZeY6LWuJ4x6zRNvb/rdBY6V2nkBUTiyiv1Exd1hFGk1E= X-Received: by 2002:a92:10a:: with SMTP id 10mr14145774ilb.203.1590164880781; Fri, 22 May 2020 09:28:00 -0700 (PDT) MIME-Version: 1.0 References: <20200505084127.12923-1-laoar.shao@gmail.com> <20200505084127.12923-3-laoar.shao@gmail.com> <20200522160626.GB1112005@chrisdown.name> <20200522160709.GC1112005@chrisdown.name> In-Reply-To: <20200522160709.GC1112005@chrisdown.name> From: Yafang Shao Date: Sat, 23 May 2020 00:27:24 +0800 Message-ID: Subject: Re: [PATCH v3 2/2] mm, memcg: Decouple e{low,min} state mutations from protection checks To: Chris Down Cc: Naresh Kamboju , Andrew Morton , Michal Hocko , Johannes Weiner , Roman Gushchin , linux-mm , Cgroups , open list , lkft-triage@lists.linaro.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 23, 2020 at 12:07 AM Chris Down wrote: > > Chris Down writes: > >Yafang Shao writes: > >>I will do it. > >>If no one has objection to my proposal, I will send it tomorrow. > > > >If the fixup patch works, just send that. Otherwise, sure. > > Oh, I see the other reply from Naresh now saying it didn't help. > > Sure, feel free to do that for now then while we work out what the real problem > is. Regarding the root cause, my guess is it makes a similar mistake that I tried to fix in the previous patch that the direct reclaimer read a stale protection value. But I don't think it is worth to add another fix. The best way is to revert this commit. -- Thanks Yafang