From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 609C6C636D3 for ; Sun, 12 Feb 2023 03:39:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 940026B0073; Sat, 11 Feb 2023 22:39:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EEC46B0074; Sat, 11 Feb 2023 22:39:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DD9E6B0075; Sat, 11 Feb 2023 22:39:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6D07E6B0073 for ; Sat, 11 Feb 2023 22:39:31 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 387CB1A0AD5 for ; Sun, 12 Feb 2023 03:39:31 +0000 (UTC) X-FDA: 80457234942.20.C2A4AAD Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf14.hostedemail.com (Postfix) with ESMTP id 7D73F100003 for ; Sun, 12 Feb 2023 03:39:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Eesg2pr2; spf=pass (imf14.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676173169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k38DlK0t/XHGBmKF/8ZrTC+4DU+EC3G+T7TmyTsfFvU=; b=N3Zw3Gnk7fJr2nHgqty7mUs0t1Vk5GPGIvEJ/VTFVIG9nf8H5awC79Ws7ssGFssylIcnTn 4Rg7chv8TwlJXbn/lSLyhIIzbjE9LhLT7ipqM37J0u95mdMEi4dsB6A6xQE9hRlKtoHRBT coM0GT09Fa/W7LReM3IIO34qvKL3Xtw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Eesg2pr2; spf=pass (imf14.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676173169; a=rsa-sha256; cv=none; b=QJcuQlxI+it2n17bKodI8OCzEmQdrT/EMx1JdNUPzFImhTPmCW374/BLgOEWEimi1rksEd DKFT9qxvYmaH+etQLFmNFDGTyoHeAVugr2+pyy8VGi+iSz5ABHkIr2LohSVHXcs0ykXy2k VYHYJbTLyn8D/ryi1HxNRyoODXVPoIA= Received: by mail-qv1-f47.google.com with SMTP id j5so4165307qvi.3 for ; Sat, 11 Feb 2023 19:39:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1676173168; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k38DlK0t/XHGBmKF/8ZrTC+4DU+EC3G+T7TmyTsfFvU=; b=Eesg2pr21Hk2/SFlRpaZz6BWSDuCQ/lAmubyFyhQpXpmWUFBZwA3RMRmFl4R6kupMj zIqimSmEfd8SJuRPncA7f70MIq1bYExvI5pTFbun6JKUsJZNcHRDzXvBezdU8A9IDOz9 S/KAxSCZfrwTD5epNKzAWf4XGqBE3lI9zOWH4r6myy1F/Kog4Mqu8l/+/0KMs42gMcw/ lunbSDYZj9MoJlmDA53Ub0uurhNXOzNtd70JVU5mY0X5OckxLpdhMHkEmh8xii43dAr3 ygFaw3kr1WSJiBYhv54OykPyCEASrCTnFAVWBt63tz1F0o3QWH6d4N8+M7w8JgbFaoUx uYxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676173168; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k38DlK0t/XHGBmKF/8ZrTC+4DU+EC3G+T7TmyTsfFvU=; b=gI5mzLrFrXCaWwWh2dkXDjzdpCm4rIyVarsMEimaL7giyiDx/RORqlDiD8w+kvy3Lt NxiL9u/tmExPPoNFJb/Obpa9cmiO8We2EYSOKOExdlaGcrzeYp4eXANMn2vu8rbkRETP KSVZU0fCqkhHoBpyAKBmCymMR2K5mAVz+GFv5Bod/nR9BmgQ3MeLYE/SVqH+ld36gFPM 9tW+bxQPSjLjTnZf0dkjl/M6PPzqEZmiePBhUOUjKQqSCUtewogG02g9QowM6XuGvps/ /r5idKJ6r320wf50rS2s4CMtn3XR9m/hpnSlksykpqXTiPoJvG5Ogr+kWKTP6mXlgDob CUoA== X-Gm-Message-State: AO0yUKXb3AmTpl40H8mzSURJbl7PThuyfh8hwKa3rWoXK402rh/HZNDm m7XN/Sg/UXLb/Aarl774QTosD1Ysz0r9V7Ukj0c= X-Google-Smtp-Source: AK7set++fC5LRuz2dH+ErgwVb2ke3N2snEdx0tgAkIr73gknu4wwZoOPtJOeV6iq468KODoVusgaflTPhY0FFMyRNq4= X-Received: by 2002:a0c:b306:0:b0:537:6777:b744 with SMTP id s6-20020a0cb306000000b005376777b744mr1598861qve.58.1676173168615; Sat, 11 Feb 2023 19:39:28 -0800 (PST) MIME-Version: 1.0 References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> <20230208212858.477cd05e@gandalf.local.home> <20230208213343.40ee15a5@gandalf.local.home> <20230211140011.4f15a633@gandalf.local.home> In-Reply-To: <20230211140011.4f15a633@gandalf.local.home> From: Yafang Shao Date: Sun, 12 Feb 2023 11:38:52 +0800 Message-ID: Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN To: Steven Rostedt Cc: John Stultz , Alexei Starovoitov , Andrew Morton , Network Development , bpf , "linux-perf-use." , Linux-Fsdevel , linux-mm , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko , David Hildenbrand , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek , Kajetan Puchalski , Lukasz Luba , Qais Yousef , Daniele Di Proietto , Linus Torvalds Content-Type: multipart/mixed; boundary="0000000000004c630c05f4787a16" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7D73F100003 X-Stat-Signature: zewnuu3judc14cx5pbg384zgfktpiytx X-Rspam-User: X-HE-Tag: 1676173169-351806 X-HE-Meta: U2FsdGVkX19sbjOdyNlelVkIxnLNjo74k+kKiFtjU7TXXJPMcpM85WnokO0RTjx6pfmkmWwk9RkW0ztxOkPVQQ0k3YH7mfAcTw4Pu5zk/RplBEZcnUyaFyyvTimGPoY10pd26fnUMDq9jZkKJscK4fhiXlH419eYkz8glvMHBe+EDX+tChPrQMmraAW47iPQymJpaGNOJ7nE+7nm26PCpyfrL/Unbx/J3GdWhlewWUp6MRd6VAn7TgyRKq9ZzctuvyEEWASrJKmKqnOFYjj4NaQe03spvsbIDjXPHZqV09VLVzQCkOA7tSbJortgofhEnDqiWLsJTCiGEXa9Izk9TXTLao8Ynv/1dnu27v0ZNCJptHIR4VYx0ciNxV1i4STMobAWOHEF8MBcg1RJelJ/JYolMsyJ8G1w7qWQva04Pqxw/Che698V+aRSmLxyMsg2PULqduWR1QlVZ9PMEUgmMrQduY1PrxI48v9+247LjorR1i6mMcn4oClwsQZpchzgqnylmXg0KVvGKrIaUXwFbSdI5FBaoclANwKhO4hfuGX/lKpq3hqZ4tgVLNEhEX/lyAnIQkfUQaMS/ALcAFiS0WScrd2q1wQDd0erj0BqESOjsiF00YhjXJd+vVH7YUTyK6/IcgHBoD7wCaFZBk6V7KMkrMRyWrV9ssR2wzuWRfO7zWwguyoWnTb2rN5cN7l0H3bu3bguy35ZTGFU+HSiZBLqXe4E1IzmS4S758lqvaTLnNJ1bMkssoZB+FL9LHjm4e+1Kktc2VxwpcfVEezMi813gWtBbSSkbzLYx1MNjbZf+DNDSFihMbh5NSBrP8gve5g+cihG2XA4HrVH4lQNMs4VC8PgfEYNpAqhkEqUqY616vz0vKoGaL3lL4VnNGEDVh/a6fiWDXPogfW9b2c6shHidl4DmByCZsL/FR32h0eV81LV7JDTCbtvFd6zxBZNv1xolMWyyIBX/28iRbv FP6rQ+fZ tXlEUsHvg0+sKZHUu3vcgZVXv+3eX/0kwx76bPyIfMHmq3URIK9yTHQTAWm3H3lqamqmLmIdW7yilUniRe1HEKkKj4eCudNLVor8FoTVRgPDS9Kogfn7y40AhNPSZ2XnVpjZf+WFsegrUeK39MBa209zjcTXX7d5xBPCvJGCLaxGQwbBzpFjxvl/zC5GEewlo76xRi8lZJkBIZGJvMF204d4BQv3ZYmWTGDanXq+bb5zvOewysfZ2+cjlpeu2MtiCdZPjgO2JPJCDssgF++zfF5D+ruu7g7QIHdbLGbCLqsxRQaxoUFNAU20aTo8Ewovujdb7XpULLxLZnXjvMa2vRBCp8J2RCt7gSNghmYMfDo1X0V/S1DQacNBRGRvgeaqQr4ra8MnXiDlsigjmP/QViLTbyANGV9WEpAfV6D7VuT5zZ1lWe0h2MeNfrRqTNRUo566CZ75xvTNzAtUtUiT+HLPqc6Lqx4kRzoOmuuV+umpQ23ftiD1BNTYkssSCGg6NpSg2ca83apLqMZTh3NokSzGruGT58F+IkxI0QyPUoPqocrYC67k0us0OqJF8fYil/lo2+OROJs76bh6cYn7xrW9VliBEYknaDYX50FOGMYz+6HkQM2Ct8nB6z2ZW+xcUYZ3XDyrjgv2bfYenYYDlObAlDtruqiR0Km3CUoDWLdBgtwY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000004c630c05f4787a16 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 3:00 AM Steven Rostedt wrote: > > On Wed, 8 Feb 2023 21:33:43 -0500 > Steven Rostedt wrote: > > > OK, so it doesn't break perf, trace-cmd and rasdaemon, because the enum= is > > only needed in the print_fmt part. It can handle it in the field portio= n. > > > > That is: > > > > > > system: sched > > name: sched_switch > > ID: 285 > > format: > > field:unsigned short common_type; offset:0; size:2; s= igned:0; > > field:unsigned char common_flags; offset:2; size:1; s= igned:0; > > field:unsigned char common_preempt_count; offset:3; s= ize:1; signed:0; > > field:int common_pid; offset:4; size:4; signed:1; > > > > field:char prev_comm[TASK_COMM_LEN]; offset:8; size:16; = signed:0; > > ^^^^^^^^^^^^^^ ^^ > > is ignored is u= sed > > > > > > field:pid_t prev_pid; offset:24; size:4; signed:1; > > field:int prev_prio; offset:28; size:4; signed:1; > > field:long prev_state; offset:32; size:8; signed:1; > > field:char next_comm[TASK_COMM_LEN]; offset:40; size:16; = signed:0; > > field:pid_t next_pid; offset:56; size:4; signed:1; > > field:int next_prio; offset:60; size:4; signed:1; > > > > print fmt: "prev_comm=3D%s prev_pid=3D%d prev_prio=3D%d prev_state=3D%s= %s =3D=3D> next_comm=3D%s next_pid=3D%d next_prio=3D%d", REC->prev_comm, RE= C->prev_pid, REC->prev_prio, (REC->prev_state & ((((0x00000000 | 0x00000001= | 0x00000002 | 0x00000004 | 0x00000008 | 0x00000010 | 0x00000020 | 0x00000= 040) + 1) << 1) - 1)) ? __print_flags(REC->prev_state & ((((0x00000000 | 0x= 00000001 | 0x00000002 | 0x00000004 | 0x00000008 | 0x00000010 | 0x00000020 |= 0x00000040) + 1) << 1) - 1), "|", { 0x00000001, "S" }, { 0x00000002, "D" }= , { 0x00000004, "T" }, { 0x00000008, "t" }, { 0x00000010, "X" }, { 0x000000= 20, "Z" }, { 0x00000040, "P" }, { 0x00000080, "I" }) : "R", REC->prev_state= & (((0x00000000 | 0x00000001 | 0x00000002 | 0x00000004 | 0x00000008 | 0x00= 000010 | 0x00000020 | 0x00000040) + 1) << 1) ? "+" : "", REC->next_comm, RE= C->next_pid, REC->next_prio > > > > ^^^^^^^ > > > > Is what requires the conversions. So I take that back. It only breaks > > perfetto, and that's because it writes its own parser and doesn't use > > libtraceevent. > > Actually, there are cases that this needs to be a number, as b3bc8547d3be= 6 > ("tracing: Have TRACE_DEFINE_ENUM affect trace event types as well") made > it update fields as well as the printk fmt. > It seems that TRACE_DEFINE_ENUM(TASK_COMM_LEN) in the trace events header files would be a better fix. > I think because libtraceevent noticed that it was a "char" array, it just > defaults to "size". But this does have meaning for all other types, and I > can see other parsers requiring that. > > -- Steve --=20 Regards Yafang --0000000000004c630c05f4787a16 Content-Type: application/octet-stream; name="TASK_COMM_LEN.diff" Content-Disposition: attachment; filename="TASK_COMM_LEN.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_le0u4tol0 ZGlmZiAtLWdpdCBhL2luY2x1ZGUvdHJhY2UvZXZlbnRzL2Jsb2NrLmggYi9pbmNsdWRlL3RyYWNl L2V2ZW50cy9ibG9jay5oDQppbmRleCA3ZjRkZmJkLi45N2NmNmMyIDEwMDY0NA0KLS0tIGEvaW5j bHVkZS90cmFjZS9ldmVudHMvYmxvY2suaA0KKysrIGIvaW5jbHVkZS90cmFjZS9ldmVudHMvYmxv Y2suaA0KQEAgLTEyLDYgKzEyLDggQEANCiANCiAjZGVmaW5lIFJXQlNfTEVOCTgNCiANCitUUkFD RV9ERUZJTkVfRU5VTShUQVNLX0NPTU1fTEVOKTsNCisNCiBERUNMQVJFX0VWRU5UX0NMQVNTKGJs b2NrX2J1ZmZlciwNCiANCiAJVFBfUFJPVE8oc3RydWN0IGJ1ZmZlcl9oZWFkICpiaCksDQpkaWZm IC0tZ2l0IGEvaW5jbHVkZS90cmFjZS9ldmVudHMvb29tLmggYi9pbmNsdWRlL3RyYWNlL2V2ZW50 cy9vb20uaA0KaW5kZXggMjZhMTFlNC4uMTlkZTlhOCAxMDA2NDQNCi0tLSBhL2luY2x1ZGUvdHJh Y2UvZXZlbnRzL29vbS5oDQorKysgYi9pbmNsdWRlL3RyYWNlL2V2ZW50cy9vb20uaA0KQEAgLTcs NiArNyw4IEBADQogI2luY2x1ZGUgPGxpbnV4L3RyYWNlcG9pbnQuaD4NCiAjaW5jbHVkZSA8dHJh Y2UvZXZlbnRzL21tZmxhZ3MuaD4NCiANCitUUkFDRV9ERUZJTkVfRU5VTShUQVNLX0NPTU1fTEVO KTsNCisNCiBUUkFDRV9FVkVOVChvb21fc2NvcmVfYWRqX3VwZGF0ZSwNCiANCiAJVFBfUFJPVE8o c3RydWN0IHRhc2tfc3RydWN0ICp0YXNrKSwNCmRpZmYgLS1naXQgYS9pbmNsdWRlL3RyYWNlL2V2 ZW50cy9vc25vaXNlLmggYi9pbmNsdWRlL3RyYWNlL2V2ZW50cy9vc25vaXNlLmgNCmluZGV4IDgy Zjc0MWUuLmFjM2MwYWIgMTAwNjQ0DQotLS0gYS9pbmNsdWRlL3RyYWNlL2V2ZW50cy9vc25vaXNl LmgNCisrKyBiL2luY2x1ZGUvdHJhY2UvZXZlbnRzL29zbm9pc2UuaA0KQEAgLTYsNiArNiw4IEBA DQogI2RlZmluZSBfT1NOT0lTRV9UUkFDRV9IDQogDQogI2luY2x1ZGUgPGxpbnV4L3RyYWNlcG9p bnQuaD4NCitUUkFDRV9ERUZJTkVfRU5VTShUQVNLX0NPTU1fTEVOKTsNCisNCiBUUkFDRV9FVkVO VCh0aHJlYWRfbm9pc2UsDQogDQogCVRQX1BST1RPKHN0cnVjdCB0YXNrX3N0cnVjdCAqdCwgdTY0 IHN0YXJ0LCB1NjQgZHVyYXRpb24pLA0KZGlmZiAtLWdpdCBhL2luY2x1ZGUvdHJhY2UvZXZlbnRz L3NjaGVkLmggYi9pbmNsdWRlL3RyYWNlL2V2ZW50cy9zY2hlZC5oDQppbmRleCBmYmI5OWE2Li41 N2VjMDllIDEwMDY0NA0KLS0tIGEvaW5jbHVkZS90cmFjZS9ldmVudHMvc2NoZWQuaA0KKysrIGIv aW5jbHVkZS90cmFjZS9ldmVudHMvc2NoZWQuaA0KQEAgLTIxNiw2ICsyMTYsNyBAQCBzdGF0aWMg aW5saW5lIGxvbmcgX190cmFjZV9zY2hlZF9zd2l0Y2hfc3RhdGUoYm9vbCBwcmVlbXB0LA0KIH0N CiAjZW5kaWYgLyogQ1JFQVRFX1RSQUNFX1BPSU5UUyAqLw0KIA0KK1RSQUNFX0RFRklORV9FTlVN KFRBU0tfQ09NTV9MRU4pOw0KIC8qDQogICogVHJhY2Vwb2ludCBmb3IgdGFzayBzd2l0Y2hlcywg cGVyZm9ybWVkIGJ5IHRoZSBzY2hlZHVsZXI6DQogICovDQpkaWZmIC0tZ2l0IGEvaW5jbHVkZS90 cmFjZS9ldmVudHMvc2lnbmFsLmggYi9pbmNsdWRlL3RyYWNlL2V2ZW50cy9zaWduYWwuaA0KaW5k ZXggMWRiN2U0Yi4uM2IxY2RiNiAxMDA2NDQNCi0tLSBhL2luY2x1ZGUvdHJhY2UvZXZlbnRzL3Np Z25hbC5oDQorKysgYi9pbmNsdWRlL3RyYWNlL2V2ZW50cy9zaWduYWwuaA0KQEAgLTksNiArOSw4 IEBADQogI2luY2x1ZGUgPGxpbnV4L3NjaGVkLmg+DQogI2luY2x1ZGUgPGxpbnV4L3RyYWNlcG9p bnQuaD4NCiANCitUUkFDRV9ERUZJTkVfRU5VTShUQVNLX0NPTU1fTEVOKTsNCisNCiAjZGVmaW5l IFRQX1NUT1JFX1NJR0lORk8oX19lbnRyeSwgaW5mbykJCQkJXA0KIAlkbyB7CQkJCQkJCVwNCiAJ CWlmIChpbmZvID09IFNFTkRfU0lHX05PSU5GTykgewkJCVwNCmRpZmYgLS1naXQgYS9pbmNsdWRl L3RyYWNlL2V2ZW50cy90YXNrLmggYi9pbmNsdWRlL3RyYWNlL2V2ZW50cy90YXNrLmgNCmluZGV4 IDY0ZDE2MDkuLjBhOWUwM2E3IDEwMDY0NA0KLS0tIGEvaW5jbHVkZS90cmFjZS9ldmVudHMvdGFz ay5oDQorKysgYi9pbmNsdWRlL3RyYWNlL2V2ZW50cy90YXNrLmgNCkBAIC02LDYgKzYsNyBAQA0K ICNkZWZpbmUgX1RSQUNFX1RBU0tfSA0KICNpbmNsdWRlIDxsaW51eC90cmFjZXBvaW50Lmg+DQog DQorVFJBQ0VfREVGSU5FX0VOVU0oVEFTS19DT01NX0xFTik7DQogVFJBQ0VfRVZFTlQodGFza19u ZXd0YXNrLA0KIA0KIAlUUF9QUk9UTyhzdHJ1Y3QgdGFza19zdHJ1Y3QgKnRhc2ssIHVuc2lnbmVk IGxvbmcgY2xvbmVfZmxhZ3MpLA0K --0000000000004c630c05f4787a16--