From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2DF3C3A5A9 for ; Mon, 4 May 2020 13:41:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B505B20752 for ; Mon, 4 May 2020 13:41:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="liZwtm43" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B505B20752 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4955E8E0013; Mon, 4 May 2020 09:41:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 446D98E0003; Mon, 4 May 2020 09:41:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35C5F8E0013; Mon, 4 May 2020 09:41:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 19B608E0003 for ; Mon, 4 May 2020 09:41:16 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C58F11AA83 for ; Mon, 4 May 2020 13:41:15 +0000 (UTC) X-FDA: 76779148110.02.map76_62497cb438722 X-HE-Tag: map76_62497cb438722 X-Filterd-Recvd-Size: 3686 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 May 2020 13:41:15 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id e8so11245358ilm.7 for ; Mon, 04 May 2020 06:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ysJ41DADuUNjiW2EobBM4/M+gNYcOi8UBhDomz6OvFc=; b=liZwtm43s8SPoPt/unNyToFlmOahFwgQ7rU3MhDpz9vOI9V+cs1pX+IQ1lO+A3Jt4T nJ5zvnJPEXkRr848FhQ3ByCvI/UFnPyhdf4urlFykmom7vxDwlRbfcXC4L+pMXvLvkVi lFvk1IeZ91olLCHllG0y0gE2LSX+Fe+tI5y/zBHinv2vPRw+LwbH3QgCu97QRcf0GsuA 4Kemvh9TKCms0FQwf+nSzf7SvHtn4/nvqieaWeFKqBVwpT/GB1XO9m2JLqrSh9ksu9Tz nkV1gKEEAiY9TxefGWuy2dSyp8r4Qz1mSi1Neu1T/Of5Nd6lm1j8vXD+A7+fdEeVNbqa gf/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ysJ41DADuUNjiW2EobBM4/M+gNYcOi8UBhDomz6OvFc=; b=ZRYXqH6DuvTTLOdB4bARUd5K9vGcZFARNs5VN+Cuc3T01YJMpaIOpwL3p6TK5EGC70 bE07RKnkM46kf6KFuJM3wqD+nSWTldHfw6Jw7scYp/sRVmTMwwEel4GbcAUWeUo44BrA pgS/cw2kkTkLgwG+AO3VnOVcOydmSbHpd6LxxGojOvDDR5hh3pYXASNd4HgNN+X+mOVV vZmpJvkyZOz51mdPBZxXn0J85Xqnd8UFsACU/hnA2gv9NVa7EPAeLi1t5KqUqgMRlwK3 s8G6XkcwwI7nZNqlyhQ9l07nfhFL3BHsq7HqcL+ppIb5cz2P31btO1nh2vM2FUFxMHeY g3yg== X-Gm-Message-State: AGi0Puabq4AKDunC5PQa8CG5L39McrB07YQAA4ZRHG086j0oqXTD050y WAEBhuyxbkuDco4Gh29rt2ijZiYVmNZ2uXyHNnI= X-Google-Smtp-Source: APiQypIpugRMWirjgXloBzXACrc/dYYLP+V+Z+XmZIZhm6+CLu5miVaNH6VIMZU//9/OeKFbgYNpIUlewt20OLWdMKA= X-Received: by 2002:a92:5c57:: with SMTP id q84mr16423281ilb.203.1588599674667; Mon, 04 May 2020 06:41:14 -0700 (PDT) MIME-Version: 1.0 References: <20200504131739.11246-1-laoar.shao@gmail.com> <20200504132945.GQ22838@dhcp22.suse.cz> In-Reply-To: <20200504132945.GQ22838@dhcp22.suse.cz> From: Yafang Shao Date: Mon, 4 May 2020 21:40:37 +0800 Message-ID: Subject: Re: [PATCH v2] mm, memcg: add workingset_restore in memory.stat To: Michal Hocko Cc: Andrew Morton , Johannes Weiner , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 4, 2020 at 9:29 PM Michal Hocko wrote: > > On Mon 04-05-20 09:17:39, Yafang Shao wrote: > [...] > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > > index bcc80269bb6a..0733b659e757 100644 > > --- a/Documentation/admin-guide/cgroup-v2.rst > > +++ b/Documentation/admin-guide/cgroup-v2.rst > > @@ -1329,6 +1329,9 @@ PAGE_SIZE multiple when read back. > > workingset_activate > > Number of refaulted pages that were immediately activated > > > > + workingset_restore > > + Number of transitioning of refaulted pages > > + > > I believe something like the following would be more comprehensible > "Number of restored pages which have been detected as an active > workingset before they got reclaimed." > Thanks. Will update it. > > workingset_nodereclaim > > Number of times a shadow node has been reclaimed > > > -- > Michal Hocko > SUSE Labs -- Thanks Yafang