From: Yafang Shao <laoar.shao@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Michal Hocko <mhocko@kernel.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm, oom: don't invoke oom killer if current has been reapered
Date: Tue, 14 Jul 2020 10:13:13 +0800 [thread overview]
Message-ID: <CALOAHbAdMoCHYp6eCcoeNPR6=jPc1xxGYPYZmnCrWPoTE6_QTg@mail.gmail.com> (raw)
In-Reply-To: <06806cf0-a122-e002-191f-348298358882@i-love.sakura.ne.jp>
On Tue, Jul 14, 2020 at 7:50 AM Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
>
> On 2020/07/11 12:18, Yafang Shao wrote:
> > If the current's MMF_OOM_SKIP is set, it means that the current is exiting
> > or dying and likely to realease its address space. So we don't need to
> > invoke the oom killer again. Otherwise that may cause some unexpected
> > issues, for example, bellow is the issue found in our production
> > environment.
>
> What kernel version are you using?
>
The kernel version is 4.18.
> Commit 7775face207922ea ("memcg: killed threads should not invoke memcg OOM killer")
> should solve this problem.
Yes, this commit should fix this issue. Thanks for the information.
But it seems the proposal that using trylock in
mem_cgroup_out_of_memory() should be better?
The trylock could also solve the problem that different processes are
doing oom at the same time.
--
Thanks
Yafang
next prev parent reply other threads:[~2020-07-14 2:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 3:18 Yafang Shao
2020-07-11 5:37 ` Yafang Shao
2020-07-13 6:01 ` Michal Hocko
2020-07-13 6:21 ` Michal Hocko
2020-07-13 12:24 ` Yafang Shao
2020-07-13 12:45 ` Michal Hocko
2020-07-13 13:11 ` Yafang Shao
2020-07-13 19:05 ` Michal Hocko
2020-07-14 0:15 ` Tetsuo Handa
2020-07-14 0:18 ` Tetsuo Handa
2020-07-14 2:09 ` Yafang Shao
2020-07-13 23:50 ` Tetsuo Handa
2020-07-14 2:13 ` Yafang Shao [this message]
2020-07-14 2:42 ` Tetsuo Handa
2020-07-14 2:58 ` Yafang Shao
2020-07-14 4:06 ` Tetsuo Handa
2020-07-14 5:03 ` Yafang Shao
2020-07-14 6:51 ` Michal Hocko
2020-07-14 6:43 ` Michal Hocko
2020-07-14 9:30 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbAdMoCHYp6eCcoeNPR6=jPc1xxGYPYZmnCrWPoTE6_QTg@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox