From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C76F3C25B78 for ; Tue, 4 Jun 2024 02:35:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4220C6B008C; Mon, 3 Jun 2024 22:35:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D1CC6B0092; Mon, 3 Jun 2024 22:35:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 299766B0093; Mon, 3 Jun 2024 22:35:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0BADD6B008C for ; Mon, 3 Jun 2024 22:35:51 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A4D201A0C55 for ; Tue, 4 Jun 2024 02:35:50 +0000 (UTC) X-FDA: 82191640860.30.A9EE5F2 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf30.hostedemail.com (Postfix) with ESMTP id EDCE480009 for ; Tue, 4 Jun 2024 02:35:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PAOLRHIG; spf=pass (imf30.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717468549; a=rsa-sha256; cv=none; b=KbeNZH48cBPu2HoKrPX5OuEPf6giLXkQ5CzrbGHcJBOprFMxla6mCH4Ul/YYxEtCxCueLF 9IpcB715VOnqx/2TOEfvTJPmeIvwdQNRDM/cbulj1ycqAW5zMGmnAUqKOnWx48i6BV1JFT ++uxq7TmAxeS1jcFtaLnc9m48hImz7s= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PAOLRHIG; spf=pass (imf30.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717468549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J0+6VuAcmJuFZUzfJKhRgy9ju+3AX5VnSvOv6JpeqlU=; b=Jm0uaLuDFFUMQX3E15YrIjOwmkRVgT2YnmH5nwuGhsPb4GqHPsF43taxFwotXRxdE6ygWS E0eYA6KpftNNtM1H/+Ao1nh6gtKAwlbdKTfMJ4mT+z5pmeGGpTkQbwr4wtgMSWQ2l1Me4K YPQt8r5jzMTuY9j9fsJd1YgMwLBp8aI= Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-62a0849f8e5so5942777b3.2 for ; Mon, 03 Jun 2024 19:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717468548; x=1718073348; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=J0+6VuAcmJuFZUzfJKhRgy9ju+3AX5VnSvOv6JpeqlU=; b=PAOLRHIGixMUPo5Aqhxxl8oDTXSbHMdHf3C3SuXq8RGr8TVi949VvPA+Fee9TmjHTE CV1H05U0v8Z+XMGup5O3JZZcIghbM5zqNdTyB1rW87KDtzW+VGDGo9/od8o5vdniI+NQ bWZfJ4n7yrD8oLwp71kpLVbMnSyk1dp5IEnZM3wHn5l4N0FKLvDoU+F+a7yKLsXbkwOM CUEMw14wSJb2bVPJalo7TVdxeSN7ab+f0hF3AOjlhir3xETVlpzAymwBIrwfv83+59O+ l+Mm8jEP8uGeXTMO1dXHI3OYeGu7Q5teEOAkMzn7oaHYxq6Tlz68Jn0gGyukFAd0dZ1q Jqzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717468548; x=1718073348; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J0+6VuAcmJuFZUzfJKhRgy9ju+3AX5VnSvOv6JpeqlU=; b=vXBZiZ7II0KxXJ3Mwf8JagdlDyvAKQ0oN4LAYnP9AjgFlVhq++oMlbRCaTtUVNHj05 j0iuAir758B197QFTSG0YcE/4yDc+M/+1J1E8/QnNa7Z1rP59v0smTMVu/6ShSxlUjl4 NiAFIdtGvb4UPf9UuoI+NTHIqIGcKLJN8Y3741TJubvqYVVW/Aa2eb/eqGhNFx+wDQCd wVVBGFdJjADIyVWz3SZvL9CHR/u/66BvyrojuSEWpnqSt+J5aI2JAf2RsBd2detMzGk7 h8Qm0nzXqURKMUx+LE88dPOyL5IeoqCGczAELHqnQUKDgl+yRqd2Yzf++3fK0jVICVNB 11Cw== X-Forwarded-Encrypted: i=1; AJvYcCVWu+VwnEca2SYS9yULTyDCiNJzGstTfheldshUfACgSmmYtXGl6sc36mWOcidBi5S6TmwEDbbKZR8hFZZ4Jgw3/ZI= X-Gm-Message-State: AOJu0YxL/nVNodHHa5y13Me6AFW0MYET7UqHiuhZSjC+GeJ8qnEphz0A m/FoeT3tKHft8j4STObGVk5YJ5f6EBimSPcyQsuBLF+jolEB7DsEaofkWEnQbWbtDbFHYy2Iunz oCP3Hp1MGDTuTk9Ol0M6EgmAYIvBW8kNTqWY= X-Google-Smtp-Source: AGHT+IFsJKKP6E7ehkS12dXoTKwwv7oEaZTZAGuMrX+8lYbnDgjPUWmWSK4wVLj6fy3L5FaNVQwEPCqorB1AY9Yfm7U= X-Received: by 2002:a0d:eb91:0:b0:615:19db:8ed1 with SMTP id 00721157ae682-62c79843f8fmr105571827b3.48.1717468548009; Mon, 03 Jun 2024 19:35:48 -0700 (PDT) MIME-Version: 1.0 References: <20240602023754.25443-1-laoar.shao@gmail.com> <20240602023754.25443-3-laoar.shao@gmail.com> <20240603172008.19ba98ff@gandalf.local.home> <20240603181943.09a539aa@gandalf.local.home> <20240603183742.17b34bc3@gandalf.local.home> <20240603184016.3374559f@gandalf.local.home> In-Reply-To: <20240603184016.3374559f@gandalf.local.home> From: Yafang Shao Date: Tue, 4 Jun 2024 10:35:09 +0800 Message-ID: Subject: Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() To: Steven Rostedt Cc: Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, Masami Hiramatsu , Mathieu Desnoyers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EDCE480009 X-Stat-Signature: 6kcjwj6borc75e8zwcahjsjg4ximfxy3 X-HE-Tag: 1717468548-226564 X-HE-Meta: U2FsdGVkX18LoB+PEkN6Cu82nfjXWeYnquY0rJGxygCzZouEcHS3r9MntmHTN1UvHoEqb7y8PkYECLNUVQ7NkRIw+6S4rS3jtOS+1+CHVd/Es6E5o/8Y/LE4r97HXLAkKV8AwxvZl8yvcvxz/umtP8Q3TgMNaythyJ3jXa0g471QpTRH15lHKl0Kt78QA8eO4p145qOmWVv6UlAQs+Jhqy9z2g2SmKQVip95dUfZdfQkrpCxx9j3E8m4T7KLUny+VDAxKa+bQWhEFJs+NPYk4seJzKMlXR4zJiQIbtBgaZb9S7DIt0PZmhOzivPiZBA9T4aF/lZY/yyw2MoLv3GTCuOpn9f78OYg2Au93nnhJr8orHHlJ8KfxAuEZDmFCz+yHQENQIS5/7UT2WcjreBXqoxjdzgIHAL7Rs8XRXh2hTn4pnNHREyYbeXQ64iP4Xbvift1A37mZnAuh3nmXeAG0/jQEFO2+zst5jzyM/7j3xrez9yM55Xy02IqjqzlqlCEJf31nRC16FaV0Hb+y/sSkgwoLl26CtvXAQbNKg2DuLmnzuORZ03/K9i+i3dXxIhE+MjqEqmleC0NQUeX2Ftxcvu/Qsu9i/o6BriFAuQKKKNfTboOlHg4SDnBD3tq9IjhMa7WqSmb4KDpzRIOmwWdFefG2QF0lHMUhm+IxHZsPpk+ozh4MOIZvgsx1vXRiBNpTZRx1NjwGWDclu8/2fTik2TT8buPLPWJBORN3PmhCY225nOtwYnDwTJi8yn8HLTxMWrmmhueOauBsn3naPnlw2MJfnXvSyaICKGyf2wkou32ExLCS3PUKQZwcw3qRSU2EJC2Ngxhqg809lKDiwU71PCcAL7QVxFmQu7UGGgVx8CThqIcVEmNqrtqXk7JReuUV4UHuhyTHi3YbCVX6S41VQYrM54uxYORLK287XMFYXUtn9MJHIYJv9QXYOInEccIXd1mFEeyxcbGe5FTuBF OPGi5AI2 Km0hRCc9rfrfRnkhKr9hiRPVJZ5W5UKC0df6sdw3lSIByeYIyo6j84/DoG7Lno1x0IoAEIldXVtiYufgvbo2wJdONI+K2AJ9gxjR+2rdylZqPvoC2oiGLoyaC97c/47XH1/+rEV179llUS7jzZ+h8xa0HrOuKwsSGxkPMiHkDlqUqee5Io6rImEGUAQpVRFcMGlSTkj/rPm1/lpQHanelX3JJWLAEQwUUC0YfXNpwRPYXaWll4NLR9KLvoboQtA1bkZIEJooxN6ONBrbHBxWgbTLpXz9+38zQ2NHDdSbFH6Cr+C/+h1HtGHD0G8DNPvt6GMso5jb4+Ocl4PtyGrb5zyrtXjZfxpQHSrNRckK0nqMKvpPlcf27XyxwrchEM5fWNU4ItJm2n9hZ96K5ia4xgD94zoJxNEJ9QJavYSFAIJsXzDTnhpYliQyMp233volKFoTJbygDY5l5B80XHWKtiTKsXeSKOFMjcfItvt6CeUdtWfw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010973, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 4, 2024 at 6:39=E2=80=AFAM Steven Rostedt = wrote: > > On Mon, 3 Jun 2024 18:37:42 -0400 > Steven Rostedt wrote: > > > Note, I've been wanting to get rid of the hard coded TASK_COMM_LEN from= the > > events for a while. As I mentioned before, the only reason the memcpy e= xists > > is because it was added before the __string() logic was. Then it became > > somewhat of a habit to do that for everything that referenced task->com= m. :-/ > > My point is that if we are going to be changing the way we record > task->comm in the events, might as well do the change I've been wanting t= o > do for years. I'd hold off on the sched_switch event, as that's the one > event (and perhaps sched_waking events) that user space may be have > hardcoded how to read it. > > I would be interested in changing it, just to see what breaks, so I would > know where to go fix things. But keep it a separate patch so that it coul= d > be easily reverted. > I will drop the tracing part that includes this patch and the patch #6 in the next version, and leave it to you. --=20 Regards Yafang