From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D36C433E0 for ; Fri, 15 Jan 2021 10:14:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7E0B02399C for ; Fri, 15 Jan 2021 10:14:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E0B02399C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B99A38D0151; Fri, 15 Jan 2021 05:14:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B51D38D0023; Fri, 15 Jan 2021 05:14:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A36098D0151; Fri, 15 Jan 2021 05:14:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 8AC908D0023 for ; Fri, 15 Jan 2021 05:14:55 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4F5251EE6 for ; Fri, 15 Jan 2021 10:14:55 +0000 (UTC) X-FDA: 77707600950.01.leg51_3a079132752e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 2E6DE1004DAA2 for ; Fri, 15 Jan 2021 10:14:55 +0000 (UTC) X-HE-Tag: leg51_3a079132752e X-Filterd-Recvd-Size: 4812 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 10:14:54 +0000 (UTC) Received: by mail-io1-f43.google.com with SMTP id y19so17141333iov.2 for ; Fri, 15 Jan 2021 02:14:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ef9VRlOEucgdmd68H5kgeZlgiYCdQFVwF3M2JfsqzqE=; b=tB/mb6O5KUsJ6z8vv/C37tOj8xZbV+c52pSStCfvasLzEieTbY1SVNr8Byu/v3gs+Q nVSwALLSiYjWpeN81VrIk9Punbtuseo+deWkRCWLsj2v7kZ8jgCNksv2Aa5+d/rSGUOY IgTJYaL7VmaqPtBWBtmVYxhs9QFBvgCA7bLWnZZdnGX77O6ENRxLx8Y4agt5Ia5Y60Ti uqvVNpmpGC8jBs8omcz04TRVxnqqd3X7octwe+2mJ/RJI0/Th3jDhGWNDb6rvMwLXwvp 0OBoxvxeUgjzn0zJ4ZdJh7iGB+nhpkwZkgq6hm79KS4yENtactcI4Ap0vkT0VeugMR23 EyYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ef9VRlOEucgdmd68H5kgeZlgiYCdQFVwF3M2JfsqzqE=; b=Aki2aPiElJf2hAGxsezwLE3HQmWzoxJY/u9O63OZGmDWp2GZY/CFyd37eFWT4ZC7R6 +oAy34bZok8QD8+eJ08DJukTwWYvZ3mNjtNNw47e6a9waIF1BnesN4wv9K9s5fKlLqq5 yK58yrl89ILKDAlEVlqJOxYkn4dCy6OgV2tw6rWtVgRTAZDONwTylvnxJrBigwQYRyez PPrxjxwxMli8wriCQcbPODL/BpMfer23grcTxS5dRtqyVgVrlYFMYRIy6CeIzP5Lj4j1 zvIO79zy7iY8w7OrpbZrXVNf4iaRqiZpyoV3xi2HUr6EshiU3k5jNy4/T+JDUpipxeuW HE9A== X-Gm-Message-State: AOAM530vd0rrocZH7gcIO9TO/7rdAZJ2hTauH6vZVgO+ZAUOabVgo7Tw rXqBh7HvJKFm2hGkcPeb7Afzv2lxWI9O5Ynezng= X-Google-Smtp-Source: ABdhPJy3Z5vIsG9MneYOSIA2ebUHasDFnVB738/QeVYghS2/EI1m4Mt6mScHvGgLSShdy7zitz65d89KCjcdlPjLX8w= X-Received: by 2002:a5d:84cf:: with SMTP id z15mr8048033ior.81.1610705694285; Fri, 15 Jan 2021 02:14:54 -0800 (PST) MIME-Version: 1.0 References: <20210115061349.67386-1-laoar.shao@gmail.com> <20210115061349.67386-2-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Fri, 15 Jan 2021 18:14:17 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm, slub: use pGp to print page flags To: David Hildenbrand Cc: Christoph Lameter , penberg@kernel.org, David Rientjes , iamjoonsoo.kim@lge.com, Andrew Morton , Matthew Wilcox , Johannes Weiner , Michal Hocko , osalvador@suse.de, linmiaohe@huawei.com, steven.price@arm.com, Roman Gushchin , "Huang, Ying" , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 15, 2021 at 4:47 PM David Hildenbrand wrote: > > On 15.01.21 07:13, Yafang Shao wrote: > > As pGp has been already introduced in printk, we'd better use it to make > > the output human readable. > > > > Before this change, the output is, > > [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200 > > > > While after this change, the output is, > > [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) > > > > Signed-off-by: Yafang Shao > > --- > > mm/slub.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/mm/slub.c b/mm/slub.c > > index dc5b42e..901a45a 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -641,8 +641,9 @@ void print_tracking(struct kmem_cache *s, void *object) > > > > static void print_page_info(struct page *page) > > { > > - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n", > > - page, page->objects, page->inuse, page->freelist, page->flags); > > + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", > > + page, page->objects, page->inuse, page->freelist, > > + page->flags, &page->flags); > > > > } > > > > > > Sounds helpful to me. > > "pr_err" combined with "INFO" looks a little weird - "Oh my, something > serious just happened!!!! - but, hey, just for your information ... " :) > Ah, it seems we should improve it. There are many pr_err("INFO) in mm/slub.c... I will change them all in a separate patch. > Reviewed-by: David Hildenbrand Thanks for the review. -- Thanks Yafang