From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC36C2BA2B for ; Thu, 9 Apr 2020 14:00:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9BD4920A8B for ; Thu, 9 Apr 2020 14:00:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r0azHhf1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BD4920A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 442618E000D; Thu, 9 Apr 2020 10:00:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F2D98E0006; Thu, 9 Apr 2020 10:00:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E35A8E000D; Thu, 9 Apr 2020 10:00:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 207ED8E0006 for ; Thu, 9 Apr 2020 10:00:20 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E53D5180AD81D for ; Thu, 9 Apr 2020 14:00:19 +0000 (UTC) X-FDA: 76688476158.09.cows79_773547506b248 X-HE-Tag: cows79_773547506b248 X-Filterd-Recvd-Size: 4062 Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Apr 2020 14:00:19 +0000 (UTC) Received: by mail-il1-f195.google.com with SMTP id p13so10276169ilp.3 for ; Thu, 09 Apr 2020 07:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KuazrbD4UWjNjObPJ9XbrH7wD+IdvFUxRTL3bGvlWH0=; b=r0azHhf1H3b+whS1zuIFqD94OGXp4NqlMzGN5Or26wUixeOq1p0NihIiEZI1iFtXpR luvN/N1SlZA1phbnu0Vg4LLOBPdEnPH4R5JC1Os7vBRC9/wGjzVcimd6x6toRvF3nVg4 0e/vJEL50fdk0lV4aleqDKRVsdKgOYcLWUlWuuJkl+y0HTCKLAH+M35G4AckAGLvV3cm rP/u1D9TIxlX8ut8Y0QboM0hhnZEHgQm4tMz2JOjYh79sOu++qb5fEIa/mD6xjCJ6+jK rnEa9Pdh6oGw/cZ3wPzZEiZOU9L/lO+0aLwCE0cZ19EygTgeKQMhXM6Z3IwLfCiDwooH ZsuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KuazrbD4UWjNjObPJ9XbrH7wD+IdvFUxRTL3bGvlWH0=; b=Tw0REXgAGfuWYSoS44FbNyW/TRIPJrJ+NswlI9NZu1GpOLhG7mwOx6IgxZIL5iq29X w1ufTz28bQr+ZYDsVxgRcet0FfFjPcBJ541axbZULe3JlgRI5loOCQXFjcxARIySqaoZ bdIK9vN0DiSMFtFymGZEFUuqPhENGtr7vC+1O95XL3APmDRXnXjhY73t5k531dEkT4Ff 3GEHvDiRvtzPvkSDXT5yWc+qUVMiMn6pxGgcoSUCr5YfmVFChJBx090aVlje/Cyowt5W 4FOTuY77QCiTx4p0AABcQadGonSrna246KzAhX7qI7X26P71yMGhD18KJWbX2r13Xsi1 +iTA== X-Gm-Message-State: AGi0PuYdpTxj8j5SBtjPVFjcx6VXo58VScBslqBEosVfrk4OgOxXOT17 UMlwoi25xWSGuKbsL7zT9CpCCJNvLoQ1VQ2BLWQ= X-Google-Smtp-Source: APiQypLryDm6oemW376Sa/0Ig5YvXE6qtq8jQhLzr8etjGclz42Vhpa7eUZJbYSjQ7IfNlveRbhSVOKk7MN41KG7CP4= X-Received: by 2002:a92:d850:: with SMTP id h16mr5249292ilq.203.1586440818580; Thu, 09 Apr 2020 07:00:18 -0700 (PDT) MIME-Version: 1.0 References: <1586192163-20099-1-git-send-email-laoar.shao@gmail.com> <20200406162343.6ae4b8f74c74bcb84d026471@linux-foundation.org> <20200406200916.2623f34403155264d8c8e9e7@linux-foundation.org> <20200407064329.GB18914@dhcp22.suse.cz> <20200407111017.GN18914@dhcp22.suse.cz> <20200407181012.GA12461@cmpxchg.org> <20200408182956.0906ebc4f8ec421689ec6df5@linux-foundation.org> <20200409065722.GA18386@dhcp22.suse.cz> In-Reply-To: <20200409065722.GA18386@dhcp22.suse.cz> From: Yafang Shao Date: Thu, 9 Apr 2020 21:59:42 +0800 Message-ID: Subject: Re: [PATCH v3] mm, memcg: fix error return value of mem_cgroup_css_alloc() To: Michal Hocko Cc: Andrew Morton , Johannes Weiner , Matthew Wilcox , Vladimir Davydov , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 9, 2020 at 2:57 PM Michal Hocko wrote: > > On Wed 08-04-20 18:29:56, Andrew Morton wrote: > > On Tue, 7 Apr 2020 14:10:12 -0400 Johannes Weiner wrote: > > > > > Given how unlikely this is to affect real setups, I don't think this > > > patch is stable material. > > > > OK, thanks, done. > > > > I didn't notice any acks - is this patch otherwise good to go upstream? > > I will ack it if s@EBUSY@ENOSPC@ > BTW, there's no EBUSY in man page of write(2) neither. But when we echo some procs into cgroup.subtree_control of a non-root cgroup, it will return EBUSY. See also cgroup_subtree_control_write(). Pls. correct me if I missed something. We have to admit that the man page is out of date. Thanks Yafang