From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC99EC43215 for ; Wed, 27 Nov 2019 12:02:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9BC65206F0 for ; Wed, 27 Nov 2019 12:02:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d+u9GOW3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BC65206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2E8BF6B0398; Wed, 27 Nov 2019 07:02:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C1906B0399; Wed, 27 Nov 2019 07:02:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FCAA6B039A; Wed, 27 Nov 2019 07:02:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 093EC6B0398 for ; Wed, 27 Nov 2019 07:02:00 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 89B5140C7 for ; Wed, 27 Nov 2019 12:01:59 +0000 (UTC) X-FDA: 76201918758.11.hook54_11549b6636f01 X-HE-Tag: hook54_11549b6636f01 X-Filterd-Recvd-Size: 4130 Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Nov 2019 12:01:58 +0000 (UTC) Received: by mail-io1-f67.google.com with SMTP id k13so24516093ioa.9 for ; Wed, 27 Nov 2019 04:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mxim43jMCDrw4zdWkymKRiw96nY7xvfwuWLW6/0ccDA=; b=d+u9GOW3u6tEYK9VUiNBuI0xMQM2xdWYQschUiV7JvYiTJiu8YIAMpmJg+jMw28rUt towtkcjBMdfnISBcSplr4XkNmsYEKt8l2QR2lcs/htHGWy4PWiK1gAYVoTHwHUoTOXrm I4Ir+/8eMS6ofp7TUfbmEaRpEoNKCpUKpljNqqF8EY0OX1BRIou+rF8jqx1UUoh9mVbd Ds4lElPcHxku8jZJPWDTS1M8I+EtQGxAZkFg/hoEunBxFialo/R5D+Ntr80HEGqcziMA kYgDOHVu/HeO2WZXn0RcoSBxUcO8v1AA+5NHGyGTU14H8QSOMUhqKg93K11qvnO5xauo gLYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mxim43jMCDrw4zdWkymKRiw96nY7xvfwuWLW6/0ccDA=; b=tIIpfNjkA+08OC9+RbtnY7asP963CCGPFDodyPzNagpYQEmmfHiHUKR5zbMq1LcD5S ODl3xy+jFVKL3rYsD9RgpM5cbBStAPQ8XhI1leIr9M19aI9PoqcU9er0QOs/JygT2NT/ Z/cIQ8Lj3UefT3w6oyjPpuzgk6E/rOwYXTxLFKXzalLaNi6ImUWNKeM2RPKizgCLNA18 tY/JDtqaHgWDZ9iQJgl/y52ESCI0lcVi8tIgqQULMSRKkYICWE4X2ZS9w8boARAt9dgw +hebwHGTRX8SoTc1nzPTconmS+No/ZHWa3hNOrWKkDEHc1baAHVArxdFTSKb2D69DIhu k9gg== X-Gm-Message-State: APjAAAXpPYXXyyKkyKAejgzsrBKD6pgpkC41FQWn9ZySol//yF/QQ71e /35+8fhi4Rg409PBOKPmpoISImKvNgP13xVBivA= X-Google-Smtp-Source: APXvYqwMGF19+LIq3kpHlUHzHhk6kxHomIoFnG9hL3/qKmd05c+yUU4G/W0jPCd4Jl0xi0FJsvIbASgJy6xgcEolAc4= X-Received: by 2002:a5d:8953:: with SMTP id b19mr9250802iot.168.1574856118212; Wed, 27 Nov 2019 04:01:58 -0800 (PST) MIME-Version: 1.0 References: <1574818117-2885-1-git-send-email-laoar.shao@gmail.com> <20191127115830.GQ20912@dhcp22.suse.cz> In-Reply-To: <20191127115830.GQ20912@dhcp22.suse.cz> From: Yafang Shao Date: Wed, 27 Nov 2019 20:01:22 +0800 Message-ID: Subject: Re: [PATCH v2] mm, memcg: avoid oom if cgroup is not populated To: Michal Hocko Cc: David Hildenbrand , Johannes Weiner , Vladimir Davydov , Andrew Morton , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000074, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 27, 2019 at 7:58 PM Michal Hocko wrote: > > On Wed 27-11-19 19:35:03, Yafang Shao wrote: > [...] > > > 3. I think I agree with Michal that modifying the limits smells more > > > like a configuration thingy to be handled by an admin (especially, adapt > > > min/max properly). But again, not sure where that change is located :) > > > > > > > I agree with you all, but that is Michal told me to do. See above and > > the disccussion in this thread. > > Look, I have tried to help you here. Thanks for your help and patience. > I have explained why force_empty is > not a part of cgroup v2. I have suggested to use hard limit to achieve > a similar outcome. The OOM killer is a natural part of the hard limit - > I guess I could have been more explicit about that. As Johannes noted > high limit can be used as well (you need to have a task in the memcg > context for that to be effective). > I trust you so I tried your solution. > Since then you have tried to tweak the code here and there with a very > weak justification and now you are complaining and questioning my > expertise. Please think about your attitude. > I'm sorry if my wrong expression offend you, which is not I mean to. Thanks Yafang