Re: [PATCH v2] mm, memcg: avoid oom if cgroup is not populated

[Yafang Shao <laoar.shao@gmail.com>]

On Wed, Nov 27, 2019 at 7:58 PM Michal Hocko <mhocko@kernel.org> wrote:
>
> On Wed 27-11-19 19:35:03, Yafang Shao wrote:
> [...]
> > > 3. I think I agree with Michal that modifying the limits smells more
> > > like a configuration thingy to be handled by an admin (especially, adapt
> > > min/max properly). But again, not sure where that change is located :)
> > >
> >
> > I agree with you all, but that is Michal told me to do. See above and
> > the disccussion in this thread.
>
> Look, I have tried to help you here.

Thanks for your help and patience.

> I have explained why force_empty is
> not a part of cgroup v2. I have suggested to use hard limit to achieve
> a similar outcome. The OOM killer is a natural part of the hard limit -
> I guess I could have been more explicit about that. As Johannes noted
> high limit can be used as well (you need to have a task in the memcg
> context for that to be effective).
>

I trust you so I tried your solution.

> Since then you have tried to tweak the code here and there with a very
> weak justification and now you are complaining and questioning my
> expertise. Please think about your attitude.
>

I'm sorry if my wrong expression offend you, which is not I mean to.

Thanks
Yafang